NetBSD Problem Report #51822

From www@NetBSD.org  Wed Jan 11 07:41:22 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A31207A280
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 11 Jan 2017 07:41:22 +0000 (UTC)
Message-Id: <20170111074121.B87357A2B6@mollari.NetBSD.org>
Date: Wed, 11 Jan 2017 07:41:21 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] add additional t_memmem check
X-Send-Pr-Version: www-1.0

>Number:         51822
>Category:       bin
>Synopsis:       [PATCH] add additional t_memmem check
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 11 07:45:00 +0000 2017
>Closed-Date:    Sun Jun 03 08:57:13 +0000 2018
>Last-Modified:  Sun Jun 03 08:57:13 +0000 2018
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
Add an additional memmem check; the other checks use different needles to search the haystack -- the additional test case verifies that the "end" of the haystack isn't matched.

Submitted by: Peter Holm <pholm@FreeBSD.org>
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51822: [PATCH] add additional t_memmem check
Date: Tue, 10 Jan 2017 23:56:51 -0800

 --Apple-Mail=_59BC736F-9F6A-4986-8517-FFCE95E6D971
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.

 --Apple-Mail=_59BC736F-9F6A-4986-8517-FFCE95E6D971
 Content-Disposition: attachment;
 	filename=t_memmem-add-additional-testcase.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_memmem-add-additional-testcase.patch"
 Content-Transfer-Encoding: 7bit

 Index: t_memmem.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/string/t_memmem.c,v
 retrieving revision 1.2
 diff -u -r1.2 t_memmem.c
 --- t_memmem.c	7 Jul 2011 08:27:36 -0000	1.2
 +++ t_memmem.c	11 Jan 2017 07:36:20 -0000
 @@ -51,6 +51,8 @@
  int lp6 = 1;
  char p7[] = "654";
  int lp7 = 3;
 +char p8[] = "89abc";
 +int lp8 = 5;

  char b0[] = "";
  int lb0 = 0;
 @@ -89,6 +91,7 @@

  	expect(memmem(b2, lb2, p4, lp4) == NULL);
  	expect(memmem(b2, lb2, p7, lp7) == NULL);
 +	expect(memmem(b2, lb2, p8, lp8) == NULL);
  }

  ATF_TP_ADD_TCS(tp)

 --Apple-Mail=_59BC736F-9F6A-4986-8517-FFCE95E6D971--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51822 CVS commit: src/tests/lib/libc/string
Date: Wed, 11 Jan 2017 13:07:37 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Jan 11 18:07:37 UTC 2017

 Modified Files:
 	src/tests/lib/libc/string: t_memmem.c

 Log Message:
 PR/51822: Ngie Cooper: add additional t_memmem check


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libc/string/t_memmem.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 03 Jun 2018 08:57:13 +0000
State-Changed-Why:
Committed by christos. Thanks for the patch.


>Unformatted:

Home	PR Database Search