NetBSD Problem Report #51833

From www@NetBSD.org  Thu Jan 12 06:07:22 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 5DA7F7A2A1
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 12 Jan 2017 06:07:22 +0000 (UTC)
Message-Id: <20170112060721.6AABD7A2B6@mollari.NetBSD.org>
Date: Thu, 12 Jan 2017 06:07:21 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/gen/t_siginfo: use portable #includes
X-Send-Pr-Version: www-1.0

>Number:         51833
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libc/gen/t_siginfo: use portable #includes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 12 06:10:01 +0000 2017
>Closed-Date:    Wed Jan 17 00:17:16 +0000 2018
>Last-Modified:  Wed Jan 17 00:20:01 +0000 2018
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
The attached patch uses portable #includes so the test can be compiled on FreeBSD and sorts the headers.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51833: [PATCH] tests/lib/libc/gen/t_siginfo: use portable
 #includes
Date: Wed, 11 Jan 2017 22:11:08 -0800

 --Apple-Mail=_85A99549-D4C1-4BA7-AAE7-ACF54AA5C9EE
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie


 --Apple-Mail=_85A99549-D4C1-4BA7-AAE7-ACF54AA5C9EE
 Content-Disposition: attachment;
 	filename=lib-libc-gen-t_siginfo-use-portable-headers-and-sort-them.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="lib-libc-gen-t_siginfo-use-portable-headers-and-sort-them.patch"
 Content-Transfer-Encoding: 7bit

 Index: gen/t_siginfo.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/gen/t_siginfo.c,v
 retrieving revision 1.30
 diff -u -r1.30 t_siginfo.c
 --- gen/t_siginfo.c	22 Dec 2015 14:25:58 -0000	1.30
 +++ gen/t_siginfo.c	12 Jan 2017 05:11:41 -0000
 @@ -28,7 +28,6 @@

  #include <atf-c.h>

 -#include <sys/inttypes.h>
  #include <sys/resource.h>
  #include <sys/sysctl.h>
  #include <sys/time.h>
 @@ -36,13 +35,14 @@
  #include <sys/wait.h>

  #include <assert.h>
 +#include <float.h>
 +#include <inttypes.h>
 +#include <setjmp.h>
  #include <signal.h>
  #include <stdio.h>
  #include <stdlib.h>
  #include <string.h>
  #include <unistd.h>
 -#include <setjmp.h>
 -#include <float.h>

  #include <fenv.h>
  #ifdef __HAVE_FENV

 --Apple-Mail=_85A99549-D4C1-4BA7-AAE7-ACF54AA5C9EE--

From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org
Subject: Re: bin/51833: [PATCH] tests/lib/libc/gen/t_siginfo: use portable
 #includes
Date: Fri, 13 Jan 2017 17:08:27 -0800

 > On Jan 11, 2017, at 10:15 PM, Ngie Cooper (yaneurabeya) =
 <yaneurabeya@gmail.com> wrote:
 >=20
 > The following reply was made to PR bin/51833; it has been noted by =
 GNATS.
 >=20
 > From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
 > To: gnats-bugs@NetBSD.org
 > Cc:=20
 > Subject: Re: bin/51833: [PATCH] tests/lib/libc/gen/t_siginfo: use =
 portable
 > #includes
 > Date: Wed, 11 Jan 2017 22:11:08 -0800
 >=20
 > --Apple-Mail=3D_85A99549-D4C1-4BA7-AAE7-ACF54AA5C9EE
 > Content-Transfer-Encoding: 7bit
 > Content-Type: text/plain;
 > 	charset=3Dus-ascii
 >=20
 > Patch attached.
 > -Ngie

 Hi!
 	I was wondering if you had received the previous patch.
 Thanks!
 -Ngie=

From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org
Subject: Re: bin/51833: [PATCH] tests/lib/libc/gen/t_siginfo: use portable
 #includes
Date: Sun, 15 Jan 2017 13:24:59 -0800

 Ping?
 -Ngie

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 17 Jan 2018 00:17:16 +0000
State-Changed-Why:
Applied, thanks for the patch!


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51833 CVS commit: src/tests/lib/libc/gen
Date: Wed, 17 Jan 2018 00:16:43 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Wed Jan 17 00:16:43 UTC 2018

 Modified Files:
 	src/tests/lib/libc/gen: t_siginfo.c

 Log Message:
 Improve portability of headers and sort them.

 From Ngie Cooper in PR bin/51833


 To generate a diff of this commit:
 cvs rdiff -u -r1.31 -r1.32 src/tests/lib/libc/gen/t_siginfo.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search