NetBSD Problem Report #51834

From www@NetBSD.org  Thu Jan 12 06:09:32 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 8861E7A2BD
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 12 Jan 2017 06:09:32 +0000 (UTC)
Message-Id: <20170112060931.9AEC77A2BE@mollari.NetBSD.org>
Date: Thu, 12 Jan 2017 06:09:31 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libc/time/t_strptime: use ATF_CHECK_MSG instead of ATF_REQUIRE_MSG
X-Send-Pr-Version: www-1.0

>Number:         51834
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libc/time/t_strptime: use ATF_CHECK_MSG instead of ATF_REQUIRE_MSG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 12 06:10:01 +0000 2017
>Closed-Date:    Sun Jun 03 08:49:14 +0000 2018
>Last-Modified:  Sun Jun 03 08:50:00 +0000 2018
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
Using ATF_CHECK_MSG will allow the tester to catch all failures.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51834: [PATCH] tests/lib/libc/time/t_strptime: use
 ATF_CHECK_MSG instead of ATF_REQUIRE_MSG
Date: Wed, 11 Jan 2017 22:10:41 -0800

 --Apple-Mail=_BDE705A5-C2AA-4C61-B348-C9B179A2FFD7
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie

 --Apple-Mail=_BDE705A5-C2AA-4C61-B348-C9B179A2FFD7
 Content-Disposition: attachment;
 	filename*0=lib-libc-time-t_strptime-use-ATF_CHECK-instead-of_ATF_REQUIRE-to;
 	filename*1=-catch-all-failures.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="lib-libc-time-t_strptime-use-ATF_CHECK-instead-of_ATF_REQUIRE-to-catch-all-failures.patch"
 Content-Transfer-Encoding: 7bit

 Index: time/t_strptime.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/time/t_strptime.c,v
 retrieving revision 1.12
 diff -u -r1.12 t_strptime.c
 --- time/t_strptime.c	31 Oct 2015 02:25:11 -0000	1.12
 +++ time/t_strptime.c	12 Jan 2017 05:12:29 -0000
 @@ -51,12 +51,12 @@
  	exp = buf + len;
  	ret = strptime(buf, fmt, &tm);

 -	ATF_REQUIRE_MSG(ret == exp,
 +	ATF_CHECK_MSG(ret == exp,
  	    "strptime(\"%s\", \"%s\", tm): incorrect return code: "
  	    "expected: %p, got: %p", buf, fmt, exp, ret);

  #define H_REQUIRE_FIELD(field)						\
 -		ATF_REQUIRE_MSG(tm.field == field,			\
 +		ATF_CHECK_MSG(tm.field == field,			\
  		    "strptime(\"%s\", \"%s\", tm): incorrect %s: "	\
  		    "expected: %d, but got: %d", buf, fmt,		\
  		    ___STRING(field), field, tm.field)
 @@ -78,7 +78,7 @@
  {
  	struct tm tm = { -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, NULL };

 -	ATF_REQUIRE_MSG(strptime(buf, fmt, &tm) == NULL, "strptime(\"%s\", "
 +	ATF_CHECK_MSG(strptime(buf, fmt, &tm) == NULL, "strptime(\"%s\", "
  	    "\"%s\", &tm) should fail, but it didn't", buf, fmt);
  }


 --Apple-Mail=_BDE705A5-C2AA-4C61-B348-C9B179A2FFD7--

From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org
Subject: Re: bin/51834: [PATCH] tests/lib/libc/time/t_strptime: use
 ATF_CHECK_MSG instead of ATF_REQUIRE_MSG
Date: Sun, 15 Jan 2017 13:21:40 -0800

 Hi,
 	Is there anything I need to do with this patch for it to be =
 contributed back?
 Thanks!
 -Ngie=

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51834 CVS commit: src/tests/lib/libm
Date: Sun, 3 Jun 2018 08:39:00 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Sun Jun  3 08:39:00 UTC 2018

 Modified Files:
 	src/tests/lib/libm: t_scalbn.c

 Log Message:
 Test and clear exception around scalbn calls.
 Second part of PR bin/51834.

 ifdef out vax to avoid netbsd-specific macros.


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 src/tests/lib/libm/t_scalbn.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 03 Jun 2018 08:49:14 +0000
State-Changed-Why:
Applied. thanks for the patch.


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51834 CVS commit: src/tests/lib/libc/time
Date: Sun, 3 Jun 2018 08:48:37 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Sun Jun  3 08:48:37 UTC 2018

 Modified Files:
 	src/tests/lib/libc/time: t_strptime.c

 Log Message:
 use ATF_CHECK instead of ATF_REQUIRE
 (continue on failure, to see the rest of the failures)

 From Ngie Cooper in PR bin/51834


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 src/tests/lib/libc/time/t_strptime.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search