NetBSD Problem Report #51902

From www@NetBSD.org  Sat Jan 21 16:57:49 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 5132C7A293
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 21 Jan 2017 16:57:49 +0000 (UTC)
Message-Id: <20170121165748.62A297A2B7@mollari.NetBSD.org>
Date: Sat, 21 Jan 2017 16:57:48 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/dev/pci/ahc_pci.c: bad call to ahc_9005_subdevinfo_valid
X-Send-Pr-Version: www-1.0

>Number:         51902
>Category:       kern
>Synopsis:       src/sys/dev/pci/ahc_pci.c: bad call to ahc_9005_subdevinfo_valid
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 21 17:00:00 +0000 2017
>Originator:     David Binderman
>Release:        cvs-20170121
>Organization:
>Environment:
>Description:
[src/sys/dev/pci/ahc_pci.c:703] -> [src/sys/dev/pci/ahc_pci.c:1120]: (warning) Function 'ahc_9005_subdevinfo_valid' argument order different: declaration 'vendor, device, subvendor, subdevice' definition 'device, vendor, subdevice, subvendor'

$ fgrep ahc_9005_subdevinfo_valid src/sys/dev/pci/ahc_pci.c
static int ahc_9005_subdevinfo_valid(uint16_t vendor, uint16_t device,
	    && ahc_9005_subdevinfo_valid(PCI_VENDOR(id), PCI_PRODUCT(id),
ahc_9005_subdevinfo_valid(uint16_t device, uint16_t vendor,
$

So we can see that declaration and call both match, but they
don't match the definition.


>How-To-Repeat:

>Fix:

Home	PR Database Search