NetBSD Problem Report #51905
From www@NetBSD.org Sun Jan 22 16:04:35 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 2CF1E7A271
for <gnats-bugs@gnats.NetBSD.org>; Sun, 22 Jan 2017 16:04:35 +0000 (UTC)
Message-Id: <20170122160433.2B2097A2C1@mollari.NetBSD.org>
Date: Sun, 22 Jan 2017 16:04:33 +0000 (UTC)
From: smesgr@gmail.com
Reply-To: smesgr@gmail.com
To: gnats-bugs@NetBSD.org
Subject: GXIO Expension boards arn't configured if GXIO_DEFAULT_EXPANSION isn't defined
X-Send-Pr-Version: www-1.0
>Number: 51905
>Category: port-evbarm
>Synopsis: GXIO Expension boards arn't configured if GXIO_DEFAULT_EXPANSION isn't defined
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: port-evbarm-maintainer
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Jan 22 16:05:00 +0000 2017
>Closed-Date: Sat Apr 21 06:32:28 +0000 2018
>Last-Modified: Sat Apr 21 06:32:28 +0000 2018
>Originator: Stephan Meisinger
>Release: -current starting Sat Oct 15 15:27:18 2016 UTC
>Organization:
>Environment:
evbarm on GUMSTIX
>Description:
if GXIO_DEFAULT_EXPANSION isn't compiled the GXIO expansion board isn't configured due to a sofware bug introduced in October 2016. This then leads to a kernel panic on boot:
panic: kernel debugging assertion "gpio < GPIO_NPINS" failed: file "/usr/src/sys/arch/arm/xscale/pxa2x0_gpio.c", line 446
Stopped in pid 0.20 (system) at netbsd:cpu_Debugger+0x4: bx r14
>How-To-Repeat:
boot the default GUMSTIX kernel with an expansion board
>Fix:
Index: sys/arch/evbarm/gumstix/gxio.c
===================================================================
RCS file: /cvsroot/src/sys/arch/evbarm/gumstix/gxio.c,v
retrieving revision 1.24
diff -u -r1.24 gxio.c
--- sys/arch/evbarm/gumstix/gxio.c 28 Oct 2016 19:00:48 -0000 1.24
+++ sys/arch/evbarm/gumstix/gxio.c 22 Jan 2017 15:58:04 -0000
@@ -694,7 +694,7 @@
gxioconflist[i].name,
i == d ? " (DEFAULT)" : "");
- if (s < 0 || gxioconflist[i].name == NULL) {
+ if (s < 0 || gxioconflist[s].name == NULL) {
#ifdef GXIO_DEFAULT_EXPANSION
expansion = __UNCONST(GXIO_DEFAULT_EXPANSION);
#else
@@ -731,9 +731,9 @@
#endif
printf("configure %s expansion (%s)\n",
- (s < 0 || gxioconflist[i].name == NULL) ? "default" : "specified",
+ (s < 0 || gxioconflist[s].name == NULL) ? "default" : "specified",
expansion);
- gxioconflist[(s < 0 || gxioconflist[i].name == NULL) ? d : s].config();
+ gxioconflist[(s < 0 || gxioconflist[s].name == NULL) ? d : s].config();
}
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: port-evbarm-maintainer->kiyohara
Responsible-Changed-By: maya@NetBSD.org
Responsible-Changed-When: Sun, 22 Jan 2017 16:57:17 +0000
Responsible-Changed-Why:
Kiyohara, what do you think?
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/51905 CVS commit: src/sys/arch/evbarm/gumstix
Date: Sun, 22 Jan 2017 12:19:32 -0500
Module Name: src
Committed By: christos
Date: Sun Jan 22 17:19:32 UTC 2017
Modified Files:
src/sys/arch/evbarm/gumstix: gxio.c
Log Message:
PR/51905: GXIO Expension boards arn't configured if GXIO_DEFAULT_EXPANSION
isn't defined. Fix a bunch of issues with the original code.
To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/arch/evbarm/gumstix/gxio.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: kiyohara->port-evbarm-maintainer
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Mon, 16 Apr 2018 04:25:16 +0000
Responsible-Changed-Why:
kiyohara resigned
State-Changed-From-To: open->feedback
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 16 Apr 2018 04:25:31 +0000
State-Changed-Why:
Christos committed something, did that fix the problem?
From: smesgr <smesgr@gmail.com>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: Re: port-evbarm/51905
Date: Sat, 21 Apr 2018 07:45:01 +0200
yes the issue was solved.
State-Changed-From-To: feedback->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Sat, 21 Apr 2018 06:32:28 +0000
State-Changed-Why:
Fixed, thanks for the report
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.