NetBSD Problem Report #51909

From root@nbsd.backwatcher.com  Mon Jan 23 12:15:05 2017
Return-Path: <root@nbsd.backwatcher.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 934757A28D
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 23 Jan 2017 12:15:05 +0000 (UTC)
Message-Id: <20170123121503.380182EFEC@nbsd.backwatcher.com>
Date: Mon, 23 Jan 2017 04:15:03 -0800 (PST)
From: amonk@backwatcher.com
Reply-To: amonk@backwatcher.com
To: gnats-bugs@NetBSD.org
Subject: blacklistctl -b option broken
X-Send-Pr-Version: 3.95

>Number:         51909
>Notify-List:    bsiegert@NetBSD.org
>Category:       bin
>Synopsis:       The -b option of blacklistctl produces no result.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 23 12:20:00 +0000 2017
>Closed-Date:    Tue Apr 09 12:32:04 +0000 2019
>Last-Modified:  Tue Apr 09 12:32:04 +0000 2019
>Originator:     Kyle Amon
>Release:        NetBSD 7.0.2_PATCH
>Organization:
BackWatcher, Inc.

>Environment:


System: NetBSD nbsd.backwatcher.com 7.0.2_PATCH NetBSD 7.0.2_PATCH (XEN3_DOM0) amd64
Architecture: x86_64
Machine: amd64
>Description:
According to blacklistctl(8), the -b option is supposed to "show only the
blocked entries," but it does not show them.  Running 'grep blacklistd
/var/log/messages' shows blocks having occured.  The -a option of blacklistctl
shows the id of blocked entries, indicating they have been added to the npf
blacklistd ruleeset by npfctl.  Running 'npfctl rule blacklistd list' shows
them actually in npf's blacklistd ruleset.  Still, the blacklistctl -b
option produces nothing.

>How-To-Repeat:
Try to use the blacklistctl -b option.

>Fix:
Unknown.


>Release-Note:

>Audit-Trail:
From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Cc: 
Subject: Re: bin/51909: blacklistctl -b option broken
Date: Mon, 23 Jan 2017 11:19:57 -0500

 On Jan 23, 12:20pm, amonk@backwatcher.com (amonk@backwatcher.com) wrote:
 -- Subject: bin/51909: blacklistctl -b option broken

 | Try to use the blacklistctl -b option.

 I thought that was pulled up. I will ask for a pullup...


  #include <sys/cdefs.h>
 -__RCSID("$NetBSD: blacklistctl.c,v 1.20 2016/04/04 15:52:56 christos Exp $");
 +__RCSID("$NetBSD: blacklistctl.c,v 1.21 2016/11/02 03:15:07 jnemeth Exp $");

  #include <stdio.h>
  #include <time.h>
 @@ -96,10 +96,10 @@
                         break;
                 case 'b':
                         blocked = 1;
 +                       break;
                 case 'D':
                         dbname = optarg;
                         break;
 -                       break;
                 case 'd':
                         debug++;
                         break;

From: John Nemeth <jnemeth@cue.bc.ca>
To: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,
        amonk@backwatcher.com
Cc: 
Subject: Re: bin/51909: blacklistctl -b option broken
Date: Mon, 23 Jan 2017 10:49:15 -0800

 On Jan 23,  4:25pm, Christos Zoulas wrote:
 }
 } The following reply was made to PR bin/51909; it has been noted by GNATS.
 } 
 } From: christos@zoulas.com (Christos Zoulas)
 } To: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
 } Subject: Re: bin/51909: blacklistctl -b option broken
 } Date: Mon, 23 Jan 2017 11:19:57 -0500
 } 
 }  On Jan 23, 12:20pm, amonk@backwatcher.com (amonk@backwatcher.com) wrote:
 }  -- Subject: bin/51909: blacklistctl -b option broken
 }  
 }  | Try to use the blacklistctl -b option.
 }  
 }  I thought that was pulled up. I will ask for a pullup...

      It was.  Ticket #1330, pulled up on Dec. 18th (which was about
 two months after 7.0.2 was released), but only to netbsd-7.

 }-- End of excerpt from Christos Zoulas

State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Tue, 09 Apr 2019 12:32:04 +0000
State-Changed-Why:
Fix committed and pulled up.


>Unformatted:

Home	PR Database Search