NetBSD Problem Report #51933

From www@NetBSD.org  Wed Feb  1 14:22:10 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id AAEA47A16A
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  1 Feb 2017 14:22:10 +0000 (UTC)
Message-Id: <20170201142209.D6ABC7A1AE@mollari.NetBSD.org>
Date: Wed,  1 Feb 2017 14:22:09 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: sys/arch/atari/vme/leo.c: 2 * bad condition ?
X-Send-Pr-Version: www-1.0

>Number:         51933
>Category:       port-atari
>Synopsis:       sys/arch/atari/vme/leo.c: 2 * bad condition ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-atari-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 01 14:25:00 +0000 2017
>Closed-Date:    Sat Feb 04 23:42:07 +0000 2017
>Last-Modified:  Sat Feb 04 23:42:07 +0000 2017
>Originator:     David Binderman
>Release:        cvs-20170201
>Organization:
>Environment:
>Description:
src/sys/arch/atari/vme/leo.c:336]: (style) Condition '255' is always true

Source code is

        bus_space_write_1(sc->sc_iot, sc->sc_ioh, LEO_REG_MSBSCROLL,
              (scroll >> 6) && 0xff);

maybe better code

        bus_space_write_1(sc->sc_iot, sc->sc_ioh, LEO_REG_MSBSCROLL,
              (scroll >> 6) & 0xff);

src/sys/arch/atari/vme/leo.c:338]: (style) Condition '255' is always true

Duplicate.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51933 CVS commit: src/sys/arch/atari/vme
Date: Wed, 1 Feb 2017 09:33:10 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Feb  1 14:33:10 UTC 2017

 Modified Files:
 	src/sys/arch/atari/vme: leo.c

 Log Message:
 PR/51933: David Binderman: Boolean confusion


 To generate a diff of this commit:
 cvs rdiff -u -r1.21 -r1.22 src/sys/arch/atari/vme/leo.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: jakllsch@NetBSD.org
State-Changed-When: Wed, 01 Feb 2017 19:13:22 +0000
State-Changed-Why:
patch was applied


State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 04 Feb 2017 23:42:07 +0000
State-Changed-Why:
committed, shouldn't really need feedback on these things


>Unformatted:

Home	PR Database Search