NetBSD Problem Report #52026

From www@NetBSD.org  Fri Mar  3 18:09:04 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 31C9F7A1F8
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  3 Mar 2017 18:09:04 +0000 (UTC)
Message-Id: <20170303180903.11BD97A28C@mollari.NetBSD.org>
Date: Fri,  3 Mar 2017 18:09:03 +0000 (UTC)
From: mj@mjturner.net
Reply-To: mj@mjturner.net
To: gnats-bugs@NetBSD.org
Subject: misc/ansiweather: Should honour ~/.ansiweatherrc, like upstream
X-Send-Pr-Version: www-1.0

>Number:         52026
>Category:       pkg
>Synopsis:       misc/ansiweather: Should honour ~/.ansiweatherrc, like upstream
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    fcambus
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 03 18:10:00 +0000 2017
>Closed-Date:    Tue Jun 21 05:03:45 +0000 2022
>Last-Modified:  Tue Jun 21 05:03:45 +0000 2022
>Originator:     Michael-John Turner
>Release:        current
>Organization:
>Environment:
Darwin tesla.xx.yy 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64
>Description:
Upstream ansiweather allows for a configuration file to exist in the user's home directory. pkgsrc changes this behaviour so that only a system-wide configuration file is read.

The pkgsrc behaviour surprised me. Perhaps a better solution would be to check if the user has a configuration file and use that, otherwise use the system-wide configuration?

>How-To-Repeat:
1) Create ~/.ansiweatherrc
2) Run ansiweather
3) Configuration file is ignored
>Fix:
See above for a suggestion.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->fcambus
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Sun, 22 May 2022 23:10:44 +0000
Responsible-Changed-Why:
Over to maintainer.

Probably it should be taught to read both a system config and a user config,
since I expect the idea of the package arrangement is to make it work out of
the box and it doesn't work if no config exists.

Since the maintainer is also upstream he's the best person to decide.


From: "Frederic Cambus" <fcambus@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52026 CVS commit: pkgsrc/misc/ansiweather
Date: Sat, 18 Jun 2022 18:11:27 +0000

 Module Name:	pkgsrc
 Committed By:	fcambus
 Date:		Sat Jun 18 18:11:27 UTC 2022

 Modified Files:
 	pkgsrc/misc/ansiweather: Makefile

 Log Message:
 ansiweather: remove SUBST directives, they are not run anymore.

 They haven't been run since SUBST_STAGE.config was set to pre-configure
 in revision 1.8, as NO_CONFIGURE is set to "yes". This accidentally
 fixed PR pkg/52026.


 To generate a diff of this commit:
 cvs rdiff -u -r1.16 -r1.17 pkgsrc/misc/ansiweather/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Frederic Cambus" <fcambus@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52026 CVS commit: pkgsrc/misc/ansiweather
Date: Sat, 18 Jun 2022 18:34:59 +0000

 Module Name:	pkgsrc
 Committed By:	fcambus
 Date:		Sat Jun 18 18:34:59 UTC 2022

 Modified Files:
 	pkgsrc/misc/ansiweather: Makefile

 Log Message:
 ansiweather: stop installing a global configuration file, it's unused.

 Since revision 1.8, ansiweather wasn't patched anymore to read a global
 configuration file.

 One can argue there never really was any reason to patch the program as
 a default location is displayed if no parameter is passed or if no user
 configuration file is found.

 See PR pkg/52026 for more details.


 To generate a diff of this commit:
 cvs rdiff -u -r1.17 -r1.18 pkgsrc/misc/ansiweather/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 21 Jun 2022 05:03:45 +0000
State-Changed-Why:
fixed, thanks!


>Unformatted:

Home	PR Database Search