NetBSD Problem Report #52177

From www@NetBSD.org  Tue Apr 18 14:49:28 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id F2E9B7A167
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 18 Apr 2017 14:49:27 +0000 (UTC)
Message-Id: <20170418144926.D0F537A2B0@mollari.NetBSD.org>
Date: Tue, 18 Apr 2017 14:49:26 +0000 (UTC)
From: amd@pd-house.info
Reply-To: amd@pd-house.info
To: gnats-bugs@NetBSD.org
Subject: stream feature for nginx
X-Send-Pr-Version: www-1.0

>Number:         52177
>Category:       pkg
>Synopsis:       stream feature for nginx
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    osa
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 18 14:50:00 +0000 2017
>Closed-Date:    Mon Apr 24 17:03:35 +0000 2023
>Last-Modified:  Mon Apr 24 17:03:35 +0000 2023
>Originator:     Anders Mundt Due
>Release:        pkgsrc current (as of 2017-04-18)
>Organization:
>Environment:
NetBSD netb71-64.pd-house.dk 7.1 NetBSD 7.1 (GENERIC.201703111743Z) amd64
>Description:
nginx stable and development versions both have a stream module but it's missing from options.mk so it can't be compiled in
>How-To-Repeat:
try to add stream to PKG_OPTIONS.nginx in your mk.conf..
>Fix:
diff www/nginx/options.mk www/nginx/options.mk
index b7e702485a1..4459cd8f2db 100644
--- www/nginx/options.mk
+++ www/nginx/options.mk
@@ -5,7 +5,7 @@ PKG_SUPPORTED_OPTIONS=          dav flv gtools inet6 luajit mail-proxy memcache naxsi \
                                pcre push realip ssl sub uwsgi image-filter \
                                debug status nginx-autodetect-cflags echo \
                                set-misc headers-more array-var encrypted-session \
-                               form-input perl gzip http2
+                               form-input perl gzip http2 stream
 PKG_OPTIONS_LEGACY_OPTS+=      v2:http2

 PKG_SUGGESTED_OPTIONS= inet6 pcre ssl
@@ -24,10 +24,17 @@ CONFIGURE_ARGS+=    --add-module=../${NAXSI_DISTNAME}/naxsi_src
 CONFIGURE_ARGS+=       --with-debug
 .endif

+.if !empty(PKG_OPTIONS:Mstream)
+CONFIGURE_ARGS+=       --with-stream
+.endif
+
 .if !empty(PKG_OPTIONS:Mssl)
 .include "../../security/openssl/buildlink3.mk"
 CONFIGURE_ARGS+=       --with-mail_ssl_module
 CONFIGURE_ARGS+=       --with-http_ssl_module
+.if !empty(PKG_OPTIONS:Mstream)
+CONFIGURE_ARGS+=       --with-stream_ssl_module
+.endif
 .endif

 .if !empty(PKG_OPTIONS:Mpcre)

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->joerg
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Tue, 18 Apr 2017 18:50:56 +0000
Responsible-Changed-Why:
Over to maintainer.


From: Anders Mundt Due <amd@pd-house.info>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/52177 (stream feature for nginx)
Date: Tue, 1 Aug 2017 20:40:49 +0200

 --001a113f327cb416e90555b57dd6
 Content-Type: text/plain; charset="UTF-8"

 Updated the patch to patch the latest options.mk file.. Also switched to
 CVS instead of git so it's an easier read.

 Index: options.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/www/nginx/options.mk,v
 retrieving revision 1.41
 diff -u -r1.41 options.mk
 --- options.mk  23 Jul 2017 21:08:18 -0000      1.41
 +++ options.mk  1 Aug 2017 18:40:29 -0000
 @@ -5,7 +5,7 @@
                                 pcre push realip ssl sub uwsgi image-filter
 \
                                 debug status nginx-autodetect-cflags echo \
                                 set-misc headers-more array-var
 encrypted-session \
 -                               form-input perl gzip http2 auth-request rtmp
 +                               form-input perl gzip http2 auth-request
 rtmp stream
  PKG_OPTIONS_LEGACY_OPTS+=      v2:http2

  PKG_SUGGESTED_OPTIONS= inet6 pcre ssl
 @@ -31,10 +31,17 @@
  CONFIGURE_ARGS+=       --with-debug
  .endif

 +.if !empty(PKG_OPTIONS:Mstream)
 +CONFIGURE_ARGS+=        --with-stream
 +.endif
 +
  .if !empty(PKG_OPTIONS:Mssl)
  .include "../../security/openssl/buildlink3.mk"
  CONFIGURE_ARGS+=       --with-mail_ssl_module
  CONFIGURE_ARGS+=       --with-http_ssl_module
 +.if !empty(PKG_OPTIONS:Mstream)
 +CONFIGURE_ARGS+=        --with-stream_ssl_module
 +.endif
  .endif

  .if !empty(PKG_OPTIONS:Mpcre)


 On Tue, Apr 18, 2017 at 8:50 PM, <hauke@netbsd.org> wrote:

 > Synopsis: stream feature for nginx
 >
 > Responsible-Changed-From-To: pkg-manager->joerg
 > Responsible-Changed-By: hauke@NetBSD.org
 > Responsible-Changed-When: Tue, 18 Apr 2017 18:50:56 +0000
 > Responsible-Changed-Why:
 > Over to maintainer.
 >
 >
 >
 >

 --001a113f327cb416e90555b57dd6
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr">Updated the patch to patch the latest <a href=3D"http://op=
 tions.mk">options.mk</a> file.. Also switched to CVS instead of git so it&#=
 39;s an easier read.<div><br></div><div><div>Index: <a href=3D"http://optio=
 ns.mk">options.mk</a></div><div>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D</div><div>RCS file: /cvsroot/pkgsrc/www/nginx/<a href=3D"http://o=
 ptions.mk">options.mk</a>,v</div><div>retrieving revision 1.41</div><div>di=
 ff -u -r1.41 <a href=3D"http://options.mk">options.mk</a></div><div>--- <a =
 href=3D"http://options.mk">options.mk</a> =C2=A023 Jul 2017 21:08:18 -0000 =
 =C2=A0 =C2=A0 =C2=A01.41</div><div>+++ <a href=3D"http://options.mk">option=
 s.mk</a> =C2=A01 Aug 2017 18:40:29 -0000</div><div>@@ -5,7 +5,7 @@</div><di=
 v>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
 =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pcre push realip ssl sub uwsgi image=
 -filter \</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
  =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 debug status nginx=
 -autodetect-cflags echo \</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
 =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 s=
 et-misc headers-more array-var encrypted-session \</div><div>- =C2=A0 =C2=
 =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
 =C2=A0 =C2=A0 =C2=A0 form-input perl gzip http2 auth-request rtmp</div><div=
 >+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 form-input perl gzip http2 auth-request =
 rtmp stream</div><div>=C2=A0PKG_OPTIONS_LEGACY_OPTS+=3D =C2=A0 =C2=A0 =C2=
 =A0v2:http2</div><div>=C2=A0</div><div>=C2=A0PKG_SUGGESTED_OPTIONS=3D inet6=
  pcre ssl</div><div>@@ -31,10 +31,17 @@</div><div>=C2=A0CONFIGURE_ARGS+=3D =
 =C2=A0 =C2=A0 =C2=A0 --with-debug</div><div>=C2=A0.endif</div><div>=C2=A0</=
 div><div>+.if !empty(PKG_OPTIONS:Mstream)</div><div>+CONFIGURE_ARGS+=3D =C2=
 =A0 =C2=A0 =C2=A0 =C2=A0--with-stream</div><div>+.endif</div><div>+</div><d=
 iv>=C2=A0.if !empty(PKG_OPTIONS:Mssl)</div><div>=C2=A0.include &quot;../../=
 security/openssl/<a href=3D"http://buildlink3.mk">buildlink3.mk</a>&quot;</=
 div><div>=C2=A0CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-mail_ssl_modu=
 le</div><div>=C2=A0CONFIGURE_ARGS+=3D =C2=A0 =C2=A0 =C2=A0 --with-http_ssl_=
 module</div><div>+.if !empty(PKG_OPTIONS:Mstream)</div><div>+CONFIGURE_ARGS=
 +=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-stream_ssl_module</div><div>+.endif<=
 /div><div>=C2=A0.endif</div><div>=C2=A0</div><div>=C2=A0.if !empty(PKG_OPTI=
 ONS:Mpcre)</div></div><div><br></div></div><div class=3D"gmail_extra"><br><=
 div class=3D"gmail_quote">On Tue, Apr 18, 2017 at 8:50 PM,  <span dir=3D"lt=
 r">&lt;<a href=3D"mailto:hauke@netbsd.org" target=3D"_blank">hauke@netbsd.o=
 rg</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"marg=
 in:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Synopsis: stream=
  feature for nginx<br>
 <br>
 Responsible-Changed-From-To: pkg-manager-&gt;joerg<br>
 Responsible-Changed-By: hauke@NetBSD.org<br>
 Responsible-Changed-When: Tue, 18 Apr 2017 18:50:56 +0000<br>
 Responsible-Changed-Why:<br>
 Over to maintainer.<br>
 <br>
 <br>
 <br>
 </blockquote></div><br></div>

 --001a113f327cb416e90555b57dd6--

From: Anders Mundt Due <amd@pd-house.info>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/52177 (stream feature for nginx)
Date: Tue, 1 Aug 2017 20:51:01 +0200

 Sorry about the ugly html blurb :-(

 /Anders

Responsible-Changed-From-To: joerg->osa
Responsible-Changed-By: osa@NetBSD.org
Responsible-Changed-When: Mon, 24 Apr 2023 17:02:56 +0000
Responsible-Changed-Why:
I'll take it.


State-Changed-From-To: open->closed
State-Changed-By: osa@NetBSD.org
State-Changed-When: Mon, 24 Apr 2023 17:03:35 +0000
State-Changed-Why:
The stream module was added to the www/nginx* packages.
Thanks for the report!


>Unformatted:

Home	PR Database Search