NetBSD Problem Report #52205

From www@NetBSD.org  Sun Apr 30 20:01:39 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id DF8427A219
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 30 Apr 2017 20:01:38 +0000 (UTC)
Message-Id: <20170430200138.057467A2BB@mollari.NetBSD.org>
Date: Sun, 30 Apr 2017 20:01:38 +0000 (UTC)
From: miod@online.fr
Reply-To: miod@online.fr
To: gnats-bugs@NetBSD.org
Subject: Wrong locator on zsc at intio line in dmesg
X-Send-Pr-Version: www-1.0

>Number:         52205
>Category:       port-next68k
>Synopsis:       Wrong locator on zsc at intio line in dmesg
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-next68k-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 30 20:05:00 +0000 2017
>Closed-Date:    Thu May 11 15:25:39 +0000 2017
>Last-Modified:  Thu May 11 15:25:39 +0000 2017
>Originator:     Miod Vallat
>Release:        7.1
>Organization:
>Environment:
>Description:
Devices attaching to intio(4) are responsible for updating the ia_addr field of their attach args, in order for intioprint to print it.

However, sys/arch/next68k/dev/zsc.c sets ia_addr to the virtual address where the registers are mapped, instead of the physical address.

This causes inconsistency in dmesg:
...
intio0 at mainbus0
esp0 at intio0 addr 0x2114000
zsc0 at intio0 addr 0x3fa000
...
nextdma0 at intio0 addr 0x2000010: channel 0 (scsi)
nextdma1 at intio0 addr 0x2000110: channel 1 (enetx)
nextdma2 at intio0 addr 0x2000150: channel 2 (enetr)
xe0 at intio0 addr 0x2106000
...

and the address will change from one kernel to another.
>How-To-Repeat:
Boot NetBSD/next68k.
>Fix:
In sys/arch/next68k/dev/zs.c zs_match(), set ia_addr to NEXT_P_SCC rather than IIOV(NEXT_P_SCC).

>Release-Note:

>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52205 CVS commit: src/sys/arch/next68k/dev
Date: Mon, 1 May 2017 10:25:48 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon May  1 10:25:47 UTC 2017

 Modified Files:
 	src/sys/arch/next68k/dev: zs.c

 Log Message:
 PR port-next68k/52205 from Miod Vallat: cosmetic change to print the
 physical address when attaching zs devices.
 For the real work, zs_get_chan_addr() will still use the virtual address.


 To generate a diff of this commit:
 cvs rdiff -u -r1.33 -r1.34 src/sys/arch/next68k/dev/zs.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: martin@NetBSD.org
State-Changed-When: Mon, 01 May 2017 10:33:24 +0000
State-Changed-Why:
Fixed in -current and we are reluctant to pull this kind of changes up to
release branches.
Could you test a -current kernel from one of the upcoming auto-builds?



From: Miod Vallat <miod@online.fr>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: port-next68k/52205 (Wrong locator on zsc at intio line in dmesg)
Date: Thu, 11 May 2017 15:17:44 +0000

 > Synopsis: Wrong locator on zsc at intio line in dmesg
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: martin@NetBSD.org
 > State-Changed-When: Mon, 01 May 2017 10:33:24 +0000
 > State-Changed-Why:
 > Fixed in -current and we are reluctant to pull this kind of changes up to
 > release branches.
 > Could you test a -current kernel from one of the upcoming auto-builds?

 This is indeed fixed in 201705091910Z. Thanks!

State-Changed-From-To: feedback->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Thu, 11 May 2017 15:25:39 +0000
State-Changed-Why:
Confirmed fixed, thanks for the report!


>Unformatted:

Home	PR Database Search