NetBSD Problem Report #52290

From mlelstv@hoppa.1st.de  Sun Jun 11 12:27:29 2017
Return-Path: <mlelstv@hoppa.1st.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9F5057A176
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 11 Jun 2017 12:27:29 +0000 (UTC)
Message-Id: <20170611122654.E66C5A9@hoppa.1st.de>
Date: Sun, 11 Jun 2017 14:26:54 +0200 (CEST)
From: mlelstv@serpens.de
Reply-To: mlelstv@serpens.de
To: gnats-bugs@NetBSD.org
Subject: npf panic with tables
X-Send-Pr-Version: 3.95

>Number:         52290
>Category:       kern
>Synopsis:       npf panic with tables
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 11 12:30:00 +0000 2017
>Closed-Date:    Sun Dec 10 00:21:19 +0000 2017
>Last-Modified:  Sun Dec 10 00:21:19 +0000 2017
>Originator:     Michael van Elst
>Release:        NetBSD 7.99.73
>Organization:

>Environment:


System: NetBSD cosmicbunny 7.99.73 NetBSD 7.99.73 (COSMICBUNNY) #39: Tue May 30 01:32:25 CEST 2017 mlelstv@gossam:/home/netbsd-current/obj.evbmips64-eb/home/netbsd-current/src/sys/arch/evbmips/compile/COSMICBUNNY evbmips
Architecture: mips64eb
Machine: evbmips
>Description:

In npf_cop_table the asssertion:

        KASSERT(npf_iscached(npc, NPC_IP46)); 

fails for

table <badboys> type tree file "/etc/npf.badboys.tbl"

group "external" on $ext_if {
        block in final from <badboys> apply "log"
        block out final to <badboys> apply "log"

	...
}


Backtrace is:

0xffffffff80039930: cpu_Debugger+4 (63061,fc00,8,ffffffff806195e0) ra ffffffff804434d8 sz 0 
0xffffffff80039930: vpanic+158 (63061,fc00,8,ffffffff806195e0) ra ffffffff80528858 sz 64
0xffffffff80039970: kern_assert+48 (63061,ffffffff80554d30,ffffffff8056d4e0,ffffffff8056d4b0) ra ffffffff803010a0 sz 96 
0xffffffff800399d0: npf_cop_table+e0 (63061,ffffffff80554d30,ffffffff8056d4e0,ffffffff8056d4b0) ra ffffffff804c97fc sz 48 
0xffffffff80039a00: bpf_filter_ext+454 (63061,ffffffff80554d30,ffffffff8056d4e0, ffffffff8056d4b0) ra 0 sz 0
User-level: pid 0.3

panic: kernel diagnostic assertion "npf_iscached(npc, NPC_IP46)" failed:
file "/home/netbsd-current/src/sys/net/npf/npf_bpf.c", line 185 
kernel: breakpoint trap



>How-To-Repeat:

>Fix:


>Release-Note:

>Audit-Trail:
From: "Mindaugas Rasiukevicius" <rmind@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52290 CVS commit: src/sys/net/npf
Date: Sun, 10 Dec 2017 00:07:36 +0000

 Module Name:	src
 Committed By:	rmind
 Date:		Sun Dec 10 00:07:36 UTC 2017

 Modified Files:
 	src/sys/net/npf: npf_alg_icmp.c npf_bpf.c npf_conn.c npf_conn.h
 	    npf_ext_normalize.c

 Log Message:
 - npf_cop_table: handle non-IP packets in the ether (fixes PR/52290).
 - npfa_icmp_nat: do not recompute the checksum if no port translation.
 - npf_normalize (MSS clamping): fix the checksum handling on PFIL_OUT.
 - npflog: report the packet direction correctly.


 To generate a diff of this commit:
 cvs rdiff -u -r1.24 -r1.25 src/sys/net/npf/npf_alg_icmp.c
 cvs rdiff -u -r1.12 -r1.13 src/sys/net/npf/npf_bpf.c \
     src/sys/net/npf/npf_conn.h
 cvs rdiff -u -r1.23 -r1.24 src/sys/net/npf/npf_conn.c
 cvs rdiff -u -r1.5 -r1.6 src/sys/net/npf/npf_ext_normalize.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: rmind@NetBSD.org
State-Changed-When: Sun, 10 Dec 2017 00:21:19 +0000
State-Changed-Why:
Fixed, thanks.


>Unformatted:

Home	PR Database Search