NetBSD Problem Report #52292

From clare@csel.org  Sun Jun 11 21:50:13 2017
Return-Path: <clare@csel.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 556EC7A175
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 11 Jun 2017 21:50:13 +0000 (UTC)
Message-Id: <20170611214919.2A34650044@kanako.csel.org>
Date: Mon, 12 Jun 2017 06:49:19 +0900 (JST)
From: Shinichi Doyashiki <clare@csel.org>
Reply-To: clare@csel.org
To: gnats-bugs@NetBSD.org
Subject: racoon may have an ancient typo in comments
X-Send-Pr-Version: 3.95

>Number:         52292
>Category:       bin
>Synopsis:       racoon may have an ancient typo in comments
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 11 21:55:00 +0000 2017
>Closed-Date:    Thu May 31 07:20:33 +0000 2018
>Last-Modified:  Thu May 31 07:20:33 +0000 2018
>Originator:     Shinichi Doyashiki
>Release:        NetBSD 7.99.75
>Organization:
	at home
>Environment:
System: NetBSD kanako.csel.org 7.99.75 NetBSD 7.99.75 (KANAKO) #6: Sat Jun 3 23:40:16 JST 2017 clare@kanako.csel.org:/export/stage/hack/sys/arch/amd64/compile/KANAKO amd64
Architecture: x86_64
Machine: amd64
>Description:
	racoon may have an ancient typo in comments.
>How-To-Repeat:
	see the source around following patch.
>Fix:
cvs diff: Diffing .
Index: crypto_openssl.c
===================================================================
RCS file: /export/cvsroot/netbsd/src/crypto/dist/ipsec-tools/src/racoon/crypto_openssl.c,v
retrieving revision 1.25
diff -u -r1.25 crypto_openssl.c
--- crypto_openssl.c	27 Feb 2014 08:37:58 -0000	1.25
+++ crypto_openssl.c	11 Jun 2017 21:41:40 -0000
@@ -1268,7 +1268,7 @@
 	if ((res = vmalloc(data->l)) == NULL)
 		return NULL;

-	/* decryption data */
+	/* encrypt data */
 	idea_cbc_encrypt((unsigned char *)data->v, (unsigned char *)res->v, data->l,
 			&ks, (unsigned char *)iv->v, IDEA_ENCRYPT);

@@ -1366,7 +1366,7 @@
 	if ((res = vmalloc(data->l)) == NULL)
 		return NULL;

-	/* decryption data */
+	/* encrypt data */
 	RC5_32_cbc_encrypt((unsigned char *)data->v, (unsigned char *)res->v, data->l,
 		&ks, (unsigned char *)iv->v, RC5_ENCRYPT);


>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52292 CVS commit: src/crypto/dist/ipsec-tools/src/racoon
Date: Sun, 11 Jun 2017 18:12:56 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sun Jun 11 22:12:56 UTC 2017

 Modified Files:
 	src/crypto/dist/ipsec-tools/src/racoon: crypto_openssl.c

 Log Message:
 PR/52292: Shinichi Doyashiki: Fix reversed comments.


 To generate a diff of this commit:
 cvs rdiff -u -r1.25 -r1.26 \
     src/crypto/dist/ipsec-tools/src/racoon/crypto_openssl.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maxv@NetBSD.org
State-Changed-When: Thu, 31 May 2018 07:20:33 +0000
State-Changed-Why:
Fixed.


>Unformatted:

Home	PR Database Search