NetBSD Problem Report #52535

From www@NetBSD.org  Sat Sep  9 22:31:49 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 764427A200
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  9 Sep 2017 22:31:49 +0000 (UTC)
Message-Id: <20170909223148.51F717A27B@mollari.NetBSD.org>
Date: Sat,  9 Sep 2017 22:31:48 +0000 (UTC)
From: coypu@sdf.org
Reply-To: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Subject: firefox is crashy and it's gtk3's fault (broken icon theme)
X-Send-Pr-Version: www-1.0

>Number:         52535
>Category:       pkg
>Synopsis:       firefox is crashy and it's gtk3's fault (broken icon theme)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 09 22:35:00 +0000 2017
>Closed-Date:    Fri Nov 03 20:14:39 +0000 2017
>Last-Modified:  Fri Nov 03 20:15:01 +0000 2017
>Originator:     coypu
>Release:        NetBSD 8.0_BETA
>Organization:
>Environment:
NetBSD localhost 8.0_BETA NetBSD 8.0_BETA (GENERIC.201709060310Z) amd64

>Description:
Firefox crashes a lot for me so I ran it in gdb and got this backtrace.
I got it from trying to save a file in my home directory in firefox.

Thread 1 received signal SIGSEGV, Segmentation fault.
0x0000000058a0536c in mozalloc_abort(char const*) ()
(gdb) bt
#0  0x0000000058a0536c in mozalloc_abort(char const*) ()
#1  0x0000000058a05336 in abort ()
#2  0x00007aca8826752e in g_assertion_message () from /usr/pkg/lib/libglib-2.0.so.0
#3  0x00007aca882675ac in g_assertion_message_expr () from /usr/pkg/lib/libglib-2.0.so.0
#4  0x00007aca933d6ff9 in ensure_surface_for_gicon () from /usr/pkg/lib/libgtk-3.so.0
#5  0x00007aca933d7654 in gtk_icon_helper_load_surface () from /usr/pkg/lib/libgtk-3.so.0
#6  0x00007aca933d771c in gtk_icon_helper_ensure_surface.part () from /usr/pkg/lib/libgtk-3.so.0
#7  0x00007aca933d78ce in _gtk_icon_helper_get_size () from /usr/pkg/lib/libgtk-3.so.0
#8  0x00007aca933e94d0 in gtk_image_get_content_size () from /usr/pkg/lib/libgtk-3.so.0
#9  0x00007aca9335c3f7 in gtk_css_custom_gadget_get_preferred_size () from /usr/pkg/lib/libgtk-3.so.0

...
literally 140 frames in total

Looking at gtk, it has only one assert in the function:
  if (destination == NULL)
    {
      destination = gtk_icon_theme_load_icon (icon_theme,
                                              "image-missing",
                                              width,
                                              flags | GTK_ICON_LOOKUP_USE_BUILTIN | GTK_ICON_LOOKUP_GENERIC_FALLBACK,
                                              NULL);
      /* We include this image as resource, so we always have it available or
       * the icontheme code is broken */
      g_assert (destination);
      symbolic = FALSE;


I must be missing the icon "image-missing" so it asserts. not sure how it happened, but it probably shouldn't.
>How-To-Repeat:

>Fix:
??? gtk3

>Release-Note:

>Audit-Trail:
From: Patrick Welche <prlw1@cam.ac.uk>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/52535: firefox is crashy and it's gtk3's fault (broken icon
 theme)
Date: Sat, 9 Sep 2017 23:50:36 +0100

 > I must be missing the icon "image-missing" so it asserts. not sure how it happened, but it probably shouldn't.

 I see:

 $ find /usr/pkg/share/icons -name image-missing\*
 /usr/pkg/share/icons/gnome/16x16/status/image-missing.png
 /usr/pkg/share/icons/gnome/22x22/status/image-missing.png
 /usr/pkg/share/icons/gnome/24x24/status/image-missing.png
 /usr/pkg/share/icons/gnome/256x256/status/image-missing.png
 /usr/pkg/share/icons/gnome/32x32/status/image-missing.png
 /usr/pkg/share/icons/gnome/48x48/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/16x16/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/22x22/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/24x24/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/32x32/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/48x48/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/512x512/status/image-missing.png

 which means that at least gnome-icon-theme and adwaita-icon-theme
 are installed on my box, and "gtk3-icon-browser" (which has a
 search box) finds it.

From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc: prlw1@cam.ac.uk
Subject: Re: pkg/52535: firefox is crashy and it's gtk3's fault (broken icon
 theme)
Date: Sat, 9 Sep 2017 23:09:16 +0000

 I have only these, and nothing gtk3-related besides firefox.

 $ find /usr/pkg |grep image-missing
 /usr/pkg/share/gtk-doc/html/gtk2/image-missing.png
 /usr/pkg/share/icons/Adwaita/16x16/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/22x22/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/24x24/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/32x32/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/48x48/status/image-missing.png
 /usr/pkg/share/icons/Adwaita/512x512/status/image-missing.png


 >  which means that at least gnome-icon-theme and adwaita-icon-theme
 >  are installed on my box, and "gtk3-icon-browser" (which has a
 >  search box) finds it.

 It dumps core the same.

 $ gtk3-icon-browser

 ** (gtk3-icon-browser:7966): WARNING **: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.NoReply: Message recipient disconnected from message bus without replying
 Fontconfig warning: line 148: blank doesn't take any effect anymore. please remove it from your fonts.conf

 (gtk3-icon-browser:7966): Gtk-WARNING **: Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/bullet-symbolic.svg.
 This may indicate that pixbuf loaders or the mime database could not be found.
 **
 Gtk:ERROR:gtkiconhelper.c:493:ensure_surface_for_gicon: assertion failed: (destination)
 [1]   Abort trap (core dumped) gtk3-icon-browser

 I don't install to /org/gtk - regular /usr/pkg.

From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc: prlw1@cam.ac.uk
Subject: Re: pkg/52535: firefox is crashy and it's gtk3's fault (broken icon
 theme)
Date: Sat, 9 Sep 2017 23:44:24 +0000

 It runs after I run:
 $ sudo /usr/pkg/bin/gdk-pixbuf-query-loaders --update-cache

 so, perhaps this part is somehow missing along the way. my loaders.cache
 was empty.

From: Patrick Welche <prlw1@cam.ac.uk>
To: coypu@sdf.org
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/52535: firefox is crashy and it's gtk3's fault (broken icon
 theme)
Date: Sun, 10 Sep 2017 08:47:44 +0100

 On Sat, Sep 09, 2017 at 11:44:24PM +0000, coypu@sdf.org wrote:
 > It runs after I run:
 > $ sudo /usr/pkg/bin/gdk-pixbuf-query-loaders --update-cache
 > 
 > so, perhaps this part is somehow missing along the way. my loaders.cache
 > was empty.

 Problem in graphics/gdk-pixbuf2/files/loaders.tmpl ?

From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/52535: firefox is crashy and it's gtk3's fault (broken icon
 theme)
Date: Sun, 10 Sep 2017 23:08:36 +0000

 seems like loaders.cache is special and maybe handled by loaders.mk
 I had just copied all my packages to a laptop and did pkg_add *.

 Not sure, will have to dig more later.

State-Changed-From-To: open->feedback
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Fri, 03 Nov 2017 19:57:47 +0000
State-Changed-Why:
What do we do with this PR? Did you do any more digging?
Is it a local issue? Is it an issue with gdk-pixbuf somehow?


State-Changed-From-To: feedback->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Fri, 03 Nov 2017 20:14:39 +0000
State-Changed-Why:
Assuming local issue, will bring it up as a suggestion if anyone complains of firefox being crashy in the future.


From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/52535 (firefox is crashy and it's gtk3's fault (broken icon
 theme))
Date: Fri, 3 Nov 2017 20:11:44 +0000

 I'm not sure, if all binary packages resulted in this behaviour then
 we'd probably hear other people's complaints. so maybe it's a local
 issue.

 Something to keep in mind, and close it?

>Unformatted:

Home	PR Database Search