NetBSD Problem Report #52618

From root@csel.org  Sat Oct 14 17:20:05 2017
Return-Path: <root@csel.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id C290E7A2A6
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 14 Oct 2017 17:20:04 +0000 (UTC)
Message-Id: <20171014172000.CD6D53F83C@inner.csel.org>
Date: Sun, 15 Oct 2017 02:20:00 +0900 (JST)
From: clare@csel.org
Reply-To: clare@csel.org
To: gnats-bugs@NetBSD.org
Subject: rtadvd fails when empty vlan interface exists
X-Send-Pr-Version: 3.95

>Number:         52618
>Category:       bin
>Synopsis:       rtadvd fails when empty vlan interface exists
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 14 17:25:00 +0000 2017
>Closed-Date:    Wed Apr 11 20:19:13 +0000 2018
>Last-Modified:  Wed Apr 11 20:20:00 +0000 2018
>Originator:     Shinichi Doyashiki
>Release:        NetBSD 8.99.1
>Organization:
	at home
>Environment:
System: NetBSD inner.csel.org 8.99.1 NetBSD 8.99.1 (APU1C) #6: Sun Jul 9 20:25:50 JST 2017 clare@kanako.csel.org:/export/stage/hack/sys/arch/amd64/compile/APU1C amd64
Architecture: x86_64
Machine: amd64
>Description:
	rtadvd failes when empty vlan interface exists
>How-To-Repeat:
	1. configure empty vlan interface
	# touch /etc/ifconfig.vlan2
	2. configure rtadvd with empty interface, and start
	# vi /etc/rc.conf
	# grep rtadvd /etc/rc.conf
	rtadvd=YES; rtadvd_flags="re1 vlan2 vlan3 vlan10 vlan11"
	# reboot
	3. watch /var/log/messages
	Oct 15 02:07:55 inner rtadvd[972]: <sock_open> IPV6_JOIN_GROUP(link) on vlan2: Invalid argument
>Fix:
	workaround: keep interface(s) always configured condition.

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52618 CVS commit: src/usr.sbin/rtadvd
Date: Sat, 14 Oct 2017 15:16:27 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sat Oct 14 19:16:26 UTC 2017

 Modified Files:
 	src/usr.sbin/rtadvd: rtadvd.c

 Log Message:
 PR/52618: Shinichi Doyashiki: Don't exit if adding interface to multicast
 group fails. This happens with empty vlan interfaces

 - make syscalls checks against -1
 - fix errors to print %s: instead of <%s>

 XXX: if_vlan is the only pseudo interface in net/ that returns such an
 error..


 To generate a diff of this commit:
 cvs rdiff -u -r1.55 -r1.56 src/usr.sbin/rtadvd/rtadvd.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52618 CVS commit: [netbsd-8] src
Date: Tue, 21 Nov 2017 10:54:19 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Nov 21 10:54:19 UTC 2017

 Modified Files:
 	src/tests/net/ndp [netbsd-8]: t_ra.sh
 	src/usr.sbin/rtadvd [netbsd-8]: advcap.c config.c dump.c if.c rrenum.c
 	    rtadvd.8 rtadvd.c timer.c
 Added Files:
 	src/usr.sbin/rtadvd [netbsd-8]: logit.h

 Log Message:
 Pull up following revision(s) (requested by ozaki-r in ticket #358):
 	usr.sbin/rtadvd/rtadvd.c: revision 1.54-1.58
 	usr.sbin/rtadvd/config.c: revision 1.37
 	usr.sbin/rtadvd/if.c: revision 1.25
 	usr.sbin/rtadvd/dump.c: revision 1.15
 	usr.sbin/rtadvd/rrenum.c: revision 1.20
 	usr.sbin/rtadvd/logit.h: revision 1.1
 	usr.sbin/rtadvd/rtadvd.8: revision 1.26
 	tests/net/ndp/t_ra.sh: revision 1.30
 	usr.sbin/rtadvd/timer.c: revision 1.14
 	tests/net/ndp/t_ra.sh: revision 1.31
 	usr.sbin/rtadvd/advcap.c: revision 1.17

 KNF, fix time printing formats.

 Don't start another copy of rtadvd if one is running.

 PR/52618: Shinichi Doyashiki: Don't exit if adding interface to multicast
 group fails. This happens with empty vlan interfaces
 - make syscalls checks against -1
 - fix errors to print %s: instead of <%s>
 XXX: if_vlan is the only pseudo interface in net/ that returns such an
 error..

 Kill rtadvd surely even if the tests fail in the middle
 It may help PR bin/52701.

 Change the meaning of the D flag to print errors to stderr instead of
 syslog(3) and exit if poll(2) fails (intended to be used with unit-tests).

 Mark expandm as preserving format strings.

 Let rtadvd not use syslog for logging
 Thanks to christos@ now rtadvd can log via stderr instead of syslog
 by -D option.
 Address PR bin/52701


 To generate a diff of this commit:
 cvs rdiff -u -r1.27.2.1 -r1.27.2.2 src/tests/net/ndp/t_ra.sh
 cvs rdiff -u -r1.16 -r1.16.8.1 src/usr.sbin/rtadvd/advcap.c
 cvs rdiff -u -r1.36 -r1.36.4.1 src/usr.sbin/rtadvd/config.c
 cvs rdiff -u -r1.14 -r1.14.8.1 src/usr.sbin/rtadvd/dump.c
 cvs rdiff -u -r1.24 -r1.24.8.1 src/usr.sbin/rtadvd/if.c
 cvs rdiff -u -r0 -r1.1.2.2 src/usr.sbin/rtadvd/logit.h
 cvs rdiff -u -r1.19 -r1.19.8.1 src/usr.sbin/rtadvd/rrenum.c
 cvs rdiff -u -r1.25 -r1.25.6.1 src/usr.sbin/rtadvd/rtadvd.8
 cvs rdiff -u -r1.53 -r1.53.4.1 src/usr.sbin/rtadvd/rtadvd.c
 cvs rdiff -u -r1.13 -r1.13.8.1 src/usr.sbin/rtadvd/timer.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: snj@NetBSD.org
State-Changed-When: Wed, 11 Apr 2018 06:07:21 +0000
State-Changed-Why:
Is this fixed to your satisfaction?


State-Changed-From-To: feedback->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Wed, 11 Apr 2018 20:19:13 +0000
State-Changed-Why:
fixed. thanks for the report!


From: clare@csel.org
To: gnats-bugs@NetBSD.org
Cc: snj@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: bin/52618 (rtadvd fails when empty vlan interface exists)
Date: Thu, 12 Apr 2018 05:16:56 +0900

 On Wed, 11 Apr 2018 06:07:21 +0000 (UTC)
 snj@NetBSD.org wrote:

 > Synopsis: rtadvd fails when empty vlan interface exists
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: snj@NetBSD.org
 > State-Changed-When: Wed, 11 Apr 2018 06:07:21 +0000
 > State-Changed-Why:
 > Is this fixed to your satisfaction?

 the rtadvd in 8.0_BETA seems to be worked good for me.

 # ifconfig vlan1 create
 # vi /etc/rc.conf
 # grep vlan /etc/rc.conf
 rtadvd_flags="wm0 vlan1 vlan2 vlan3 vlan10 vlan11 vlan29 vlan30"
 # /etc/rc.d/rtadvd restart
 Stopping rtadvd.
 rtadvd: copying /etc/rtadvd.conf to /var/chroot/rtadvd/etc/rtadvd.conf
 Starting rtadvd.
 # grep rtadvd /var/log/messages
 Apr 12 05:01:07 router rtadvd[8047]: sock_open: IPV6_JOIN_GROUP(link) on vlan1: Invalid argument
 # ps -ax | grep rtadvd
  8047 ?     Ss   0:00.00 /usr/sbin/rtadvd wm0 vlan1 vlan2 vlan3 vlan10 vlan11 vlan29 vlan30
 # ifconfig vlan1 up
 # /etc/rc.d/rtadvd restart
 Stopping rtadvd.
 rtadvd: copying /etc/rtadvd.conf to /var/chroot/rtadvd/etc/rtadvd.conf
 Starting rtadvd.
 # ps -ax | grep rtadvd
 12003 ?     Ss   0:00.00 /usr/sbin/rtadvd wm0 vlan1 vlan2 vlan3 vlan10 vlan11 vlan29 vlan30
 # grep rtadvd /var/log/messages
 Apr 12 05:01:07 router rtadvd[8047]: sock_open: IPV6_JOIN_GROUP(link) on vlan1: Invalid argument
 Apr 12 05:02:01 router rtadvd[8047]: ra_output: sendmsg on vlan1: Can't assign requested address
 Apr 12 05:02:01 router rtadvd[8047]: ra_output: sendmsg on vlan1: Can't assign requested address
 Apr 12 05:02:07 router rtadvd[8047]: ra_output: sendmsg on vlan1: Can't assign requested address
 Apr 12 05:02:07 router rtadvd[12003]: sock_open: IPV6_JOIN_GROUP(link) on vlan1: Invalid argument
 Apr 12 05:02:08 router rtadvd[12003]: ra_output: sendmsg on vlan1: Can't assign requested address
 Apr 12 05:02:24 router rtadvd[12003]: ra_output: sendmsg on vlan1: Can't assign requested address
 Apr 12 05:02:40 router rtadvd[12003]: ra_output: sendmsg on vlan1: Can't assign requested address


 -- 
 Shinichi Doyashiki <clare@csel.org>

>Unformatted:

Home	PR Database Search