NetBSD Problem Report #52631
From martin@duskware.de Fri Oct 20 06:49:07 2017
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 1DDA07A20D
for <gnats-bugs@gnats.NetBSD.org>; Fri, 20 Oct 2017 06:49:07 +0000 (UTC)
Message-Id: <20171020064858.C1D525CC761@emmas.aprisoft.de>
Date: Fri, 20 Oct 2017 08:48:58 +0200 (CEST)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: x11/xfce4-gtk2-engine build fails
X-Send-Pr-Version: 3.95
>Number: 52631
>Category: pkg
>Synopsis: x11/xfce4-gtk2-engine build fails
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Oct 20 06:50:00 +0000 2017
>Closed-Date: Mon Jun 04 02:04:35 +0000 2018
>Last-Modified: Mon Jun 04 02:04:35 +0000 2018
>Originator: Martin Husemann
>Release: NetBSD 8.99.4
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD night-owl.duskware.de 8.99.4 NetBSD 8.99.4 (NIGHT-OWL) #543: Thu Oct 19 10:44:25 CEST 2017 martin@night-owl.duskware.de:/usr/src/sys/arch/amd64/compile/NIGHT-OWL amd64
Architecture: x86_64
Machine: amd64
>Description:
Building x11/xfce4-gtk2-engine in my default user environment breaks:
Making all in gtk-3.0
gmake[2]: Entering directory '/usr/pkgobj/x11/xfce4-gtk2-engine/work/gtk-xfce-engine-3.2.0/gtk-3.0'
Traceback (most recent call last):
File "/usr/pkg/bin/glib-mkenums", line 688, in <module>
Traceback (most recent call last):
File "/usr/pkg/bin/glib-mkenums", line 688, in <module>
process_file(fname)
File "/usr/pkg/bin/glib-mkenums", line 420, in process_file
process_file(fname)
File "/usr/pkg/bin/glib-mkenums", line 420, in process_file
line = curfile.readline()
File "/usr/pkg/lib/python2.7/codecs.py", line 314, in decode
line = curfile.readline()
File "/usr/pkg/lib/python2.7/codecs.py", line 314, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xd6 in position 980: invalid continuation byte
UnicodeDecodeError: 'utf8' codec can't decode byte 0xd6 in position 980: invalid continuation byte
Makefile:737: recipe for target 'xfce_typebuiltin.h' failed
I have all pkgs build from scratch yesterday, no relevant (AFAICT)
settings in /etc/mk.conf. pkg_info -e py\* shows:
python27-2.7.14
py27-expat-2.7.14
py27-setuptools-36.6.0
py27-cElementTree-2.7.14
py27-libxml2-2.9.5
py27-six-1.11.0
py27-argparse-1.4.0
py27-pip-9.0.1
py27-pbr-3.1.1
py27-traceback2-1.4.0
py27-linecache2-1.0.0nb1
py27-unittest2-1.1.0
py27-funcsigs-1.0.2
py27-mock-2.0.0nb1
py27-libxslt-1.1.30
>How-To-Repeat:
try to build the pkg
>Fix:
n/a
>Release-Note:
>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Fri, 20 Oct 2017 09:00:38 +0200
This seems to be a fatal bug in /usr/pkg/bin/glib-mkenums which switched
from a perl version to python recently.
Martin
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Fri, 20 Oct 2017 09:03:23 +0200
On Fri, Oct 20, 2017 at 09:00:38AM +0200, Martin Husemann wrote:
> This seems to be a fatal bug in /usr/pkg/bin/glib-mkenums which switched
> from a perl version to python recently.
... and the python source seems to imply that it expects Python 3, but
pkgsrc installed my version with #!/usr/pkg/bin/python2.7
Martin
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Fri, 20 Oct 2017 09:07:18 +0200
and (drumroll....) there are quite a few source files in gtk-xfce-engine*
with a copyright from Tomas Ögren in ISO8859-1 encoding.
Martin
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Fri, 20 Oct 2017 09:28:03 +0200
On Fri, Oct 20, 2017 at 09:07:18AM +0200, Martin Husemann wrote:
> and (drumroll....) there are quite a few source files in gtk-xfce-engine*
> with a copyright from Tomas Ögren in ISO8859-1 encoding.
It seems to be fixed in newer glib versions:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870310
Martin
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Fri, 20 Oct 2017 11:43:52 +0200
If I understand the gnome/gtk folks correctly, they now insist on all sources
being UTF-8 encoded. The tool has to parse comments (to find instructions).
****** (censored comment)
Martin
From: Patrick Welche <prlw1@cam.ac.uk>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Fri, 20 Oct 2017 11:09:49 +0100
On Fri, Oct 20, 2017 at 07:30:01AM +0000, Martin Husemann wrote:
> The following reply was made to PR pkg/52631; it has been noted by GNATS.
>
> From: Martin Husemann <martin@duskware.de>
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
> Date: Fri, 20 Oct 2017 09:28:03 +0200
>
> On Fri, Oct 20, 2017 at 09:07:18AM +0200, Martin Husemann wrote:
> > and (drumroll....) there are quite a few source files in gtk-xfce-engine*
> > with a copyright from Tomas Ögren in ISO8859-1 encoding.
>
> It seems to be fixed in newer glib versions:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870310
Not in a release, but I see the multiple patches - thanks
From: Martin Husemann <martin@duskware.de>
To: Patrick Welche <prlw1@cam.ac.uk>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Fri, 20 Oct 2017 12:47:15 +0200
On Fri, Oct 20, 2017 at 11:45:36AM +0100, Patrick Welche wrote:
> On Fri, Oct 20, 2017 at 10:10:00AM +0000, Patrick Welche wrote:
> > Not in a release, but I see the multiple patches - thanks
>
> No such luck: those patches are already in 2.54.1 (gnome bug 785113)
>
I think we will have to patch the "broken" source files in xfce4-gtk*-engine.
Martin
From: Patrick Welche <prlw1@cam.ac.uk>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Fri, 20 Oct 2017 13:10:21 +0100
On Fri, Oct 20, 2017 at 10:50:01AM +0000, Martin Husemann wrote:
> I think we will have to patch the "broken" source files in xfce4-gtk*-engine.
I see debian hit this:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870738
with the magic iso8859-1 -> utf8 O umlaut change
From: "Patrick Welche" <prlw1@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/52631 CVS commit: pkgsrc/devel
Date: Sat, 21 Oct 2017 08:57:33 +0000
Module Name: pkgsrc
Committed By: prlw1
Date: Sat Oct 21 08:57:33 UTC 2017
Modified Files:
pkgsrc/devel/glib2: distinfo
pkgsrc/devel/glib2-tools: Makefile
pkgsrc/devel/glib2/patches: patch-gobject_glib-mkenums.in
Log Message:
glib2-tools: Handle source files which are not utf-8
python 3 is strict about file encodings. After glib-mkenums was
translated from perl to python, build failures occur due to e.g.,
ISO-8859-1 characters in authors' names as reported by martin@ in
PR pkg/52631 for xfce4-gtk2-engines, but also causing build failures
for at least libgnome and libgnomeui.
Chritoph Reiter produced an elegant workaround, making use of the
open() function's error decoding "replace" option:
'replace' causes a replacement marker (such as '?') to be inserted
where there is malformed data.
which is applied here.
https://bugzilla.gnome.org/show_bug.cgi?id=785113#c27
To generate a diff of this commit:
cvs rdiff -u -r1.224 -r1.225 pkgsrc/devel/glib2/distinfo
cvs rdiff -u -r1.1 -r1.2 pkgsrc/devel/glib2-tools/Makefile
cvs rdiff -u -r1.1 -r1.2 \
pkgsrc/devel/glib2/patches/patch-gobject_glib-mkenums.in
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: David Shao <davshao@gmail.com>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/52631: x11/xfce4-gtk2-engine build fails
Date: Mon, 29 Jan 2018 00:17:44 -0800
Time to just patch xfce4-gtk2-engine and not to rely on glib-mkenums
being patched upstream.
Do something better than this:
--- x11/xfce4-gtk2-engine.orig/distinfo 2018-01-29 00:03:19.076153000 -0=
800
+++ x11/xfce4-gtk2-engine/distinfo 2018-01-29 00:01:41.363734000 -0800
@@ -4,3 +4,7 @@
RMD160 (gtk-xfce-engine-3.2.0.tar.bz2) =3D
4f49ab683f418af78b0dc2b688bb54c7ed38f16a
SHA512 (gtk-xfce-engine-3.2.0.tar.bz2) =3D
c965e597c1b4aa04f3b474f3c4cea249aa6e753be697d5d3d7a19184adca650fc084f39acbd=
357f53eaf4180d96d5d3499866367e221ae445de4864fc9487012
Size (gtk-xfce-engine-3.2.0.tar.bz2) =3D 376203 bytes
+SHA1 (patch-gtk-2.0_xfce__rc__style.h) =3D
6e7827f74f2de36c34a32e67bf63b5ffec65787b
+SHA1 (patch-gtk-2.0_xfce__style.h) =3D 8b9d4b0f85b304c4544ecf203210b3e6b12=
a4471
+SHA1 (patch-gtk-3.0_xfce__engine.h) =3D 4e83508ba39188711f257061d18eab5f82=
161a99
+SHA1 (patch-gtk-3.0_xfce__style__types.h) =3D
ec95e4da7efb747d4f45be13590e985c8681fd94
diff -Nur -x CVS
x11/xfce4-gtk2-engine.orig/patches/patch-gtk-2.0_xfce__rc__style.h
x11/xfce4-gtk2-engine/patches/patch-gtk-2.0_xfce__rc__style.h
--- x11/xfce4-gtk2-engine.orig/patches/patch-gtk-2.0_xfce__rc__style.h
1969-12-31 16:00:00.000000000 -0800
+++ x11/xfce4-gtk2-engine/patches/patch-gtk-2.0_xfce__rc__style.h
2018-01-29 00:00:36.302123000 -0800
@@ -0,0 +1,20 @@
+$NetBSD$
+
+--- gtk-2.0/xfce_rc_style.h.orig 2015-02-28 12:54:43.000000000 +0000
++++ gtk-2.0/xfce_rc_style.h
+@@ -18,13 +18,13 @@
+ *
+ * Portions based Thinice port by
+ * Tim Gerla <timg@rrv.net>,
+- * Tomas =C3=96gren <stric@ing.umu.se,
++ * Tomas ??gren <stric@ing.umu.se,
+ * Richard Hult <rhult@codefactory.se>
+ * Portions based on Smooth theme by
+ * Andrew Johnson <ajgenius@ajgenius.us>
+ * Portions based on IceGradient theme by
+ * Tim Gerla <timg@means.net>
+- * Tomas =C3=83=E2=80=93gren <stric@ing.umu.se>
++ * Tomas ??gren <stric@ing.umu.se>
+ * JM Perez <jose.perez@upcnet.es>
+ * Portions based on Wonderland theme by
+ * Garrett LeSage
diff -Nur -x CVS
x11/xfce4-gtk2-engine.orig/patches/patch-gtk-2.0_xfce__style.h
x11/xfce4-gtk2-engine/patches/patch-gtk-2.0_xfce__style.h
--- x11/xfce4-gtk2-engine.orig/patches/patch-gtk-2.0_xfce__style.h
1969-12-31 16:00:00.000000000 -0800
+++ x11/xfce4-gtk2-engine/patches/patch-gtk-2.0_xfce__style.h
2018-01-29 00:00:36.312124000 -0800
@@ -0,0 +1,20 @@
+$NetBSD$
+
+--- gtk-2.0/xfce_style.h.orig 2015-02-28 12:54:43.000000000 +0000
++++ gtk-2.0/xfce_style.h
+@@ -18,13 +18,13 @@
+ *
+ * Portions based Thinice port by
+ * Tim Gerla <timg@rrv.net>,
+- * Tomas =C3=96gren <stric@ing.umu.se,
++ * Tomas ??gren <stric@ing.umu.se,
+ * Richard Hult <rhult@codefactory.se>
+ * Portions based on Smooth theme by
+ * Andrew Johnson <ajgenius@ajgenius.us>
+ * Portions based on IceGradient theme by
+ * Tim Gerla <timg@means.net>
+- * Tomas =C3=83=E2=80=93gren <stric@ing.umu.se>
++ * Tomas ??gren <stric@ing.umu.se>
+ * JM Perez <jose.perez@upcnet.es>
+ * Portions based on Wonderland theme by
+ * Garrett LeSage
diff -Nur -x CVS
x11/xfce4-gtk2-engine.orig/patches/patch-gtk-3.0_xfce__engine.h
x11/xfce4-gtk2-engine/patches/patch-gtk-3.0_xfce__engine.h
--- x11/xfce4-gtk2-engine.orig/patches/patch-gtk-3.0_xfce__engine.h
1969-12-31 16:00:00.000000000 -0800
+++ x11/xfce4-gtk2-engine/patches/patch-gtk-3.0_xfce__engine.h
2018-01-28 23:57:18.717231000 -0800
@@ -0,0 +1,31 @@
+$NetBSD$
+
+ File "/usr/pkg/bin/glib-mkenums", line 710, in <module>
+ process_file(fname)
+ File "/usr/pkg/bin/glib-mkenums", line 442, in process_file
+ line =3D curfile.readline()
+ File "/usr/pkg/lib/python2.7/codecs.py", line 314, in decode
+ (result, consumed) =3D self._buffer_decode(data, self.errors, final)
+ File "/usr/pkg/bin/glib-mkenums", line 94, in replace_and_warn
+ err.object[err.start - 7:err.end + 7]))
+UnicodeDecodeError: 'ascii' codec can't decode byte 0xd6 in position
7: ordinal not in range(128)
+Makefile:743: recipe for target 'xfce_typebuiltin.c' failed
+
+--- gtk-3.0/xfce_engine.h.orig 2015-02-28 12:54:43.000000000 +0000
++++ gtk-3.0/xfce_engine.h
+@@ -19,13 +19,13 @@
+ *
+ * Portions based Thinice port by
+ * Tim Gerla <timg@rrv.net>,
+- * Tomas =C3=96gren <stric@ing.umu.se,
++ * Tomas ??gren <stric@ing.umu.se>
+ * Richard Hult <rhult@codefactory.se>
+ * Portions based on Smooth theme by
+ * Andrew Johnson <ajgenius@ajgenius.us>
+ * Portions based on IceGradient theme by
+ * Tim Gerla <timg@means.net>
+- * Tomas =C3=83=E2=80=93gren <stric@ing.umu.se>
++ * Tomas ??gren <stric@ing.umu.se>
+ * JM Perez <jose.perez@upcnet.es>
+ * Portions based on Wonderland theme by
+ * Garrett LeSage
diff -Nur -x CVS
x11/xfce4-gtk2-engine.orig/patches/patch-gtk-3.0_xfce__style__types.h
x11/xfce4-gtk2-engine/patches/patch-gtk-3.0_xfce__style__types.h
--- x11/xfce4-gtk2-engine.orig/patches/patch-gtk-3.0_xfce__style__types.h
1969-12-31 16:00:00.000000000 -0800
+++ x11/xfce4-gtk2-engine/patches/patch-gtk-3.0_xfce__style__types.h
2018-01-28 23:55:36.744706000 -0800
@@ -0,0 +1,20 @@
+$NetBSD$
+
+--- gtk-3.0/xfce_style_types.h.orig 2015-02-28 12:54:43.000000000 +0000
++++ gtk-3.0/xfce_style_types.h
+@@ -19,13 +19,13 @@
+ *
+ * Portions based Thinice port by
+ * Tim Gerla <timg@rrv.net>,
+- * Tomas =C3=96gren <stric@ing.umu.se,
++ * Tomas ??gren <stric@ing.umu.se,
+ * Richard Hult <rhult@codefactory.se>
+ * Portions based on Smooth theme by
+ * Andrew Johnson <ajgenius@ajgenius.us>
+ * Portions based on IceGradient theme by
+ * Tim Gerla <timg@means.net>
+- * Tomas =C3=83=E2=80=93gren <stric@ing.umu.se>
++ * Tomas ??gren <stric@ing.umu.se>
+ * JM Perez <jose.perez@upcnet.es>
+ * Portions based on Wonderland theme by
+ * Garrett LeSage
State-Changed-From-To: open->closed
State-Changed-By: youri@NetBSD.org
State-Changed-When: Mon, 04 Jun 2018 02:04:35 +0000
State-Changed-Why:
I've deleted this package, it is obsolete.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home