NetBSD Problem Report #52683

From www@NetBSD.org  Tue Oct 31 11:50:58 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D79617A1B9
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 31 Oct 2017 11:50:58 +0000 (UTC)
Message-Id: <20171031115058.089087A210@mollari.NetBSD.org>
Date: Tue, 31 Oct 2017 11:50:58 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/pmax/ibus/sii.c:342: 2 * redundant assignment 
X-Send-Pr-Version: www-1.0

>Number:         52683
>Category:       port-pmax
>Synopsis:       src/sys/arch/pmax/ibus/sii.c:342: 2 * redundant assignment
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-pmax-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 31 11:55:00 +0000 2017
>Closed-Date:    Tue Oct 31 13:40:53 +0000 2017
>Last-Modified:  Tue Oct 31 15:10:01 +0000 2017
>Originator:     David Binderman
>Release:        cvs-20171031
>Organization:
>Environment:
>Description:
src/sys/arch/pmax/ibus/sii.c:342]: (warning) Redundant assignment of 'regs->cstat' to itself.
> [src/sys/arch/pmax/ibus/sii.c:343]: (warning) Redundant assignment of 'regs->dstat' to itself.


Source code is

    regs->cstat = regs->cstat;
    regs->dstat = regs->dstat;

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: kre@NetBSD.org
State-Changed-When: Tue, 31 Oct 2017 13:40:53 +0000
State-Changed-Why:
Erroneous PR - not a bug


From: Robert Elz <kre@munnari.OZ.AU>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: port-pmax/52683: src/sys/arch/pmax/ibus/sii.c:342: 2 * redundant assignment 
Date: Tue, 31 Oct 2017 20:39:37 +0700

     Date:        Tue, 31 Oct 2017 11:55:00 +0000 (UTC)
     From:        dcb314@hotmail.com
     Message-ID:  <20171031115500.B63C57A214@mollari.NetBSD.org>

   | src/sys/arch/pmax/ibus/sii.c:342]: (warning) Redundant assignment of 'regs->cstat' to itself.
   | > [src/sys/arch/pmax/ibus/sii.c:343]: (warning) Redundant assignment of 'regs->dstat' to itself.
   | 
   | 
   | Source code is
   | 
   |     regs->cstat = regs->cstat;
   |     regs->dstat = regs->dstat;

 Again, these are hardware registers (in a struct declared volatile) and
 assigning this way is an entirely reasonable thing to do.

 If you are going to report "errors" like this, please check first that
 they are not just false positives from whatever tool it is that you are
 using.

 kre

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, port-pmax-maintainer@netbsd.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Cc: 
Subject: Re: port-pmax/52683: src/sys/arch/pmax/ibus/sii.c:342: 2 * redundant assignment
Date: Tue, 31 Oct 2017 11:08:28 -0400

 On Oct 31, 11:55am, dcb314@hotmail.com (dcb314@hotmail.com) wrote:
 -- Subject: port-pmax/52683: src/sys/arch/pmax/ibus/sii.c:342: 2 * redundant 

 These are register assignments, probably necessary.

 christos

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.