NetBSD Problem Report #52708

From www@NetBSD.org  Wed Nov  8 23:36:57 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 437027A183
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  8 Nov 2017 23:36:57 +0000 (UTC)
Message-Id: <20171108233656.7AE817A20D@mollari.NetBSD.org>
Date: Wed,  8 Nov 2017 23:36:56 +0000 (UTC)
From: bapabooiee@gmail.com
Reply-To: bapabooiee@gmail.com
To: gnats-bugs@NetBSD.org
Subject: pkgsrc/doc/pkgsrc.txt: paragraph about *not* generating pkgs for deps is misleading
X-Send-Pr-Version: www-1.0

>Number:         52708
>Category:       pkg
>Synopsis:       pkgsrc/doc/pkgsrc.txt: paragraph about *not* generating pkgs for deps is misleading
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 08 23:40:00 +0000 2017
>Closed-Date:    Tue Sep 18 03:22:44 +0000 2018
>Last-Modified:  Tue Sep 18 03:22:44 +0000 2018
>Originator:     Dean Matzkov
>Release:        HEAD
>Organization:
>Environment:
NetBSD localhost 7.1 NetBSD 7.1 (GENERIC.201703111743Z) amd64
>Description:
The paragraph in question can be found at<https://github.com/NetBSD/pkgsrc/blob/b0108ef500d76d0e86d41f2a4c72c1bed6e716ae/doc/pkgsrc.txt#L1431>, and reads as follows:

-----SNIP-----
  * DEPENDS_TARGET: By default, dependencies are only installed, and no binary
    package is created for them. You can set this variable to package-install
    to automatically create binary packages after installing dependencies.
    Please note that the PKGSRC_KEEP_BIN_PKGS can be set to yes to preserve
    binary packages when using the install as well.
-----/SNIP-----

Based on my experience of using pkgsrc (with mk.confs that shouldn't mess with the above) on multiple platforms, pkgsrc seems to *always* put freshly-build packages into $PACKAGES, whether they're explicitly-installed or pulled-in as dependencies. So, the paragraph should be adjusted to reflect that.

And in pkgsrc/mk/default/mk.conf, there's also ``PKGSRC_KEEP_BIN_PKGS?=  yes''.
>How-To-Repeat:
``make install'' any random package in pkgsrc HEAD with an unmodified mk.conf, and check $PACKAGES for any packages that were installed as dependencies.
>Fix:
Show the keyboard who's boss.

>Release-Note:

>Audit-Trail:
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52708 CVS commit: pkgsrc/doc
Date: Tue, 18 Sep 2018 02:58:05 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Tue Sep 18 02:58:05 UTC 2018

 Modified Files:
 	pkgsrc/doc: pkgsrc.txt

 Log Message:
 Update documentation to mention PKGSRC_KEEP_BIN_PKGS, and remove now
 stale information of DEPENDS_TARGET.

 Heads up by Dean Matzkov in PR pkg/52708.


 To generate a diff of this commit:
 cvs rdiff -u -r1.251 -r1.252 pkgsrc/doc/pkgsrc.txt

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52708 CVS commit: pkgsrc/doc/guide/files
Date: Tue, 18 Sep 2018 03:17:28 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Tue Sep 18 03:17:28 UTC 2018

 Modified Files:
 	pkgsrc/doc/guide/files: configuring.xml

 Log Message:
 Update documentation to mention PKGSRC_KEEP_BIN_PKGS, and remove now
 stale information of DEPENDS_TARGET.

 Heads up by Dean Matzkov in PR pkg/52708.

 (Now to the right place, not the generated output)


 To generate a diff of this commit:
 cvs rdiff -u -r1.52 -r1.53 pkgsrc/doc/guide/files/configuring.xml

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Tue, 18 Sep 2018 03:22:44 +0000
State-Changed-Why:
I've adjusted it. Thanks for the heads up! (wording was indeed hard)


>Unformatted:

Home	PR Database Search