NetBSD Problem Report #52711

From john@andromeda.ziaspace.com  Thu Nov  9 18:58:00 2017
Return-Path: <john@andromeda.ziaspace.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 29EC77A1D2
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  9 Nov 2017 18:58:00 +0000 (UTC)
Message-Id: <20171109185719.0D30A731FEB@andromeda.ziaspace.com>
Date: Thu,  9 Nov 2017 18:57:19 +0000 (UTC)
From: john@ziaspace.com
Reply-To: john@ziaspace.com
To: gnats-bugs@NetBSD.org
Subject: net/samba4 doesn't accept /usr/local as LOCALBASE
X-Send-Pr-Version: 3.95

>Number:         52711
>Category:       pkg
>Synopsis:       net/samba4 doesn't accept /usr/local as LOCALBASE
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 09 19:00:00 +0000 2017
>Closed-Date:    Sat Apr 28 08:54:02 +0000 2018
>Last-Modified:  Sat Apr 28 08:54:02 +0000 2018
>Originator:     John Klos
>Release:        NetBSD 7.1_STABLE
>Organization:

>Environment:


System: NetBSD andromeda.ziaspace.com 7.1_STABLE NetBSD 7.1_STABLE (ANDROMEDA-$Revision: 8.0b $) #0: Sat Oct 14 18:24:37 UTC 2017 john@andromeda.ziaspace.com:/usr/release/obj-amd64/sys/arch/amd64/compile/ANDROMEDA amd64
Architecture: x86_64
Machine: amd64
>Description:

pkgsrc/net/samba4 doesn't accept /usr/local as LOCALBASE:
...
Checking for library python2.7                                                    : yes 
Checking for program python2.7-config                                             : /usr/local/bin/python2.7-config 
Checking for custom code                                                          : yes 
Don't install directly under /usr or /usr/local without using the FHS option (--enable-fhs)
ERROR: invalid --prefix=/usr/local value
*** Error code 1

Stop.
...
>How-To-Repeat:

Try to build net/samba4 with LOCALBASE set to /usr/local.
>Fix:


>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/52711: net/samba4 doesn't accept /usr/local as LOCALBASE
Date: Fri, 10 Nov 2017 00:40:01 +0100

 On Thu, Nov 09, 2017 at 07:00:00PM +0000, john@ziaspace.com wrote:
 > >Number:         52711
 > >Category:       pkg
 > >Synopsis:       net/samba4 doesn't accept /usr/local as LOCALBASE
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       medium
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Thu Nov 09 19:00:00 +0000 2017
 > >Originator:     John Klos
 > >Release:        NetBSD 7.1_STABLE
 > >Organization:
 > 	
 > >Environment:
 > 	
 > 	
 > System: NetBSD andromeda.ziaspace.com 7.1_STABLE NetBSD 7.1_STABLE (ANDROMEDA-$Revision: 8.0b $) #0: Sat Oct 14 18:24:37 UTC 2017 john@andromeda.ziaspace.com:/usr/release/obj-amd64/sys/arch/amd64/compile/ANDROMEDA amd64
 > Architecture: x86_64
 > Machine: amd64
 > >Description:
 > 	
 > pkgsrc/net/samba4 doesn't accept /usr/local as LOCALBASE:
 > ...
 > Checking for library python2.7                                                    : yes 
 > Checking for program python2.7-config                                             : /usr/local/bin/python2.7-config 
 > Checking for custom code                                                          : yes 
 > Don't install directly under /usr or /usr/local without using the FHS option (--enable-fhs)
 > ERROR: invalid --prefix=/usr/local value
 > *** Error code 1

 Have you tried building with --enable-fhs?
  Thomas

From: John Klos <john@ziaspace.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/52711: net/samba4 doesn't accept /usr/local as LOCALBASE
Date: Thu, 9 Nov 2017 23:55:11 +0000 (UTC)

 > Have you tried building with --enable-fhs?

 I have, and that did not work due to other changes that the option causes. 
 What does seem to work, though:

 --- work/samba-4.6.8/dynconfig/wscript.orig	2017-01-11 07:55:14.000000000 +0000
 +++ work/samba-4.6.8/dynconfig/wscript	2017-11-09 23:52:31.000000000 +0000
 @@ -302,9 +302,6 @@
           flavor = 'FHS-PATH'
       else:
           flavor = 'STD-PATH'
 -        if conf.env.PREFIX == '/usr' or conf.env.PREFIX == '/usr/local':
 -           Logs.error("Don't install directly under /usr or /usr/local without using the FHS option (--enable-fhs)")
 -           raise Utils.WafError("ERROR: invalid --prefix=%s value" % (conf.env.PREFIX))

       explicit_set ={}

From: coypu@sdf.org
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/52711: net/samba4 doesn't accept /usr/local as LOCALBASE
Date: Fri, 10 Nov 2017 22:04:06 +0000

 Change looks good to me, if it's generated as a proper pkgsrc
 patch, has a description and patch checksum :-)

 Go for it!

From: "John Klos" <jklos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52711 CVS commit: pkgsrc/net/samba4
Date: Sat, 11 Nov 2017 01:32:47 +0000

 Module Name:	pkgsrc
 Committed By:	jklos
 Date:		Sat Nov 11 01:32:47 UTC 2017

 Modified Files:
 	pkgsrc/net/samba4: distinfo
 Added Files:
 	pkgsrc/net/samba4/patches: patch-dynconfig_wscript

 Log Message:
 Fixes PR # 52711. Allows installation of package in /usr/local LOCALBASE.


 To generate a diff of this commit:
 cvs rdiff -u -r1.16 -r1.17 pkgsrc/net/samba4/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/net/samba4/patches/patch-dynconfig_wscript

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 28 Apr 2018 08:54:02 +0000
State-Changed-Why:
Committed by submitter.


>Unformatted:

Home	PR Database Search