NetBSD Problem Report #52726

From www@NetBSD.org  Tue Nov 14 03:39:47 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EF3377A1B7
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 14 Nov 2017 03:39:46 +0000 (UTC)
Message-Id: <20171114033946.13CFC7A237@mollari.NetBSD.org>
Date: Tue, 14 Nov 2017 03:39:46 +0000 (UTC)
From: heas@shrubbery.net
Reply-To: heas@shrubbery.net
To: gnats-bugs@NetBSD.org
Subject: net/wget: missing configure option when building w/o idn
X-Send-Pr-Version: www-1.0

>Number:         52726
>Category:       pkg
>Synopsis:       net/wget: missing configure option when building w/o idn
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    leot
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 14 03:40:00 +0000 2017
>Closed-Date:    Sat Jan 20 09:02:48 +0000 2018
>Last-Modified:  Sun Mar 11 22:50:01 +0000 2018
>Originator:     john heasley
>Release:        current
>Organization:
ntt
>Environment:
centos7
>Description:
building net/wget without idn support fails; seems that its missing a configure option, as below.
>How-To-Repeat:
Attempt to build without idn option and w/o libidn.
>Fix:
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/net/wget/options.mk,v
retrieving revision 1.9
16a17,18
> .else
> CONFIGURE_ARGS+=      -disable-iri

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->leot
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Tue, 14 Nov 2017 09:31:50 +0000
Responsible-Changed-Why:
Take


State-Changed-From-To: open->feedback
State-Changed-By: leot@NetBSD.org
State-Changed-When: Tue, 14 Nov 2017 09:56:36 +0000
State-Changed-Why:
Hello john,
I have just committed a similar patch that you proposed.
I have also noticed that since wget 1.19 libidn2 is needed
for IDN/IRIs support (instead of libidn) and adjusted that
as well.

Can you please try with net/wget/Makefile r1.137 and
net/wget/options.mk r1.10 and let us known if it fixes the
issue?

Thank you!


From: "Leonardo Taccari" <leot@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52726 CVS commit: pkgsrc/net/wget
Date: Tue, 14 Nov 2017 09:51:13 +0000

 Module Name:	pkgsrc
 Committed By:	leot
 Date:		Tue Nov 14 09:51:13 UTC 2017

 Modified Files:
 	pkgsrc/net/wget: Makefile options.mk

 Log Message:
 wget: Use devel/libidn2 and adjust `idn' option logic in options.mk

 Since wget-1.19, libidn2 is needed for the IDN/IRIs support. Adjust
 the `idn' package option logic to reflect that and explicitly ask
 for it via CONFIGURE_ARGS. This should also fix the build without
 the `idn' option selected pointed out by john heasley via PR pkg/52726.

 Bump PKGREVISION


 To generate a diff of this commit:
 cvs rdiff -u -r1.136 -r1.137 pkgsrc/net/wget/Makefile
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/net/wget/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->closed
State-Changed-By: leot@NetBSD.org
State-Changed-When: Sat, 20 Jan 2018 09:02:48 +0000
State-Changed-Why:
Assume fixed (feedback timeout).

(I was able to reproduce that locally and with the committed patch
disabling `idn' option shouldn't be problematic no more.)

Thank you for the PR!


From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/52726 - non-critical low priority change-request
Date: Sun, 11 Mar 2018 22:45:15 +0000

 Not sent to gnats (use gnats-bugs for PR traffic)

    ------

 From: heasley <heas@shrubbery.net>
 To: NetBSD Problem Report DB Administrator <gnats@NetBSD.org>
 Subject: Re: pkg/52726 - non-critical low priority change-request
 Date: Fri, 5 Jan 2018 19:48:25 +0000

 Hey, sorry for the late reply.  The fix seems to work fine; this is pkgsrc on
 centos7.  Thanks

>Unformatted:

Home	PR Database Search