NetBSD Problem Report #53009

From www@NetBSD.org  Sun Feb 11 07:24:59 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B79877A1B5
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 11 Feb 2018 07:24:59 +0000 (UTC)
Message-Id: <20180211072458.AE0867A220@mollari.NetBSD.org>
Date: Sun, 11 Feb 2018 07:24:58 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: GCC6: bool variable is initialized with NULL (i386.c)
X-Send-Pr-Version: www-1.0

>Number:         53009
>Category:       toolchain
>Synopsis:       GCC6: bool variable is initialized with NULL (i386.c)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 11 07:25:00 +0000 2018
>Closed-Date:    Sun Jun 03 22:36:32 +0000 2018
>Last-Modified:  Sun Jun 03 22:36:32 +0000 2018
>Originator:     Henning Petersen
>Release:        netbsd-current
>Organization:
>Environment:
>Description:
Bool variable is initialized with NULL (i386.c)
>How-To-Repeat:

>Fix:
diff -u -u -p -r1.15 i386.c
--- external/gpl3/gcc/dist/gcc/config/i386/i386.c	2 Feb 2018 03:41:04 -0000	1.15
+++ external/gpl3/gcc/dist/gcc/config/i386/i386.c	11 Feb 2018 07:07:56 -0000
@@ -8686,7 +8686,7 @@ function_arg_advance_32 (CUMULATIVE_ARGS
 			 HOST_WIDE_INT words)
 {
   int res = 0;
-  bool error_p = NULL;
+  bool error_p = false;

   if (TARGET_IAMCU)
     {

>Release-Note:

>Audit-Trail:
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53009 CVS commit: src/external/gpl3
Date: Sun, 11 Feb 2018 13:50:15 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Sun Feb 11 13:50:15 UTC 2018

 Modified Files:
 	src/external/gpl3/gcc.old/dist/gcc/config/i386: i386.c
 	src/external/gpl3/gcc/dist/gcc/config/i386: i386.c

 Log Message:
 Use bools with bool. NFCI.

 From Henning Petersen in PR toolchain/53009.
 (I completed for the rest of the function. Similar code exists in GCC trunk.)


 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.9 \
     src/external/gpl3/gcc.old/dist/gcc/config/i386/i386.c
 cvs rdiff -u -r1.15 -r1.16 src/external/gpl3/gcc/dist/gcc/config/i386/i386.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: toolchain/53009: GCC6: bool variable is initialized with NULL
 (i386.c)
Date: Sun, 11 Feb 2018 13:52:57 +0000

 Hello Henning,

 What generated this error? GCC-6-branch is still wrong in this way, if
 it's failing to build with some compiler it will be good to ask for it
 to backported to the gcc-6 branch upstream.

 Thanks.

State-Changed-From-To: open->feedback
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 11 Feb 2018 16:41:41 +0000
State-Changed-Why:
Applied - thanks. is the error causing build problems? should that be pulled up to -8 as well?


State-Changed-From-To: feedback->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 03 Jun 2018 22:36:32 +0000
State-Changed-Why:
Assuming this is a static checker and not a build error, so no pullup needed. THanks for the report!


>Unformatted:

Home	PR Database Search