NetBSD Problem Report #53030

From www@NetBSD.org  Wed Feb 14 14:27:48 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BE46F7A1B5
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 14 Feb 2018 14:27:48 +0000 (UTC)
Message-Id: <20180214142747.D22137A222@mollari.NetBSD.org>
Date: Wed, 14 Feb 2018 14:27:47 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/netinet6/raw_ip6.c:200]: (style) Redundant condition
X-Send-Pr-Version: www-1.0

>Number:         53030
>Category:       kern
>Synopsis:       src/sys/netinet6/raw_ip6.c:200]: (style) Redundant condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 14 14:30:01 +0000 2018
>Closed-Date:    Mon Feb 26 09:13:28 +0000 2018
>Last-Modified:  Mon Feb 26 09:15:00 +0000 2018
>Originator:     David Binderman
>Release:        cvs-20180214
>Organization:
>Environment:
>Description:
src/sys/netinet6/raw_ip6.c:200]: (style) Redundant condition: ipsec_used. '!ipsec_used || (ipsec_used && !ipsec6_in_reject(m,last))' is equivalent to '!ipsec_used || !ipsec6_in_reject(m,last)'

Source code is

            if (!ipsec_used ||
                (ipsec_used && !ipsec6_in_reject(m, last)))



>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: maxv@NetBSD.org
State-Changed-When: Mon, 26 Feb 2018 09:13:28 +0000
State-Changed-Why:
Fixed, thanks.


From: "Maxime Villard" <maxv@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53030 CVS commit: src/sys/netinet6
Date: Mon, 26 Feb 2018 09:13:00 +0000

 Module Name:	src
 Committed By:	maxv
 Date:		Mon Feb 26 09:13:00 UTC 2018

 Modified Files:
 	src/sys/netinet6: icmp6.c raw_ip6.c

 Log Message:
 Remove redundant condition (harmless). PR/53030.


 To generate a diff of this commit:
 cvs rdiff -u -r1.221 -r1.222 src/sys/netinet6/icmp6.c
 cvs rdiff -u -r1.163 -r1.164 src/sys/netinet6/raw_ip6.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search