NetBSD Problem Report #53212

From www@NetBSD.org  Wed Apr 25 14:23:24 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EC5327A152
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 25 Apr 2018 14:23:24 +0000 (UTC)
Message-Id: <20180425142323.A3F417A218@mollari.NetBSD.org>
Date: Wed, 25 Apr 2018 14:23:23 +0000 (UTC)
From: davshao@gmail.com
Reply-To: davshao@gmail.com
To: gnats-bugs@NetBSD.org
Subject: time/xfce4-orage fails to build after update to time/libical to 3.0.3
X-Send-Pr-Version: www-1.0

>Number:         53212
>Category:       pkg
>Synopsis:       time/xfce4-orage fails to build after update to time/libical to 3.0.3
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    markd
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 25 14:25:00 +0000 2018
>Closed-Date:    Thu Apr 26 20:41:36 +0000 2018
>Last-Modified:  Fri Apr 27 20:25:00 +0000 2018
>Originator:     David Shao
>Release:        current pkgsrc
>Organization:
>Environment:
NetBSD xxxxxx.xxx 8.99.14 NetBSD 8.99.14 (GENERIC) #11: Tue Apr 24 23:37:54 PDT 2018  xxxxxx@xxxxxx.xxx:/usr/obj/sys/arch/amd64/compile/GENERIC amd64

>Description:
After the update to time/libical 3.0.3, time/xfce4-orage fails to build with:

ical-code.c: In function 'count_first_alarm_time':
ical-code.c:2582:22: error: 'struct icaltimetype' has no member named 'is_utc'; did you mean 'is_date'?
             per.stime.is_utc        = 1;
                      ^
ical-code.c:2591:22: error: 'struct icaltimetype' has no member named 'is_utc'; did you mean 'is_date'?
             per.etime.is_utc        = 1;
                      ^
ical-code.c: In function 'count_next_alarm_time':
ical-code.c:2616:19: error: 'struct icaltimetype' has no member named 'is_utc'; did you mean 'is_date'?
         start_time.is_utc        = 1;
                   ^
ical-code.c: In function 'process_alarm_trigger':
ical-code.c:2771:28: error: 'struct icaltimetype' has no member named 'is_utc'; did you mean 'is_date'?
             next_alarm_time.is_utc        = 0;
                            ^
ical-code.c:2853:32: error: 'struct icaltimetype' has no member named 'is_utc'; did you mean 'is_date'?
                 next_alarm_time.is_utc        = 0;
                                ^
ical-code.c:2947:32: error: 'struct icaltimetype' has no member named 'is_utc'; did you mean 'is_date'?
                 next_alarm_time.is_utc        = 0;
                                ^
Makefile:707: recipe for target 'orage-ical-code.o' failed

>How-To-Repeat:
/etc/mk.conf does have lines:

CURSES_DEFAULT=ncurses
READLINE_DEFAULT=readline

CFLAGS+= -g
INSTALL_UNSTRIPPED=yes
USE_DESTDIR=yes

ACCEPTABLE_LICENSES += vim-license lame-license vera-ttf-license 
ALLOW_VULNERABLE_PACKAGES=yes

PKG_OPTIONS.xfce4-thunar = -gvfs 
PKG_OPTIONS.ffmpeg = -x264
>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->markd
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Wed, 25 Apr 2018 14:37:13 +0000
Responsible-Changed-Why:
Mark, can you please take a look at this? Thanks.


From: "Mark Davies" <markd@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53212 CVS commit: pkgsrc/time/xfce4-orage
Date: Wed, 25 Apr 2018 21:44:44 +0000

 Module Name:	pkgsrc
 Committed By:	markd
 Date:		Wed Apr 25 21:44:44 UTC 2018

 Modified Files:
 	pkgsrc/time/xfce4-orage: Makefile distinfo
 Added Files:
 	pkgsrc/time/xfce4-orage/patches: patch-src_ical-code.c

 Log Message:
 xfce4-orage: build with libical-3.

 fixes PR pkg/53212


 To generate a diff of this commit:
 cvs rdiff -u -r1.41 -r1.42 pkgsrc/time/xfce4-orage/Makefile
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/time/xfce4-orage/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/time/xfce4-orage/patches/patch-src_ical-code.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: David Shao <davshao@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/53212: time/xfce4-orage fails to build after update to
 time/libical to 3.0.3
Date: Wed, 25 Apr 2018 18:24:23 -0700

 Thanks for so quickly patching time/xfce4-orage for the update to
 time/libical 3.0.3.  I have successfully built
 the updated time/xfce4-orage on both NetBSD 8.99.14 amd64 and on
 DragonFly 5.3-DEVELOPMENT.

 I feel bad mentioning one small quibble, that in the Makefile for
 time/xfce4-orage, there was already a definition
 for PKGREVISION

 PKGREVISION= 7
 .include "../../meta-pkgs/xfce4/Makefile.common"

 therefore it seems in the patched version, adding the line

 VERSION=    4.12.1
 DISTNAME=    orage-${VERSION}
 PKGNAME=    xfce4-orage-${VERSION}
 PKGREVISION=    1

 actually rolls back the pkg name from xfce4-orage-4.12.1nb17 to
 xfce4-orage-4.12.1nb1

 # pkg_rolling-replace -uv -x firefox52 -X firefox52
 RR> Checking for mismatched installed packages using pkg_chk
 ...
 rr> time/libical - libical-1.0nb3 < libical-3.0.3
 rr> time/xfce4-orage - xfce4-orage-4.12.1nb7 > xfce4-orage-4.12.1nb1 - ignoring

 Maybe the first PKGREVISION should be changed to 8 and the added
 PKGREVISION=1 line removed?

From: Mark Davies <mark@ecs.vuw.ac.nz>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53212: time/xfce4-orage fails to build after update to
 time/libical to 3.0.3
Date: Thu, 26 Apr 2018 13:30:24 +1200

 On 26/04/18 13:25, David Shao wrote:
 >  Maybe the first PKGREVISION should be changed to 8 and the added
 >  PKGREVISION=1 line removed?

 Sorry, I missed the existing PKGREVISION.  I'll do the above when I get
 home tonight.

 cheers
 mark

State-Changed-From-To: open->closed
State-Changed-By: markd@NetBSD.org
State-Changed-When: Thu, 26 Apr 2018 20:41:36 +0000
State-Changed-Why:
fixed


From: David Shao <davshao@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/53212: time/xfce4-orage fails to build after update to
 time/libical to 3.0.3
Date: Fri, 27 Apr 2018 13:23:33 -0700

 time/xfce4-orage 4.12.1nb8 successfully builds on NetBSD 8.99.14
 GENERIC amd64 and DragonFly 5.3-DEVELOPMENT.
 Thanks!

>Unformatted:

Home	PR Database Search