NetBSD Problem Report #53240
From www@NetBSD.org Mon Apr 30 19:39:43 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 552EF7A167
for <gnats-bugs@gnats.NetBSD.org>; Mon, 30 Apr 2018 19:39:43 +0000 (UTC)
Message-Id: <20180430193942.35A057A214@mollari.NetBSD.org>
Date: Mon, 30 Apr 2018 19:39:42 +0000 (UTC)
From: m.viey@wanadoo.fr
Reply-To: m.viey@wanadoo.fr
To: gnats-bugs@NetBSD.org
Subject: build vlc -2.2.6 from pkgsrc 2018Q1 fails
X-Send-Pr-Version: www-1.0
>Number: 53240
>Category: pkg
>Synopsis: build vlc -2.2.6 from pkgsrc 2018Q1 fails
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Apr 30 19:40:00 +0000 2018
>Closed-Date: Thu Jan 14 12:47:22 +0000 2021
>Last-Modified: Thu Jan 14 12:47:22 +0000 2021
>Originator: Mik
>Release: 2018Q1
>Organization:
>Environment:
NetBSD dk-17 7.1_STABLE NetBSD 7.1_STABLE (MYKERNEL) #3: Sat Feb 17 19:47:02 CET 2018 mik@dk-17:/usr/src/sys/arch/amd64/compile/MYKERNEL amd64
>Description:
Build VLC 2.2.6 fails in pkgsrc with error:
icodec/x264.c:850:26: error: 'x264_bit_depth' undeclared (first use in this function)
const int mask = x264_bit_depth > 8 ? X264_CSP_HIGH_DEPTH : 0;
>How-To-Repeat:
fetch pkgsrc 2018Q1
go to multimedia/vlc
make install
>Fix:
>Release-Note:
>Audit-Trail:
From: Roy Bixler <rcbixler@nyx.net>
To: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Sun, 20 May 2018 11:47:02 -0600
--UlVJffcvxoiEqYs2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
I see the same problem. I also saw a posting in pkgsrc-users
https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html
which includes a patch. There's a follow-up which suggests another
patch. I couldn't get the latter patch to apply so I made my own
version of it, attached. vlc now builds for me and the build works
for my normal use case, but I haven't tested the x264 bits.
--
Roy Bixler <rcbixler@nyx.net>
"The fundamental principle of science, the definition almost, is this: the
sole test of the validity of any idea is experiment."
-- Richard P. Feynman
--UlVJffcvxoiEqYs2
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="x264.c.patch"
--- x264.c 2015-04-13 19:54:35.000000000 +0000
+++ x264.c.patched 2018-05-20 16:35:38.538783495 +0000
@@ -83,13 +83,7 @@
"I-frames, but do not start a new GOP." )
#define OPENGOP_TEXT N_("Use recovery points to close GOPs")
-#if X264_BUILD < 115
-#define OPENGOP_LONGTEXT N_("none: use closed GOPs only\n"\
- "normal: use standard open GOPs\n" \
- "bluray: use Blu-ray compatible open GOPs" )
-#else
#define OPENGOP_LONGTEXT N_("use open GOP, for bluray compatibility use also bluray-compat option")
-#endif
#define BLURAY_TEXT N_("Enable compatibility hacks for Blu-ray support")
#define BLURAY_LONGTEXT N_("Enable hacks for Blu-ray support, this doesn't enforce every aspect of Blu-ray compatibility\n" \
@@ -471,16 +465,10 @@
add_integer( SOUT_CFG_PREFIX "min-keyint", 25, MIN_KEYINT_TEXT,
MIN_KEYINT_LONGTEXT, true )
-#if X264_BUILD >= 102 && X264_BUILD <= 114
- add_string( SOUT_CFG_PREFIX "opengop", "none", OPENGOP_TEXT,
- OPENGOP_LONGTEXT, true )
- change_string_list( x264_open_gop_names, x264_open_gop_names )
-#elif X264_BUILD > 114
add_bool( SOUT_CFG_PREFIX "opengop", false, OPENGOP_TEXT,
OPENGOP_LONGTEXT, true )
add_bool( SOUT_CFG_PREFIX "bluray-compat", false, BLURAY_TEXT,
BLURAY_LONGTEXT, true )
-#endif
add_integer( SOUT_CFG_PREFIX "scenecut", 40, SCENE_TEXT,
SCENE_LONGTEXT, true )
@@ -500,13 +488,8 @@
B_BIAS_LONGTEXT, true )
change_integer_range( -100, 100 )
-#if X264_BUILD >= 87
add_string( SOUT_CFG_PREFIX "bpyramid", "normal", BPYRAMID_TEXT,
BPYRAMID_LONGTEXT, true )
-#else
- add_string( SOUT_CFG_PREFIX "bpyramid", "none", BPYRAMID_TEXT,
- BPYRAMID_LONGTEXT, true )
-#endif
change_string_list( bpyramid_list, bpyramid_list )
add_bool( SOUT_CFG_PREFIX "cabac", true, CABAC_TEXT, CABAC_LONGTEXT,
@@ -543,22 +526,18 @@
add_bool( SOUT_CFG_PREFIX "interlaced", false, INTERLACED_TEXT, INTERLACED_LONGTEXT,
true )
-#if X264_BUILD >= 111
add_integer( SOUT_CFG_PREFIX "frame-packing", -1, FRAMEPACKING_TEXT, FRAMEPACKING_LONGTEXT, true )
change_integer_list( framepacking_list, framepacking_list_text )
change_integer_range( -1, 5)
-#endif
add_integer( SOUT_CFG_PREFIX "slices", 0, SLICE_COUNT, SLICE_COUNT_LONGTEXT, true )
add_integer( SOUT_CFG_PREFIX "slice-max-size", 0, SLICE_MAX_SIZE, SLICE_MAX_SIZE_LONGTEXT, true )
add_integer( SOUT_CFG_PREFIX "slice-max-mbs", 0, SLICE_MAX_MBS, SLICE_MAX_MBS_LONGTEXT, true )
-#if X264_BUILD >= 89
add_string( SOUT_CFG_PREFIX "hrd", "none", HRD_TEXT, HRD_TEXT, true )
vlc_config_set (VLC_CONFIG_LIST,
(sizeof(x264_nal_hrd_names) / sizeof (char*)) - 1,
x264_nal_hrd_names, x264_nal_hrd_names);
-#endif
/* Ratecontrol */
@@ -843,20 +822,14 @@
fullrange = var_GetBool( p_enc, SOUT_CFG_PREFIX "fullrange" );
p_enc->fmt_in.i_codec = fullrange ? VLC_CODEC_J420 : VLC_CODEC_I420;
p_sys->i_colorspace = X264_CSP_I420;
-#if X264_BUILD >= 118
char *psz_profile = var_GetString( p_enc, SOUT_CFG_PREFIX "profile" );
- if( psz_profile )
- {
- const int mask = x264_bit_depth > 8 ? X264_CSP_HIGH_DEPTH : 0;
-
-
# ifdef MODULE_NAME_IS_x26410b
- if( mask == 0)
- {
- msg_Err( p_enc, "Only high bith depth encoding supported, bit depth:%d", x264_bit_depth);
- return VLC_EGENERIC;
- }
+ const int mask = X264_CSP_HIGH_DEPTH;
+# else
+ const int mask = 0;
# endif
+ if( psz_profile )
+ {
if( !strcmp( psz_profile, "high10" ) )
{
@@ -879,7 +852,6 @@
msg_Err( p_enc, "Only high-profiles and 10-bit are supported");
return VLC_EGENERIC;
}
-
# endif
}
# ifdef MODULE_NAME_IS_x26410b
@@ -890,7 +862,6 @@
}
# endif
free( psz_profile );
-#endif //X264_BUILD
p_enc->pf_encode_video = Encode;
p_enc->pf_encode_audio = NULL;
@@ -913,6 +884,10 @@
#else
x264_param_default( &p_sys->param );
x264_param_default_preset( &p_sys->param, psz_preset, psz_tune );
+# if X264_BUILD > 152
+ if( mask )
+ p_sys->param.i_bitdepth = 10;
+# endif
#endif
free( psz_preset );
free( psz_tune );
@@ -1045,10 +1020,8 @@
if( fabs( var_GetFloat( p_enc, SOUT_CFG_PREFIX "aq-strength" ) - 1.0) > 0.005 )
p_sys->param.rc.f_aq_strength = var_GetFloat( p_enc, SOUT_CFG_PREFIX "aq-strength" );
-#if X264_BUILD >= 111
if( var_GetInteger( p_enc, SOUT_CFG_PREFIX "frame-packing" ) > -1 )
p_sys->param.i_frame_packing = var_GetInteger( p_enc, SOUT_CFG_PREFIX "frame-packing" );
-#endif
if( var_GetBool( p_enc, SOUT_CFG_PREFIX "verbose" ) )
p_sys->param.i_log_level = X264_LOG_DEBUG;
@@ -1064,26 +1037,14 @@
i_val = var_GetInteger( p_enc, SOUT_CFG_PREFIX "keyint" );
if( i_val > 0 && i_val != 250 ) p_sys->param.i_keyint_max = i_val;
-#if X264_BUILD >= 102
if( i_val == -1 ) p_sys->param.i_keyint_max = X264_KEYINT_MAX_INFINITE;
-#endif
i_val = var_GetInteger( p_enc, SOUT_CFG_PREFIX "min-keyint" );
if( i_val > 0 && i_val != 25 ) p_sys->param.i_keyint_min = i_val;
-#if X264_BUILD >= 102 && X264_BUILD <= 114
- psz_val = var_GetString( p_enc, SOUT_CFG_PREFIX "opengop" );
- if( !strcmp( psz_val, "none" ) )
- p_sys->param.i_open_gop = X264_OPEN_GOP_NONE;
- else if( !strcmp( psz_val, "normal" ) )
- p_sys->param.i_open_gop = X264_OPEN_GOP_NORMAL;
- else if( !strcmp( psz_val, "bluray" ) )
- p_sys->param.i_open_gop = X264_OPEN_GOP_BLURAY;
- free( psz_val );
-#elif X264_BUILD >= 115
p_sys->param.b_open_gop = var_GetBool( p_enc, SOUT_CFG_PREFIX "opengop" );
p_sys->param.b_bluray_compat = var_GetBool( p_enc, SOUT_CFG_PREFIX "bluray-compat" );
-#endif
+
i_val = var_GetInteger( p_enc, SOUT_CFG_PREFIX "bframes" );
if( i_val >= 0 && i_val <= 16 && i_val != 3 )
p_sys->param.i_bframe = i_val;
@@ -1121,14 +1082,12 @@
if( i_val >= 1 && i_val != 7 )
p_sys->param.analyse.i_subpel_refine = i_val;
-#if X264_BUILD >= 89
psz_val = var_GetString( p_enc, SOUT_CFG_PREFIX "hrd");
if( !strcmp( psz_val, "vbr" ) )
p_sys->param.i_nal_hrd = X264_NAL_HRD_VBR;
else if( !strcmp( psz_val, "cbr" ) )
p_sys->param.i_nal_hrd = X264_NAL_HRD_CBR;
free( psz_val );
-#endif
//TODO: psz_val == NULL ?
psz_val = var_GetString( p_enc, SOUT_CFG_PREFIX "me" );
@@ -1486,11 +1445,7 @@
int i_nal=0, i_out=0, i=0;
/* init pic */
-#if X264_BUILD >= 98
x264_picture_init( &pic );
-#else
- memset( &pic, 0, sizeof( x264_picture_t ) );
-#endif
if( likely(p_pict) ) {
pic.i_pts = p_pict->date;
pic.img.i_csp = p_sys->i_colorspace;
--UlVJffcvxoiEqYs2--
From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
m.viey@wanadoo.fr
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Tue, 22 May 2018 14:02:54 +0200
On Sun, May 20, 2018 at 09:35:01PM +0000, Roy Bixler wrote:
> The following reply was made to PR pkg/53240; it has been noted by GNATS.
>
> From: Roy Bixler <rcbixler@nyx.net>
> To: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
> Cc:
> Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
> Date: Sun, 20 May 2018 11:47:02 -0600
>
> --UlVJffcvxoiEqYs2
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
>
> I see the same problem. I also saw a posting in pkgsrc-users
>
> https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html
>
> which includes a patch. There's a follow-up which suggests another
> patch. I couldn't get the latter patch to apply so I made my own
> version of it, attached. vlc now builds for me and the build works
> for my normal use case, but I haven't tested the x264 bits.
The patch is just wrong.
Joerg
From: Roy Bixler <rcbixler@nyx.net>
To: gnats-bugs@NetBSD.org
Cc: Joerg Sonnenberger <joerg@bec.de>, pkg-manager@netbsd.org,
gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org, m.viey@wanadoo.fr
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Tue, 22 May 2018 17:41:16 -0600
On Tue, 22 May 2018 14:02:54 +0200, Joerg Sonnenberger wrote:
> The patch is just wrong.
That's unfortunate, but I'm not surprised. After all, I don't know
how to test whether it works and I had no prior confirmation that it
was supposed to work. It did make vlc buildable for me. I also
mentioned another possible patch from
https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html
I'll repeat it here:
--- modules/codec/x264.c.orig 2015-04-13 19:54:35.000000000 +0000
+++ modules/codec/x264.c
@@ -843,7 +843,7 @@ static int Open ( vlc_object_t *p_this
fullrange = var_GetBool( p_enc, SOUT_CFG_PREFIX "fullrange" );
p_enc->fmt_in.i_codec = fullrange ? VLC_CODEC_J420 : VLC_CODEC_I420;
p_sys->i_colorspace = X264_CSP_I420;
-#if X264_BUILD >= 118
+#if X264_BUILD >= 118 && X264_BUILD < 155
char *psz_profile = var_GetString( p_enc, SOUT_CFG_PREFIX "profile" );
if( psz_profile )
{
This is much simpler. Is it also wrong? If so, do you have an
alternative?
--
Roy Bixler <rcbixler@nyx.net>
"The fundamental principle of science, the definition almost, is this: the
sole test of the validity of any idea is experiment."
-- Richard P. Feynman
From: Kamil Rytarowski <n54@gmx.com>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Wed, 23 May 2018 08:03:00 +0200
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M
Content-Type: multipart/mixed; boundary="Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts";
protected-headers="v1"
From: Kamil Rytarowski <n54@gmx.com>
To: gnats-bugs@NetBSD.org
Message-ID: <777622d4-ecc7-21ae-cb0a-25fe5da48ac4@gmx.com>
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
References: <20180522234116.GA21971@nyx.net>
In-Reply-To: <20180522234116.GA21971@nyx.net>
--Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 23.05.2018 01:41, Roy Bixler wrote:
> On Tue, 22 May 2018 14:02:54 +0200, Joerg Sonnenberger wrote:
>> The patch is just wrong.
>=20
> That's unfortunate, but I'm not surprised. After all, I don't know
> how to test whether it works and I had no prior confirmation that it
> was supposed to work. It did make vlc buildable for me. I also
> mentioned another possible patch from
>=20
> https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html
>=20
> I'll repeat it here:
>=20
> --- modules/codec/x264.c.orig 2015-04-13 19:54:35.000000000 +0000
> +++ modules/codec/x264.c
> @@ -843,7 +843,7 @@ static int Open ( vlc_object_t *p_this=20
> fullrange =3D var_GetBool( p_enc, SOUT_CFG_PREFIX "fullrange" );
> p_enc->fmt_in.i_codec =3D fullrange ? VLC_CODEC_J420 : VLC_CODEC_I=
420;
> p_sys->i_colorspace =3D X264_CSP_I420;
> -#if X264_BUILD >=3D 118
> +#if X264_BUILD >=3D 118 && X264_BUILD < 155
> char *psz_profile =3D var_GetString( p_enc, SOUT_CFG_PREFIX "profi=
le" );
> if( psz_profile )
> {
>=20
> This is much simpler. Is it also wrong? If so, do you have an
> alternative?
>=20
This approach was rejected upstream so it's presumably wrong.
Can you use VLC 3.x? It's in pkgsrc/wip/vlc.
It crashes for me due to X issues, but it might works for you.
--Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts--
--zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJABAEBCAAqFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAlsFBBQMHG41NEBnbXgu
Y29tAAoJEEuzCOmwLnZsPpEP/RoH3vo7EYNj8x0lzAbSrxGO0nFfy41nb8PdmEAb
J1vm2wgSJMGSB8gEsIdTgkUPUsmGO4vXbdgztmLFGbzc5VmtxtvsXa0cx1OPwfjA
5Rrhk6Mti461AokqbbWvKCxuNfkVb5L83JL61Vd0aR0KcEHibFT7wsWcYZZksCmi
sXqcdKiodvn5ctujNpisDbqStJC1IsPFwtN3A6FLYZhfvdWgD6IBCDuypCjC7YHs
7PJSkGWabDoPydajUBMMQDYBM6WXW0eOn+K2XXj8q5Dt5UG5PN78x51ln+z/LQQb
ke42Zaubat19dGL4JZUfD2Qoqb9FI4kAtKcQMtXK5KXfCapsgHCcarsZG8vf7LgG
Vc+ukU8EAUk3K0kc0bBWlkoi0vuviJQuEXNScVd6M2L6yLjoga5Kh1oK6vzUAqlI
MGDf11U/Cq8POAeu+TmaeLURWvdbhxJMbgYv1K0r2GGKkaLrcsJYqsGxhVtC/Xr5
LWwBhhppMdb0GDsgTaWAewnGdNq+n9X/okqJAjmJfBL1S4ZmNoj4S8XRSqI9RZGM
W82F/ps0z2YjN2kxgTqlxXLFDro6YNVLsvFr4vycF5ZS+ZJCiOdVcLoN6CkFLg6f
+Ta8PMbmKHMpQ4Zwt0lY7n83bEooWKBXIDVeT6IP+8wGzQcR1EJdbDhN/q8XJITR
aDPT
=wqDK
-----END PGP SIGNATURE-----
--zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M--
From: Mickael Viey <m.viey@wanadoo.fr>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Wed, 23 May 2018 19:21:56 +0200
This is a multi-part message in MIME format.
--------------D720CF68A852AB9994793C61
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Is it possible to build VLC 3.xx from 2018Q1 ??
Le 23/05/2018 à 08:05, Kamil Rytarowski a écrit :
> The following reply was made to PR pkg/53240; it has been noted by GNATS.
>
> From: Kamil Rytarowski <n54@gmx.com>
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
> Date: Wed, 23 May 2018 08:03:00 +0200
>
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M
> Content-Type: multipart/mixed; boundary="Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts";
> protected-headers="v1"
> From: Kamil Rytarowski <n54@gmx.com>
> To: gnats-bugs@NetBSD.org
> Message-ID: <777622d4-ecc7-21ae-cb0a-25fe5da48ac4@gmx.com>
> Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
> References: <20180522234116.GA21971@nyx.net>
> In-Reply-To: <20180522234116.GA21971@nyx.net>
>
> --Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts
> Content-Type: text/plain; charset=utf-8
> Content-Language: en-US
> Content-Transfer-Encoding: quoted-printable
>
> On 23.05.2018 01:41, Roy Bixler wrote:
> > On Tue, 22 May 2018 14:02:54 +0200, Joerg Sonnenberger wrote:
> >> The patch is just wrong.
> >=20
> > That's unfortunate, but I'm not surprised. After all, I don't know
> > how to test whether it works and I had no prior confirmation that it
> > was supposed to work. It did make vlc buildable for me. I also
> > mentioned another possible patch from
> >=20
> > https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html
> >=20
> > I'll repeat it here:
> >=20
> > --- modules/codec/x264.c.orig 2015-04-13 19:54:35.000000000 +0000
> > +++ modules/codec/x264.c
> > @@ -843,7 +843,7 @@ static int Open ( vlc_object_t *p_this=20
> > fullrange =3D var_GetBool( p_enc, SOUT_CFG_PREFIX "fullrange" );
> > p_enc->fmt_in.i_codec =3D fullrange ? VLC_CODEC_J420 : VLC_CODEC_I=
> 420;
> > p_sys->i_colorspace =3D X264_CSP_I420;
> > -#if X264_BUILD >=3D 118
> > +#if X264_BUILD >=3D 118 && X264_BUILD < 155
> > char *psz_profile =3D var_GetString( p_enc, SOUT_CFG_PREFIX "profi=
> le" );
> > if( psz_profile )
> > {
> >=20
> > This is much simpler. Is it also wrong? If so, do you have an
> > alternative?
> >=20
>
> This approach was rejected upstream so it's presumably wrong.
>
> Can you use VLC 3.x? It's in pkgsrc/wip/vlc.
>
> It crashes for me due to X issues, but it might works for you.
>
>
> --Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts--
>
> --zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M
> Content-Type: application/pgp-signature; name="signature.asc"
> Content-Description: OpenPGP digital signature
> Content-Disposition: attachment; filename="signature.asc"
>
> -----BEGIN PGP SIGNATURE-----
>
> iQJABAEBCAAqFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAlsFBBQMHG41NEBnbXgu
> Y29tAAoJEEuzCOmwLnZsPpEP/RoH3vo7EYNj8x0lzAbSrxGO0nFfy41nb8PdmEAb
> J1vm2wgSJMGSB8gEsIdTgkUPUsmGO4vXbdgztmLFGbzc5VmtxtvsXa0cx1OPwfjA
> 5Rrhk6Mti461AokqbbWvKCxuNfkVb5L83JL61Vd0aR0KcEHibFT7wsWcYZZksCmi
> sXqcdKiodvn5ctujNpisDbqStJC1IsPFwtN3A6FLYZhfvdWgD6IBCDuypCjC7YHs
> 7PJSkGWabDoPydajUBMMQDYBM6WXW0eOn+K2XXj8q5Dt5UG5PN78x51ln+z/LQQb
> ke42Zaubat19dGL4JZUfD2Qoqb9FI4kAtKcQMtXK5KXfCapsgHCcarsZG8vf7LgG
> Vc+ukU8EAUk3K0kc0bBWlkoi0vuviJQuEXNScVd6M2L6yLjoga5Kh1oK6vzUAqlI
> MGDf11U/Cq8POAeu+TmaeLURWvdbhxJMbgYv1K0r2GGKkaLrcsJYqsGxhVtC/Xr5
> LWwBhhppMdb0GDsgTaWAewnGdNq+n9X/okqJAjmJfBL1S4ZmNoj4S8XRSqI9RZGM
> W82F/ps0z2YjN2kxgTqlxXLFDro6YNVLsvFr4vycF5ZS+ZJCiOdVcLoN6CkFLg6f
> +Ta8PMbmKHMpQ4Zwt0lY7n83bEooWKBXIDVeT6IP+8wGzQcR1EJdbDhN/q8XJITR
> aDPT
> =wqDK
> -----END PGP SIGNATURE-----
>
> --zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M--
>
--------------D720CF68A852AB9994793C61
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#333333" bgcolor="#CCCCCC">
<p>Is it possible to build VLC 3.xx from 2018Q1 ??<br>
</p>
<br>
<div class="moz-cite-prefix">Le 23/05/2018 à 08:05, Kamil Rytarowski
a écrit :<br>
</div>
<blockquote type="cite"
cite="mid:20180523060501.971997A1DB@mollari.NetBSD.org">
<pre wrap="">The following reply was made to PR pkg/53240; it has been noted by GNATS.
From: Kamil Rytarowski <a class="moz-txt-link-rfc2396E" href="mailto:n54@gmx.com"><n54@gmx.com></a>
To: <a class="moz-txt-link-abbreviated" href="mailto:gnats-bugs@NetBSD.org">gnats-bugs@NetBSD.org</a>
Cc:
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Wed, 23 May 2018 08:03:00 +0200
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M
Content-Type: multipart/mixed; boundary="Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts";
protected-headers="v1"
From: Kamil Rytarowski <a class="moz-txt-link-rfc2396E" href="mailto:n54@gmx.com"><n54@gmx.com></a>
To: <a class="moz-txt-link-abbreviated" href="mailto:gnats-bugs@NetBSD.org">gnats-bugs@NetBSD.org</a>
Message-ID: <a class="moz-txt-link-rfc2396E" href="mailto:777622d4-ecc7-21ae-cb0a-25fe5da48ac4@gmx.com"><777622d4-ecc7-21ae-cb0a-25fe5da48ac4@gmx.com></a>
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
References: <a class="moz-txt-link-rfc2396E" href="mailto:20180522234116.GA21971@nyx.net"><20180522234116.GA21971@nyx.net></a>
In-Reply-To: <a class="moz-txt-link-rfc2396E" href="mailto:20180522234116.GA21971@nyx.net"><20180522234116.GA21971@nyx.net></a>
--Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 23.05.2018 01:41, Roy Bixler wrote:
> On Tue, 22 May 2018 14:02:54 +0200, Joerg Sonnenberger wrote:
>> The patch is just wrong.
>=20
> That's unfortunate, but I'm not surprised. After all, I don't know
> how to test whether it works and I had no prior confirmation that it
> was supposed to work. It did make vlc buildable for me. I also
> mentioned another possible patch from
>=20
> <a class="moz-txt-link-freetext" href="https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html">https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html</a>
>=20
> I'll repeat it here:
>=20
> --- modules/codec/x264.c.orig 2015-04-13 19:54:35.000000000 +0000
> +++ modules/codec/x264.c
> @@ -843,7 +843,7 @@ static int Open ( vlc_object_t *p_this=20
> fullrange =3D var_GetBool( p_enc, SOUT_CFG_PREFIX "fullrange" );
> p_enc->fmt_in.i_codec =3D fullrange ? VLC_CODEC_J420 : VLC_CODEC_I=
420;
> p_sys->i_colorspace =3D X264_CSP_I420;
> -#if X264_BUILD >=3D 118
> +#if X264_BUILD >=3D 118 && X264_BUILD < 155
> char *psz_profile =3D var_GetString( p_enc, SOUT_CFG_PREFIX "profi=
le" );
> if( psz_profile )
> {
>=20
> This is much simpler. Is it also wrong? If so, do you have an
> alternative?
>=20
This approach was rejected upstream so it's presumably wrong.
Can you use VLC 3.x? It's in pkgsrc/wip/vlc.
It crashes for me due to X issues, but it might works for you.
--Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts--
--zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJABAEBCAAqFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAlsFBBQMHG41NEBnbXgu
Y29tAAoJEEuzCOmwLnZsPpEP/RoH3vo7EYNj8x0lzAbSrxGO0nFfy41nb8PdmEAb
J1vm2wgSJMGSB8gEsIdTgkUPUsmGO4vXbdgztmLFGbzc5VmtxtvsXa0cx1OPwfjA
5Rrhk6Mti461AokqbbWvKCxuNfkVb5L83JL61Vd0aR0KcEHibFT7wsWcYZZksCmi
sXqcdKiodvn5ctujNpisDbqStJC1IsPFwtN3A6FLYZhfvdWgD6IBCDuypCjC7YHs
7PJSkGWabDoPydajUBMMQDYBM6WXW0eOn+K2XXj8q5Dt5UG5PN78x51ln+z/LQQb
ke42Zaubat19dGL4JZUfD2Qoqb9FI4kAtKcQMtXK5KXfCapsgHCcarsZG8vf7LgG
Vc+ukU8EAUk3K0kc0bBWlkoi0vuviJQuEXNScVd6M2L6yLjoga5Kh1oK6vzUAqlI
MGDf11U/Cq8POAeu+TmaeLURWvdbhxJMbgYv1K0r2GGKkaLrcsJYqsGxhVtC/Xr5
LWwBhhppMdb0GDsgTaWAewnGdNq+n9X/okqJAjmJfBL1S4ZmNoj4S8XRSqI9RZGM
W82F/ps0z2YjN2kxgTqlxXLFDro6YNVLsvFr4vycF5ZS+ZJCiOdVcLoN6CkFLg6f
+Ta8PMbmKHMpQ4Zwt0lY7n83bEooWKBXIDVeT6IP+8wGzQcR1EJdbDhN/q8XJITR
aDPT
=wqDK
-----END PGP SIGNATURE-----
--zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M--
</pre>
</blockquote>
<br>
</body>
</html>
--------------D720CF68A852AB9994793C61--
From: Kamil Rytarowski <n54@gmx.com>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Thu, 24 May 2018 10:59:42 +0200
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--OVLIq1FDhoi9khGcGNxgrkOTFXvv5048H
Content-Type: multipart/mixed; boundary="ECURXoetSnvDLXNaspqJSpWXE4vYchny3";
protected-headers="v1"
From: Kamil Rytarowski <n54@gmx.com>
To: gnats-bugs@NetBSD.org
Message-ID: <10f40a19-8c40-8f16-5b2a-6dc3bc0b0404@gmx.com>
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
References: <pr-pkg-53240@gnats.netbsd.org>
<20180430193942.35A057A214@mollari.NetBSD.org>
<20180523172501.6D6FD7A21F@mollari.NetBSD.org>
In-Reply-To: <20180523172501.6D6FD7A21F@mollari.NetBSD.org>
--ECURXoetSnvDLXNaspqJSpWXE4vYchny3
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 23.05.2018 19:25, Mickael Viey wrote:
> Is it possible to build VLC 3.xx from 2018Q1 ??
> =20
I think so.
http://pkgsrc.org/wip
--ECURXoetSnvDLXNaspqJSpWXE4vYchny3--
--OVLIq1FDhoi9khGcGNxgrkOTFXvv5048H
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJABAEBCAAqFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAlsGfv4MHG41NEBnbXgu
Y29tAAoJEEuzCOmwLnZsA5AP/3e41pD1gZ8za5KmHgqNEz3Ff2BrVl2/giqWtNSk
V7E3jA3smD96grvndjc+2IHbFuM/fP/t/+YQrauLUZcoTqKxmbxoiUXgb57/Sldt
wrTSfggqXxMh4OwB2IVPaes6xDSgjG+fve06ZDF3AwTfmlkb5+o9GC8eKR1OcDaA
KF0HOF6u/Ir5gosCMQkNl3OOhQ9aUjvH+npMi9StVoaR5cVEJumoCzyrlSLws7t9
GtNtS7gBID0U6+qXL5D7714VPBofrk3pFye1pZKJY+OIopSJ0C4E1uZIAJslZKCR
iBq+BG0llalWKo1xHt68Twn+gnEC3hVviguVbeQTOhLEXfmYc0t7e1qnZLhLnWIR
0omdVl1w36T86Xhpj0rCKc2geY2oVlpz2P+xLT0pBtz3A8NA6LPJBz/PEpJz5xb1
37hLOckukhQEu1j5JOBx5TYU3nAXAShH/IWbgCwhYfxtXyMcFG5Lkn1EK7vpJdqH
nrfwOakSAYS/NTHdd9d57UFXBsn7iwcKDZkDDX+7/eFgWHNIxUZ8VHO8n3PpOZoY
54bfT7dbcCKrr2vhMV1kTcGTVLkMqHSl7I4u3sKc7Fow34XA14yLlYM8vrLrr5e0
LoFTt0MwWblw5zC2XImkqdWA1rD5vY8R29dsK7SC4H3vrwBuMfQwTbuAoRjC3YWh
66FQ
=t1hy
-----END PGP SIGNATURE-----
--OVLIq1FDhoi9khGcGNxgrkOTFXvv5048H--
From: "John D. Baker" <jdbaker@mylinuxisp.com>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Sat, 30 Jun 2018 19:13:31 -0500 (CDT)
As of pkgsrc-HEAD in the freeze before pkgsrc-2018Q2, the problem
described in this PR persists.
There was a suggestion to try building VLC 3.0.x from the pkgsrc-wip
project ("wip/vlc"), but recent updates to qt5 cause building "wip/vlc"
to fail. "wip/vlc-git" seems not to be fetchable (metadata only).
--
|/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com OpenBSD FreeBSD
| X No HTML/proprietary data in email. BSD just sits there and works!
|/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645
State-Changed-From-To: open->closed
State-Changed-By: nia@NetBSD.org
State-Changed-When: Thu, 14 Jan 2021 12:47:22 +0000
State-Changed-Why:
VLC was updated to a much more recent version that now cleanly builds on
all supported NetBSD versions.
Sorry your bug wasn't dealt with quickly at the time.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home