NetBSD Problem Report #53407

From www@NetBSD.org  Wed Jun 27 18:00:05 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EEFA67A1F7
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 27 Jun 2018 18:00:04 +0000 (UTC)
Message-Id: <20180627180002.E579D7A222@mollari.NetBSD.org>
Date: Wed, 27 Jun 2018 18:00:02 +0000 (UTC)
From: jdbaker@mylinuxisp.com
Reply-To: jdbaker@consolidated.net
To: gnats-bugs@NetBSD.org
Subject: netatalk22 does not build with OpenSSL v1.1.x in -current
X-Send-Pr-Version: www-1.0

>Number:         53407
>Notify-List:    jdbaker@consolidated.net
>Category:       pkg
>Synopsis:       netatalk22 does not build with OpenSSL v1.1.x in -current
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    markd
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 27 18:05:00 +0000 2018
>Closed-Date:    Sun Jun 09 00:51:13 +0000 2019
>Last-Modified:  Sun Jun 09 00:51:13 +0000 2019
>Originator:     John D. Baker
>Release:        NetBSD/sparc-8.99.21, pkgsrc-HEAD (pre-pkgsrc-2018Q2)
>Organization:
>Environment:
NetBSD david.technoskunk.fur 8.99.21 NetBSD 8.99.21 (DAVID) #25: Tue Jun 26 13:37:45 CDT 2018  sysop@plex760.technoskunk.fur:/r0/build/current/obj/sparc/sys/arch/sparc/compile/DAVID sparc
>Description:
Since the import of OpenSSL v1.1.x to NetBSD-current, netatalk22 builds
fail:

[...]
/bin/sh ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..   -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/db5 -I/usr/include/openssl -I/usr/pkg/include -I../../sys/netbsd -I../../include -D_U_="__attribute__((unused))" -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/db5 -I../../sys -MT uams_randnum.lo -MD -MP -MF .deps/uams_randnum.Tpo -c -o uams_randnum.lo uams_randnum.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I/var/tmp/pkgsrc/net/netatalk22/work/.buildlink/include -I/var/tmp/pkgsrc/net/netatalk22/work/.buildlink/include/db5 -I/usr/include/openssl -I../../sys/netbsd -I../../include "-D_U_=__attribute__((unused))" -O2 -D_FORTIFY_SOURCE=2 -I../../sys -MT uams_randnum.lo -MD -MP -MF .deps/uams_randnum.Tpo -c uams_randnum.c  -fPIC -DPIC -o .libs/uams_randnum.o
uams_randnum.c:58:8: error: unknown type name 'C_Block'
 static C_Block  seskey;
        ^~~~~~~
uams_randnum.c:59:8: error: unknown type name 'Key_schedule'
 static Key_schedule seskeysched;
        ^~~~~~~~~~~~
uams_randnum.c: In function 'afppasswd':
uams_randnum.c:149:3: error: unknown type name 'Key_schedule'
   Key_schedule schedule;
   ^~~~~~~~~~~~
uams_randnum.c:206:7: warning: implicit declaration of function 'key_sched' [-Wimplicit-function-declaration]
       key_sched((C_Block *) key, schedule);
       ^~~~~~~~~
uams_randnum.c:206:18: error: 'C_Block' undeclared (first use in this function)
       key_sched((C_Block *) key, schedule);
                  ^~~~~~~
uams_randnum.c:206:18: note: each undeclared identifier is reported only once for each function it appears in
uams_randnum.c:206:27: error: expected expression before ')' token
       key_sched((C_Block *) key, schedule);
                           ^
uams_randnum.c:212:2: warning: implicit declaration of function 'ecb_encrypt' [-Wimplicit-function-declaration]
  ecb_encrypt((C_Block *) passwd, (C_Block *) passwd, schedule,
  ^~~~~~~~~~~
uams_randnum.c:212:24: error: expected expression before ')' token
  ecb_encrypt((C_Block *) passwd, (C_Block *) passwd, schedule,
                        ^
uams_randnum.c:216:24: error: expected expression before ')' token
  ecb_encrypt((C_Block *) p, (C_Block *) p, schedule, DES_DECRYPT);
                        ^
uams_randnum.c: In function 'rand_login':
uams_randnum.c:324:44: warning: passing argument 3 of 'randpass' makes pointer from integer without a cast [-Wint-conversion]
   if ((err = randpass(randpwd, passwdfile, seskey,
                                            ^~~~~~
uams_randnum.c:262:12: note: expected 'unsigned char *' but argument is of type 'int'
 static int randpass(const struct passwd *pwd, const char *file,
            ^~~~~~~~
uams_randnum.c: In function 'randnum_logincont':
uams_randnum.c:365:14: error: 'C_Block' undeclared (first use in this function)
   key_sched((C_Block *) seskey, seskeysched);
              ^~~~~~~
uams_randnum.c:365:23: error: expected expression before ')' token
   key_sched((C_Block *) seskey, seskeysched);
                       ^
In file included from /usr/include/ssp/stdio.h:34:0,
                 from /usr/include/stdio.h:597,
                 from uams_randnum.c:13:
uams_randnum.c:366:10: warning: passing argument 1 of '__builtin_object_size' makes pointer from integer without a cast [-Wint-conversion]
   memset(seskey, 0, sizeof(seskey));
          ^
uams_randnum.c:366:10: note: expected 'const void *' but argument is of type 'int'
uams_randnum.c:366:10: warning: passing argument 1 of '__builtin_object_size' makes pointer from integer without a cast [-Wint-conversion]
   memset(seskey, 0, sizeof(seskey));
          ^
uams_randnum.c:366:10: note: expected 'const void *' but argument is of type 'int'
In file included from /usr/include/string.h:127:0,
                 from uams_randnum.c:18:
uams_randnum.c:366:10: warning: passing argument 1 of '__builtin___memset_chk' makes pointer from integer without a cast [-Wint-conversion]
   memset(seskey, 0, sizeof(seskey));
          ^
uams_randnum.c:366:10: note: expected 'void *' but argument is of type 'int'
uams_randnum.c:366:10: warning: passing argument 1 of '__memset_ichk' makes pointer from integer without a cast [-Wint-conversion]
   memset(seskey, 0, sizeof(seskey));
          ^
/usr/include/ssp/string.h:84:1: note: expected 'void *' but argument is of type 'int'
 __ssp_bos_icheck3(memset, void *, int)
 ^
uams_randnum.c:367:25: error: expected expression before ')' token
   ecb_encrypt((C_Block *) randbuf, (C_Block *) randbuf,
                         ^
uams_randnum.c: In function 'rand2num_logincont':
uams_randnum.c:406:11: error: subscripted value is neither array nor pointer nor vector
     seskey[i] <<= 1;
           ^
uams_randnum.c:409:14: error: 'C_Block' undeclared (first use in this function)
   key_sched((C_Block *) seskey, seskeysched);
              ^~~~~~~
uams_randnum.c:409:23: error: expected expression before ')' token
   key_sched((C_Block *) seskey, seskeysched);
                       ^
In file included from /usr/include/ssp/stdio.h:34:0,
                 from /usr/include/stdio.h:597,
                 from uams_randnum.c:13:
uams_randnum.c:410:10: warning: passing argument 1 of '__builtin_object_size' makes pointer from integer without a cast [-Wint-conversion]
   memset(seskey, 0, sizeof(seskey));
          ^
uams_randnum.c:410:10: note: expected 'const void *' but argument is of type 'int'
uams_randnum.c:410:10: warning: passing argument 1 of '__builtin_object_size' makes pointer from integer without a cast [-Wint-conversion]
   memset(seskey, 0, sizeof(seskey));
          ^
uams_randnum.c:410:10: note: expected 'const void *' but argument is of type 'int'
In file included from /usr/include/string.h:127:0,
                 from uams_randnum.c:18:
uams_randnum.c:410:10: warning: passing argument 1 of '__builtin___memset_chk' makes pointer from integer without a cast [-Wint-conversion]
   memset(seskey, 0, sizeof(seskey));
          ^
uams_randnum.c:410:10: note: expected 'void *' but argument is of type 'int'
uams_randnum.c:410:10: warning: passing argument 1 of '__memset_ichk' makes pointer from integer without a cast [-Wint-conversion]
   memset(seskey, 0, sizeof(seskey));
          ^
/usr/include/ssp/string.h:84:1: note: expected 'void *' but argument is of type 'int'
 __ssp_bos_icheck3(memset, void *, int)
 ^
uams_randnum.c:411:26: error: expected expression before ')' token
   ecb_encrypt( (C_Block *) randbuf, (C_Block *) randbuf,
                          ^
uams_randnum.c:424:26: error: expected expression before ')' token
   ecb_encrypt( (C_Block *) ibuf, (C_Block *) rbuf,
                          ^
uams_randnum.c: In function 'randnum_changepw':
uams_randnum.c:455:42: warning: passing argument 3 of 'randpass' makes pointer from integer without a cast [-Wint-conversion]
     if ((err = randpass(pwd, passwdfile, seskey,
                                          ^~~~~~
uams_randnum.c:262:12: note: expected 'unsigned char *' but argument is of type 'int'
 static int randpass(const struct passwd *pwd, const char *file,
            ^~~~~~~~
uams_randnum.c:460:16: error: 'C_Block' undeclared (first use in this function)
     key_sched((C_Block *) seskey, seskeysched);
                ^~~~~~~
uams_randnum.c:460:25: error: expected expression before ')' token
     key_sched((C_Block *) seskey, seskeysched);
                         ^
uams_randnum.c:463:28: error: expected expression before ')' token
     ecb_encrypt( (C_Block *) ibuf, (C_Block *) ibuf, seskeysched, DES_DECRYPT);
                            ^
uams_randnum.c:466:25: error: expected expression before ')' token
     key_sched((C_Block *) ibuf, seskeysched);
                         ^
uams_randnum.c:468:27: error: expected expression before ')' token
     ecb_encrypt((C_Block *) ibuf, (C_Block *) ibuf, seskeysched, DES_DECRYPT);
                           ^
uams_randnum.c:469:16: warning: passing argument 1 of 'memcmp' makes pointer from integer without a cast [-Wint-conversion]
     if (memcmp(seskey, ibuf, sizeof(seskey)))
                ^~~~~~
In file included from uams_randnum.c:18:0:
/usr/include/string.h:50:6: note: expected 'const void *' but argument is of type 'int'
 int  memcmp(const void *, const void *, size_t);
      ^~~~~~
uams_randnum.c:471:21: warning: passing argument 1 of 'memcmp' makes pointer from integer without a cast [-Wint-conversion]
     else if (memcmp(seskey, ibuf + PASSWDLEN, sizeof(seskey)) == 0)
                     ^~~~~~
In file included from uams_randnum.c:18:0:
/usr/include/string.h:50:6: note: expected 'const void *' but argument is of type 'int'
 int  memcmp(const void *, const void *, size_t);
      ^~~~~~
In file included from /usr/include/ssp/stdio.h:34:0,
                 from /usr/include/stdio.h:597,
                 from uams_randnum.c:13:
uams_randnum.c:483:12: warning: passing argument 1 of '__builtin_object_size' makes pointer from integer without a cast [-Wint-conversion]
     memset(seskey, 0, sizeof(seskey));
            ^
uams_randnum.c:483:12: note: expected 'const void *' but argument is of type 'int'
uams_randnum.c:483:12: warning: passing argument 1 of '__builtin_object_size' makes pointer from integer without a cast [-Wint-conversion]
     memset(seskey, 0, sizeof(seskey));
            ^
uams_randnum.c:483:12: note: expected 'const void *' but argument is of type 'int'
In file included from /usr/include/string.h:127:0,
                 from uams_randnum.c:18:
uams_randnum.c:483:12: warning: passing argument 1 of '__builtin___memset_chk' makes pointer from integer without a cast [-Wint-conversion]
     memset(seskey, 0, sizeof(seskey));
            ^
uams_randnum.c:483:12: note: expected 'void *' but argument is of type 'int'
uams_randnum.c:483:12: warning: passing argument 1 of '__memset_ichk' makes pointer from integer without a cast [-Wint-conversion]
     memset(seskey, 0, sizeof(seskey));
            ^
/usr/include/ssp/string.h:84:1: note: expected 'void *' but argument is of type 'int'
 __ssp_bos_icheck3(memset, void *, int)
 ^
Makefile:758: recipe for target 'uams_randnum.lo' failed
[...]

Similar failures observed in bulk-build reports:

  http://mail-index.netbsd.org/pkgsrc-bulk/2018/06/05/msg016020.html
  http://mail-index.netbsd.org/pkgsrc-bulk/2018/06/23/msg016088.html

>How-To-Repeat:
Attempt to build "net/netatalk22" on -current (8.99.x) after the import
of OpenSSL v1.1.x
>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->markd
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sun, 08 Jul 2018 10:21:48 +0000
Responsible-Changed-Why:
Over to maintainer.


From: "Robert Swindells" <rjs@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53407 CVS commit: pkgsrc/net/netatalk22
Date: Sun, 2 Jun 2019 20:03:32 +0000

 Module Name:	pkgsrc
 Committed By:	rjs
 Date:		Sun Jun  2 20:03:32 UTC 2019

 Modified Files:
 	pkgsrc/net/netatalk22: Makefile distinfo
 Added Files:
 	pkgsrc/net/netatalk22/patches: patch-etc_uams_uams__dhx__pam.c
 	    patch-etc_uams_uams__dhx__passwd.c patch-etc_uams_uams__randnum.c

 Log Message:
 Update for new openssl API.

 Should fix PR pkg/53407.


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 pkgsrc/net/netatalk22/Makefile
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/net/netatalk22/distinfo
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/net/netatalk22/patches/patch-etc_uams_uams__dhx__pam.c \
     pkgsrc/net/netatalk22/patches/patch-etc_uams_uams__dhx__passwd.c \
     pkgsrc/net/netatalk22/patches/patch-etc_uams_uams__randnum.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 07 Jun 2019 18:01:11 +0000
State-Changed-Why:
Fixed?


From: "John D. Baker" <jdbaker@consolidated.net>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/53407 (netatalk22 does not build with OpenSSL v1.1.x in
 -current)
Date: Sat, 8 Jun 2019 07:27:39 -0500 (CDT)

 On Fri, 7 Jun 2019, dholland@NetBSD.org wrote:

 > Synopsis: netatalk22 does not build with OpenSSL v1.1.x in -current
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: dholland@NetBSD.org
 > State-Changed-When: Fri, 07 Jun 2019 18:01:11 +0000
 > State-Changed-Why:
 > Fixed?

 Yes.  netatalk22 now builds on -current.  Thanks.

 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645

State-Changed-From-To: feedback->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 09 Jun 2019 00:51:13 +0000
State-Changed-Why:
Fixed by rjs. Thanks.


>Unformatted:

Home	PR Database Search