NetBSD Problem Report #53436

From tsutsui@ceres.dti.ne.jp  Mon Jul  9 15:00:25 2018
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D420D7A159
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  9 Jul 2018 15:00:25 +0000 (UTC)
Message-Id: <201807091500.w69F0K4B027254@ceres.dti.ne.jp>
Date: Tue, 10 Jul 2018 00:00:20 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: firefox 61.0.1 build failure on NetBSD/i386 8.0_RC2
X-Send-Pr-Version: 3.95

>Number:         53436
>Category:       pkg
>Synopsis:       firefox 61.0.1 build failure on NetBSD/i386 8.0_RC2
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 09 15:05:00 +0000 2018
>Closed-Date:    Fri Jul 20 12:11:54 +0000 2018
>Last-Modified:  Fri Jul 20 12:11:54 +0000 2018
>Originator:     Izumi Tsutsui
>Release:        NetBSD 8.0_RC2 + pkgsrc-2018Q2 + firefox 61.0.1 changes
>Organization:
>Environment:
System: NetBSD mirage 8.0_RC2 NetBSD 8.0_RC2 (GENERIC) #0: Mon Jun 25 13:01:26 UTC 2018 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
I've tried to build firefox 61.0.1 on NetBSD/i386 8.0_RC2,
but it fails due to "undefined reference to `__stack_chk_fail_local'"
errors:
---
libmozavutil.so
rm -f libmozavutil.so
/s/obj.i386/pkgsrc/www/firefox/work.i386/.cwrapper/bin/gcc -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/include/glib/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg3 -I/usr/X11R7/include/freetype2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -O2 -I/usr/pkg/include/nspr -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/include/glib/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg3 -I/usr/X11R7/include/free!
 type2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -Dunix -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -I/usr/pkg/include -O2 -fomit-frame-pointer -fPIC -DPIC -shared -Wl,--gc-sections -Wl,-soname,libmozavutil.so -o libmozavutil.so atomic.o avstring.o bprint.o buffer.o channel_layout.o cpu.o crc.o dict.o dummy_funcs.o error.o eval.o fifo.o fixed_dsp.o float_dsp.o frame.o imgutils.o log.o log2_tab.o mathematics.o mem.o opt.o parseutils.o pixdesc.o rational.o reverse.o samplefmt.o slicethread.o time.o utils.o  -lpthread -Wl,-R/usr/pkg/lib/firefox -Wl,-R/usr/pkg/lib -L/usr/pkg/gcc6/lib/gcc/i486--netbsdelf/6.4.0 -Wl,-R/usr/pkg/gcc6/lib/gcc/i486--netbsdelf/6.4.0 -L/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -L/usr/pkg/lib/nspr -Wl,-R/usr/pkg/lib/nspr -L/usr/pkg/lib/nss -Wl,-R/usr/pkg/lib/nss -L/usr/X11R7/lib -Wl,-R/usr/X11R7/lib -L/usr/pkg/lib/ffmpeg3 -Wl,-R/usr/pkg/lib/ffmpeg3 -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,--build-id -Wl,-rpath-l!
 ink,/s/obj.i386/pkgsrc/www/firefox/work.i386/build/dist/bin -W!
 l,-rpath-link,/usr/pkg/lib      -Wl,--version-script,libmozavutil.so.symbols   -lm
avstring.o: In function `av_escape':
avstring.c:(.text.av_escape+0xc6): undefined reference to `__stack_chk_fail_local'
bprint.o: In function `av_bprint_strftime':
bprint.c:(.text.av_bprint_strftime+0x293): undefined reference to `__stack_chk_fail_local'
channel_layout.o: In function `av_get_channel_layout_string':
channel_layout.c:(.text.av_get_channel_layout_string+0x80): undefined reference to `__stack_chk_fail_local'
dict.o: In function `av_dict_set_int':
dict.c:(.text.av_dict_set_int+0x74): undefined reference to `__stack_chk_fail_local'
dict.o: In function `av_dict_get_string':
dict.c:(.text.av_dict_get_string+0x1df): undefined reference to `__stack_chk_fail_local'
log.o:log.c:(.text.av_log_default_callback+0x3d8): more undefined references to `__stack_chk_fail_local' follow
collect2: error: ld returned 1 exit status
/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-61.0.1/config/rules.mk:679: recipe for target 'libmozavutil.so' failed
gmake[3]: *** [libmozavutil.so] Error 1
gmake[3]: Leaving directory '/s/obj.i386/pkgsrc/www/firefox/work.i386/build/media/ffvpx/libavutil'
/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-61.0.1/config/recurse.mk:73: recipe for target 'media/ffvpx/libavutil/target' failed
gmake[2]: *** [media/ffvpx/libavutil/target] Error 2
gmake[2]: *** Waiting for unfinished jobs....
---

Note on NetBSD/amd64 8.0_RC2 there is no error during build from
the same sources.

Note gcc6 already has the following change which was necessary
for gcc48:
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/gcc48/patches/patch-gcc_configure#rev1.4

>How-To-Repeat:
build pkgsrc/www/firefox on NetBSD/i386 8.0_RC2.

>Fix:
No idea.

I wonder if there is an i386 specific -fstack-protector problem,
especially in the following function in gcc-6.4.0/gcc/config/i386/i386.c:

---
/* For 32-bit code we can save PIC register setup by using
   __stack_chk_fail_local hidden function instead of calling
   __stack_chk_fail directly.  64-bit code doesn't need to setup any PIC
   register, so it is better to call __stack_chk_fail directly.  */

static tree ATTRIBUTE_UNUSED
ix86_stack_protect_fail (void)
{
  return TARGET_64BIT
         ? default_external_stack_protect_fail ()
         : default_hidden_stack_protect_fail ();
}
---

>Release-Note:

>Audit-Trail:
From: Jonathan Perkin <jperkin@joyent.com>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53436: firefox 61.0.1 build failure on NetBSD/i386 8.0_RC2
Date: Mon, 9 Jul 2018 16:09:46 +0100

 * On 2018-07-09 at 16:05 BST, Izumi Tsutsui wrote:

 > I wonder if there is an i386 specific -fstack-protector problem,
 > especially in the following function in gcc-6.4.0/gcc/config/i386/i386.c:
 > 
 > ---
 > /* For 32-bit code we can save PIC register setup by using
 >    __stack_chk_fail_local hidden function instead of calling
 >    __stack_chk_fail directly.  64-bit code doesn't need to setup any PIC
 >    register, so it is better to call __stack_chk_fail directly.  */
 > 
 > static tree ATTRIBUTE_UNUSED
 > ix86_stack_protect_fail (void)
 > {
 >   return TARGET_64BIT
 >          ? default_external_stack_protect_fail ()
 >          : default_hidden_stack_protect_fail ();
 > }

 We used to see something similar on SunOS where i386 had stack
 protector issues whereas x86_64 was fine, until I applied this patch:

   https://github.com/joyent/pkgsrc/commit/10aee3e4aef98c2bd8512ef4cb4278d0c7102d13#diff-88dca29c55d4e66af367aeefadf55a7a

 Something similar might help you too.

 -- 
 Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@NetBSD.org
Cc: jperkin@joyent.com, tsutsui@ceres.dti.ne.jp
Subject: Re: pkg/53436: firefox 61.0.1 build failure on NetBSD/i386 8.0_RC2
Date: Tue, 10 Jul 2018 00:38:49 +0900

 >  We used to see something similar on SunOS where i386 had stack
 >  protector issues whereas x86_64 was fine, until I applied this patch:
 >  
 >    https://github.com/joyent/pkgsrc/commit/10aee3e4aef98c2bd8512ef4cb4278d0c7102d13#diff-88dca29c55d4e66af367aeefadf55a7a
 >  
 >  Something similar might help you too.

 Thanks.

 I guess the following change pulled from NetBSD tree is more essencial:
  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/gcc49/patches/patch-gcc_targhooks.c?rev=1.1&content-type=text/x-cvsweb-markup

 I'll apply it to gcc6 too.

 ---

 Note the following change also fixes the problem:

 $NetBSD$

 --- gcc/config/i386/i386.c.orig	2017-05-05 21:51:14.000000000 +0000
 +++ gcc/config/i386/i386.c
 @@ -48372,9 +48372,13 @@ ix86_mangle_type (const_tree type)
  static tree ATTRIBUTE_UNUSED
  ix86_stack_protect_fail (void)
  {
 +#if 0
    return TARGET_64BIT
  	 ? default_external_stack_protect_fail ()
  	 : default_hidden_stack_protect_fail ();
 +#else
 +  return default_external_stack_protect_fail ();
 +#endif
  }

  /* Select a format to encode pointers in exception handling data.  CODE

 ---
 Izumi Tsutsui

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@NetBSD.org
Cc: jperkin@joyent.com, tsutsui@ceres.dti.ne.jp
Subject: Re: pkg/53436: firefox 61.0.1 build failure on NetBSD/i386 8.0_RC2
Date: Wed, 11 Jul 2018 00:45:43 +0900

 > I guess the following change pulled from NetBSD tree is more essencial:
 >  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/gcc49/patches/patch-gcc_targhooks.c?rev=1.1&content-type=text/x-cvsweb-markup
 > 
 > I'll apply it to gcc6 too.

 This change also works around.
 (i.e. firefox 61.0.1 now works)

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53436 CVS commit: pkgsrc/lang
Date: Wed, 18 Jul 2018 22:35:44 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Wed Jul 18 22:35:44 UTC 2018

 Modified Files:
 	pkgsrc/lang/gcc6: Makefile distinfo
 	pkgsrc/lang/gcc6-libs: Makefile
 Added Files:
 	pkgsrc/lang/gcc6/patches: patch-gcc_targhooks.c

 Log Message:
 gcc6: don't try to make references to stack_chk_fail_local on netbsd/sun
 sun was added as joyent is patching for the same.

 this code is only reached if compiling for i386 (or some variation of ppc)
 netbsd's stack_chk_fail_local won't work for this.

 PR pkg/53436.


 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/lang/gcc6/Makefile
 cvs rdiff -u -r1.10 -r1.11 pkgsrc/lang/gcc6/distinfo
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/lang/gcc6-libs/Makefile
 cvs rdiff -u -r0 -r1.1 pkgsrc/lang/gcc6/patches/patch-gcc_targhooks.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53436 CVS commit: pkgsrc/lang
Date: Wed, 18 Jul 2018 22:42:57 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Wed Jul 18 22:42:57 UTC 2018

 Modified Files:
 	pkgsrc/lang/gcc5: Makefile distinfo
 	pkgsrc/lang/gcc5-libs: Makefile
 Added Files:
 	pkgsrc/lang/gcc5/patches: patch-gcc_targhooks.c

 Log Message:
 gcc5: don't try to make references to stack_chk_fail_local on netbsd/sun
 sun was added as joyent is patching for the same.

 this code is only reached if compiling for i386 (or some variation of ppc)
 netbsd's stack_chk_fail_local won't work for this.

 PR pkg/53436


 To generate a diff of this commit:
 cvs rdiff -u -r1.28 -r1.29 pkgsrc/lang/gcc5/Makefile
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/lang/gcc5/distinfo
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/lang/gcc5-libs/Makefile
 cvs rdiff -u -r0 -r1.1 pkgsrc/lang/gcc5/patches/patch-gcc_targhooks.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53436 CVS commit: pkgsrc/lang
Date: Wed, 18 Jul 2018 22:55:08 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Wed Jul 18 22:55:08 UTC 2018

 Modified Files:
 	pkgsrc/lang/gcc7: Makefile distinfo
 	pkgsrc/lang/gcc7-libs: Makefile
 Added Files:
 	pkgsrc/lang/gcc7/patches: patch-gcc_targhooks.c

 Log Message:
 gcc7: don't try to make references to stack_chk_fail_local on netbsd/sun
 sun was added as joyent is patching for the same.

 this code is only reached if compiling for i386 (or some variation of ppc)
 netbsd's stack_chk_fail_local won't work for this.

 PR pkg/53436.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/lang/gcc7/Makefile
 cvs rdiff -u -r1.10 -r1.11 pkgsrc/lang/gcc7/distinfo
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/lang/gcc7-libs/Makefile
 cvs rdiff -u -r0 -r1.1 pkgsrc/lang/gcc7/patches/patch-gcc_targhooks.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53436 CVS commit: pkgsrc/lang/gcc8
Date: Wed, 18 Jul 2018 22:56:23 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Wed Jul 18 22:56:23 UTC 2018

 Modified Files:
 	pkgsrc/lang/gcc8: Makefile distinfo
 Added Files:
 	pkgsrc/lang/gcc8/patches: patch-gcc_targhooks.c

 Log Message:
 gcc8: don't try to make references to stack_chk_fail_local on netbsd/sun
 sun was added as joyent is patching for the same.

 this code is only reached if compiling for i386 (or some variation of ppc)
 netbsd's stack_chk_fail_local won't work for this.

 PR pkg/53436.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/lang/gcc8/Makefile pkgsrc/lang/gcc8/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/lang/gcc8/patches/patch-gcc_targhooks.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->pending-pullups
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 18 Jul 2018 23:08:41 +0000
State-Changed-Why:
pullup-pkgsrc 5795


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53436 CVS commit: pkgsrc/lang
Date: Wed, 18 Jul 2018 23:15:42 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Wed Jul 18 23:15:42 UTC 2018

 Modified Files:
 	pkgsrc/lang/gcc48: Makefile distinfo
 	pkgsrc/lang/gcc48-libs: Makefile
 Added Files:
 	pkgsrc/lang/gcc48/patches: patch-gcc_targhooks.c

 Log Message:
 gcc48: don't try to make references to stack_chk_fail_local on netbsd/sun
 sun was added as joyent is patching for the same.

 this code is only reached if compiling for i386 (or some variation of ppc)
 netbsd's stack_chk_fail_local won't work for this.

 bump gcc48-libs PKGREVISION above gcc48

 PR pkg/53436.


 To generate a diff of this commit:
 cvs rdiff -u -r1.40 -r1.41 pkgsrc/lang/gcc48/Makefile
 cvs rdiff -u -r1.37 -r1.38 pkgsrc/lang/gcc48/distinfo
 cvs rdiff -u -r1.28 -r1.29 pkgsrc/lang/gcc48-libs/Makefile
 cvs rdiff -u -r0 -r1.1 pkgsrc/lang/gcc48/patches/patch-gcc_targhooks.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53436 CVS commit: [pkgsrc-2018Q2] pkgsrc/lang
Date: Fri, 20 Jul 2018 12:06:10 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Fri Jul 20 12:06:09 UTC 2018

 Modified Files:
 	pkgsrc/lang/gcc48 [pkgsrc-2018Q2]: Makefile distinfo
 	pkgsrc/lang/gcc48-libs [pkgsrc-2018Q2]: Makefile
 	pkgsrc/lang/gcc5 [pkgsrc-2018Q2]: Makefile distinfo
 	pkgsrc/lang/gcc5-libs [pkgsrc-2018Q2]: Makefile
 	pkgsrc/lang/gcc6 [pkgsrc-2018Q2]: Makefile distinfo
 	pkgsrc/lang/gcc6-libs [pkgsrc-2018Q2]: Makefile
 	pkgsrc/lang/gcc7 [pkgsrc-2018Q2]: Makefile distinfo
 	pkgsrc/lang/gcc7-libs [pkgsrc-2018Q2]: Makefile
 	pkgsrc/lang/gcc8 [pkgsrc-2018Q2]: Makefile distinfo
 Added Files:
 	pkgsrc/lang/gcc48/patches [pkgsrc-2018Q2]: patch-gcc_targhooks.c
 	pkgsrc/lang/gcc5/patches [pkgsrc-2018Q2]: patch-gcc_targhooks.c
 	pkgsrc/lang/gcc6/patches [pkgsrc-2018Q2]: patch-gcc_targhooks.c
 	pkgsrc/lang/gcc7/patches [pkgsrc-2018Q2]: patch-gcc_targhooks.c
 	pkgsrc/lang/gcc8/patches [pkgsrc-2018Q2]: patch-gcc_targhooks.c

 Log Message:
 Pullup ticket #5795 - requested by maya
 lang/gcc48: i386 build fix
 lang/gcc5: i386 build fix
 lang/gcc6: i386 build fix
 lang/gcc7: i386 build fix
 lang/gcc8: i386 build fix

 Revisions pulled up:
 - lang/gcc48-libs/Makefile                                      1.29
 - lang/gcc48/Makefile                                           1.41
 - lang/gcc48/distinfo                                           1.38
 - lang/gcc48/patches/patch-gcc_targhooks.c                      1.1
 - lang/gcc5-libs/Makefile                                       1.13
 - lang/gcc5/Makefile                                            1.29
 - lang/gcc5/distinfo                                            1.19
 - lang/gcc5/patches/patch-gcc_targhooks.c                       1.1
 - lang/gcc6-libs/Makefile                                       1.7
 - lang/gcc6/Makefile                                            1.14
 - lang/gcc6/distinfo                                            1.11
 - lang/gcc6/patches/patch-gcc_targhooks.c                       1.1
 - lang/gcc7-libs/Makefile                                       1.3
 - lang/gcc7/Makefile                                            1.19
 - lang/gcc7/distinfo                                            1.11
 - lang/gcc7/patches/patch-gcc_targhooks.c                       1.1
 - lang/gcc8/Makefile                                            1.2
 - lang/gcc8/distinfo                                            1.2
 - lang/gcc8/patches/patch-gcc_targhooks.c                       1.1

 ---
    Module Name:    pkgsrc
    Committed By:   maya
    Date:           Wed Jul 18 22:42:57 UTC 2018

    Modified Files:
            pkgsrc/lang/gcc5: Makefile distinfo
            pkgsrc/lang/gcc5-libs: Makefile
    Added Files:
            pkgsrc/lang/gcc5/patches: patch-gcc_targhooks.c

    Log Message:
    gcc5: don't try to make references to stack_chk_fail_local on netbsd/sun
    sun was added as joyent is patching for the same.

    this code is only reached if compiling for i386 (or some variation of ppc)
    netbsd's stack_chk_fail_local won't work for this.

    PR pkg/53436

 ---
    Module Name:    pkgsrc
    Committed By:   maya
    Date:           Wed Jul 18 22:35:44 UTC 2018

    Modified Files:
            pkgsrc/lang/gcc6: Makefile distinfo
            pkgsrc/lang/gcc6-libs: Makefile
    Added Files:
            pkgsrc/lang/gcc6/patches: patch-gcc_targhooks.c

    Log Message:
    gcc6: don't try to make references to stack_chk_fail_local on netbsd/sun
    sun was added as joyent is patching for the same.

    this code is only reached if compiling for i386 (or some variation of ppc)
    netbsd's stack_chk_fail_local won't work for this.

    PR pkg/53436.

 ---
    Module Name:    pkgsrc
    Committed By:   maya
    Date:           Wed Jul 18 22:55:08 UTC 2018

    Modified Files:
            pkgsrc/lang/gcc7: Makefile distinfo
            pkgsrc/lang/gcc7-libs: Makefile
    Added Files:
            pkgsrc/lang/gcc7/patches: patch-gcc_targhooks.c

    Log Message:
    gcc7: don't try to make references to stack_chk_fail_local on netbsd/sun
    sun was added as joyent is patching for the same.

    this code is only reached if compiling for i386 (or some variation of ppc)
    netbsd's stack_chk_fail_local won't work for this.

    PR pkg/53436.

 ---
    Module Name:    pkgsrc
    Committed By:   maya
    Date:           Wed Jul 18 22:56:23 UTC 2018

    Modified Files:
            pkgsrc/lang/gcc8: Makefile distinfo
    Added Files:
            pkgsrc/lang/gcc8/patches: patch-gcc_targhooks.c

    Log Message:
    gcc8: don't try to make references to stack_chk_fail_local on netbsd/sun
    sun was added as joyent is patching for the same.

    this code is only reached if compiling for i386 (or some variation of ppc)
    netbsd's stack_chk_fail_local won't work for this.

    PR pkg/53436.

 ---
    Module Name:	pkgsrc
    Committed By:	maya
    Date:		Wed Jul 18 23:15:42 UTC 2018

    Modified Files:
    	pkgsrc/lang/gcc48: Makefile distinfo
    	pkgsrc/lang/gcc48-libs: Makefile
    Added Files:
    	pkgsrc/lang/gcc48/patches: patch-gcc_targhooks.c

    Log Message:
    gcc48: don't try to make references to stack_chk_fail_local on netbsd/sun
    sun was added as joyent is patching for the same.

    this code is only reached if compiling for i386 (or some variation of ppc)
    netbsd's stack_chk_fail_local won't work for this.

    bump gcc48-libs PKGREVISION above gcc48

    PR pkg/53436.


 To generate a diff of this commit:
 cvs rdiff -u -r1.39 -r1.39.4.1 pkgsrc/lang/gcc48/Makefile
 cvs rdiff -u -r1.37 -r1.37.2.1 pkgsrc/lang/gcc48/distinfo
 cvs rdiff -u -r1.28 -r1.28.10.1 pkgsrc/lang/gcc48-libs/Makefile
 cvs rdiff -u -r0 -r1.1.2.2 pkgsrc/lang/gcc48/patches/patch-gcc_targhooks.c
 cvs rdiff -u -r1.27 -r1.27.4.1 pkgsrc/lang/gcc5/Makefile
 cvs rdiff -u -r1.18 -r1.18.6.1 pkgsrc/lang/gcc5/distinfo
 cvs rdiff -u -r1.12 -r1.12.6.1 pkgsrc/lang/gcc5-libs/Makefile
 cvs rdiff -u -r0 -r1.1.2.2 pkgsrc/lang/gcc5/patches/patch-gcc_targhooks.c
 cvs rdiff -u -r1.13 -r1.13.4.1 pkgsrc/lang/gcc6/Makefile
 cvs rdiff -u -r1.10 -r1.10.4.1 pkgsrc/lang/gcc6/distinfo
 cvs rdiff -u -r1.5 -r1.5.10.1 pkgsrc/lang/gcc6-libs/Makefile
 cvs rdiff -u -r0 -r1.1.2.2 pkgsrc/lang/gcc6/patches/patch-gcc_targhooks.c
 cvs rdiff -u -r1.18 -r1.18.2.1 pkgsrc/lang/gcc7/Makefile
 cvs rdiff -u -r1.10 -r1.10.2.1 pkgsrc/lang/gcc7/distinfo
 cvs rdiff -u -r1.2 -r1.2.2.1 pkgsrc/lang/gcc7-libs/Makefile
 cvs rdiff -u -r0 -r1.1.2.2 pkgsrc/lang/gcc7/patches/patch-gcc_targhooks.c
 cvs rdiff -u -r1.1 -r1.1.2.1 pkgsrc/lang/gcc8/Makefile \
     pkgsrc/lang/gcc8/distinfo
 cvs rdiff -u -r0 -r1.1.2.2 pkgsrc/lang/gcc8/patches/patch-gcc_targhooks.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Fri, 20 Jul 2018 12:11:54 +0000
State-Changed-Why:
pullup-pkgsrc #5795


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.