NetBSD Problem Report #53454

From www@NetBSD.org  Mon Jul 16 09:14:47 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 601397A180
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 16 Jul 2018 09:14:47 +0000 (UTC)
Message-Id: <20180716091445.EA92C7A218@mollari.NetBSD.org>
Date: Mon, 16 Jul 2018 09:14:45 +0000 (UTC)
From: mes@yki.jp
Reply-To: mes@yki.jp
To: gnats-bugs@NetBSD.org
Subject: It crushes.
X-Send-Pr-Version: www-1.0

>Number:         53454
>Category:       pkg
>Synopsis:       It crushes.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bsiegert
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 16 09:15:00 +0000 2018
>Closed-Date:    Sun Jul 22 20:36:50 +0000 2018
>Last-Modified:  Sun Jul 22 20:36:50 +0000 2018
>Originator:     M. Meiarashi
>Release:        pkgsrc current
>Organization:
>Environment:
(perl is perl-5.26.2 of pkgsrc)
>Description:
Perl terminates with the following message:
    Can't use 'defined(%hash)' (Maybe you should just omit the defined()?) at /usr/pkg/bin/calamaris line 2609.

According to 
https://perldoc.perl.org/functions/defined.html
it says "Use of defined on aggregates (hashes and arrays) is no longer supported."
>How-To-Repeat:
Just invoke calamaris.
>Fix:
The line 2609 of the script:
  if ( defined(%tcp_content) ) {
should be like
  if ( %tcp_content ) {

>Release-Note:

>Audit-Trail:
From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53454: It crushes.
Date: Tue, 17 Jul 2018 10:00:51 +0200

 That's a bug in the calamaris package itself. Did you report this
 upstream with the devs of calamaris?

 -- 
 Benny

Responsible-Changed-From-To: pkg-manager->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Tue, 17 Jul 2018 19:18:18 +0000
Responsible-Changed-Why:
take


State-Changed-From-To: open->feedback
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Tue, 17 Jul 2018 19:18:18 +0000
State-Changed-Why:
I fixed two instances of this issue in calamaris-2.59nb5.
Does the new version work for you?


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53454 CVS commit: pkgsrc/www/calamaris
Date: Tue, 17 Jul 2018 19:17:17 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Tue Jul 17 19:17:17 UTC 2018

 Modified Files:
 	pkgsrc/www/calamaris: Makefile distinfo
 Added Files:
 	pkgsrc/www/calamaris/patches: patch-calamaris

 Log Message:
 Use of defined on aggregates (hashes and arrays) is no longer supported.

 Fix two instances of this. PR pkg/53454.
 Bump revision.


 To generate a diff of this commit:
 cvs rdiff -u -r1.17 -r1.18 pkgsrc/www/calamaris/Makefile
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/www/calamaris/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/www/calamaris/patches/patch-calamaris

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sun, 22 Jul 2018 20:36:50 +0000
State-Changed-Why:
Confirmed fixed.


>Unformatted:

Home	PR Database Search