NetBSD Problem Report #53461
From www@NetBSD.org Fri Jul 20 06:01:17 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 24D667A157
for <gnats-bugs@gnats.NetBSD.org>; Fri, 20 Jul 2018 06:01:17 +0000 (UTC)
Message-Id: <20180720060115.934737A218@mollari.NetBSD.org>
Date: Fri, 20 Jul 2018 06:01:15 +0000 (UTC)
From: vezhlys@gmail.com
Reply-To: vezhlys@gmail.com
To: gnats-bugs@NetBSD.org
Subject: axen doesn't support D-Link DUB-1312 USB network card
X-Send-Pr-Version: www-1.0
>Number: 53461
>Category: kern
>Synopsis: axen doesn't support D-Link DUB-1312 USB network card
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: martin
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Jul 20 06:05:01 +0000 2018
>Closed-Date: Thu Feb 07 06:28:17 +0000 2019
>Last-Modified: Fri Feb 08 21:55:00 +0000 2019
>Originator: Andrius V
>Release: netbsd-8
>Organization:
>Environment:
>Description:
I bought D-Link DUB-1312 USB network card few days ago and tried it on NetBSD.. Unfortunately, it was unrecognized as a network card. After some investigation I found out that it is based on AX88179 and NetBSD already has driver for it (axen). So I made a patch just by adding it to the list of axen_devs. It was enough to make it work.
P.S. I also checked OpenBSD driver and it has few more devices listed in the driver. Not sure if it can be taken from them.
>How-To-Repeat:
>Fix:
Index: sys/dev/usb/if_axen.c
==================================================================
--- sys/dev/usb/if_axen.c
+++ sys/dev/usb/if_axen.c
@@ -77,11 +77,12 @@
*/
static const struct axen_type axen_devs[] = {
#if 0 /* not tested */
{ { USB_VENDOR_ASIX, USB_PRODUCT_ASIX_AX88178A}, AX178A },
#endif
- { { USB_VENDOR_ASIX, USB_PRODUCT_ASIX_AX88179}, AX179 }
+ { { USB_VENDOR_ASIX, USB_PRODUCT_ASIX_AX88179}, AX179 },
+ { { USB_VENDOR_DLINK, USB_PRODUCT_DLINK_DUB1312}, AX179 }
};
#define axen_lookup(v, p) ((const struct axen_type *)usb_lookup(axen_devs, v, p))
static int axen_match(device_t, cfdata_t, void *);
Index: sys/dev/usb/usbdevs
==================================================================
--- sys/dev/usb/usbdevs
+++ sys/dev/usb/usbdevs
@@ -1365,10 +1365,11 @@
/* D-Link products */
/*product DLINK DSBS25 0x0100 DSB-S25 serial adapter*/
product DLINK DUBE100 0x1a00 10/100 ethernet adapter
product DLINK DUBE100C1 0x1a02 DUB-E100 rev C1
+product DLINK DUB1312 0x4a00 DUB-1312
product DLINK DSB650TX4 0x200c 10/100 ethernet adapter
product DLINK DWL120E 0x3200 DWL-120 rev E
product DLINK DWA130C 0x3301 DWA-130 rev C
product DLINK RTL8192CU_1 0x3307 RTL8192CU
product DLINK RTL8188CU 0x3308 RTL8188CU
>Release-Note:
>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/53461 CVS commit: src/sys/dev/usb
Date: Fri, 20 Jul 2018 16:36:16 +0000
Module Name: src
Committed By: martin
Date: Fri Jul 20 16:36:16 UTC 2018
Modified Files:
src/sys/dev/usb: usbdevs
Log Message:
Andrius V in Pr kern/53461: add D-Link DUB-1312
To generate a diff of this commit:
cvs rdiff -u -r1.752 -r1.753 src/sys/dev/usb/usbdevs
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/53461 CVS commit: src/sys/dev/usb
Date: Fri, 20 Jul 2018 16:38:42 +0000
Module Name: src
Committed By: martin
Date: Fri Jul 20 16:38:42 UTC 2018
Modified Files:
src/sys/dev/usb: if_axen.c
Log Message:
Andrius V in PR kern/53461: add support for D-Link DUB-1312
To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/usb/if_axen.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: kern-bug-people->martin
Responsible-Changed-By: martin@NetBSD.org
Responsible-Changed-When: Fri, 20 Jul 2018 16:43:14 +0000
Responsible-Changed-Why:
Take
State-Changed-From-To: open->needs-pullups
State-Changed-By: martin@NetBSD.org
State-Changed-When: Fri, 20 Jul 2018 16:43:14 +0000
State-Changed-Why:
Will request pullup after testing
From: Andrius V <vezhlys@gmail.com>
To: gnats-bugs@netbsd.org
Cc: Martin Husemann <martin@netbsd.org>, kern-bug-people@netbsd.org, netbsd-bugs@netbsd.org,
gnats-admin@netbsd.org
Subject: Re: kern/53461 (axen doesn't support D-Link DUB-1312 USB network card)
Date: Sat, 21 Jul 2018 01:03:01 +0300
Hi Martin,
Thank you for the very fast commit. Just tested, it works for me:
from dmesg
...
[ 203.930455] axen0: D-Link Elec. Corp. (0x2001) D-Link DUB-1312
(0x4a00), rev 2.10/1.00, addr 2
[ 204.370464] axen0: AX88179
[ 204.370464] axen0: Ethernet address xx:xx:xx:xx:xx:xx
[ 204.370464] rgephy0 at axen0 phy 3: RTL8169S/8110S/8211 1000BASE-T
media interface, rev. 5
[ 204.370464] rgephy0: 10baseT, 10baseT-FDX, 100baseTX,
100baseTX-FDX, 1000baseT-FDX, auto
...
ifconfig
...
axen0: flags=0x8a43<UP,BROADCAST,RUNNING,ALLMULTI,SIMPLEX,MULTICAST> mtu 1500
capabilities=3ff00<IP4CSUM_Rx,IP4CSUM_Tx,TCP4CSUM_Rx,TCP4CSUM_Tx>
capabilities=3ff00<UDP4CSUM_Rx,UDP4CSUM_Tx,TCP6CSUM_Rx,TCP6CSUM_Tx>
capabilities=3ff00<UDP6CSUM_Rx,UDP6CSUM_Tx>
enabled=0
ec_capabilities=1<VLAN_MTU>
ec_enabled=0
address: xx:xx:xx:xx:xx:xx
media: Ethernet autoselect (1000baseT full-duplex)
status: active
...
Best Regards,
Andrius V
On Fri, Jul 20, 2018 at 7:43 PM <martin@netbsd.org> wrote:
>
> Synopsis: axen doesn't support D-Link DUB-1312 USB network card
>
> Responsible-Changed-From-To: kern-bug-people->martin
> Responsible-Changed-By: martin@NetBSD.org
> Responsible-Changed-When: Fri, 20 Jul 2018 16:43:14 +0000
> Responsible-Changed-Why:
> Take
>
>
> State-Changed-From-To: open->needs-pullups
> State-Changed-By: martin@NetBSD.org
> State-Changed-When: Fri, 20 Jul 2018 16:43:14 +0000
> State-Changed-Why:
> Will request pullup after testing
>
>
>
From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/53461 CVS commit: src/share/man/man4
Date: Fri, 27 Jul 2018 19:11:57 +0000
Module Name: src
Committed By: snj
Date: Fri Jul 27 19:11:56 UTC 2018
Modified Files:
src/share/man/man4: axen.4
Log Message:
PR kern/53461: D-Link DUB-1312 is now supported.
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/share/man/man4/axen.4
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Andrius V <vezhlys@gmail.com>
To: gnats-bugs@netbsd.org
Cc: Martin Husemann <martin@netbsd.org>, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: PR/53461 CVS commit: src/share/man/man4
Date: Mon, 10 Sep 2018 14:56:28 +0300
Hi,
Is there any reason why the code related to this PR wasn't pulled up
to netbsd-8 branch yet? Thank you.
Regards,
Andrius V
On Fri, Jul 27, 2018 at 10:15 PM Soren Jacobsen <snj@netbsd.org> wrote:
>
> The following reply was made to PR kern/53461; it has been noted by GNATS.
>
> From: "Soren Jacobsen" <snj@netbsd.org>
> To: gnats-bugs@gnats.NetBSD.org
> Cc:
> Subject: PR/53461 CVS commit: src/share/man/man4
> Date: Fri, 27 Jul 2018 19:11:57 +0000
>
> Module Name: src
> Committed By: snj
> Date: Fri Jul 27 19:11:56 UTC 2018
>
> Modified Files:
> src/share/man/man4: axen.4
>
> Log Message:
> PR kern/53461: D-Link DUB-1312 is now supported.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.6 -r1.7 src/share/man/man4/axen.4
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 05 Feb 2019 10:42:29 +0000
State-Changed-Why:
[pullup-8 #1182]
From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/53461 CVS commit: [netbsd-8] src/sys/dev/usb
Date: Thu, 7 Feb 2019 06:13:26 +0000
Module Name: src
Committed By: msaitoh
Date: Thu Feb 7 06:13:26 UTC 2019
Modified Files:
src/sys/dev/usb [netbsd-8]: usbdevs
Log Message:
Pullup the following revision (requested by martin in ticket #1182):
sys/dev/usb/usbdevs 1.753
Andrius V in Pr kern/53461: add D-Link DUB-1312
To generate a diff of this commit:
cvs rdiff -u -r1.736.2.2 -r1.736.2.3 src/sys/dev/usb/usbdevs
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/53461 CVS commit: [netbsd-8] src
Date: Thu, 7 Feb 2019 06:14:34 +0000
Module Name: src
Committed By: msaitoh
Date: Thu Feb 7 06:14:34 UTC 2019
Modified Files:
src/share/man/man4 [netbsd-8]: axen.4
src/sys/dev/usb [netbsd-8]: if_axen.c
Log Message:
Pullup the following revisions (requested by martin in ticket #1182):
sys/dev/usb/if_axen.c 1.14
share/man/man4/axen.4 1.7
Andrius V in Pr kern/53461: add D-Link DUB-1312
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.6.4.1 src/share/man/man4/axen.4
cvs rdiff -u -r1.11.8.2 -r1.11.8.3 src/sys/dev/usb/if_axen.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: pending-pullups->closed
State-Changed-By: msaitoh@NetBSD.org
State-Changed-When: Thu, 07 Feb 2019 06:28:17 +0000
State-Changed-Why:
Pulled up.
Thanks.
From: Andrius V <vezhlys@gmail.com>
To: gnats-bugs@netbsd.org
Cc: Martin Husemann <martin@netbsd.org>, netbsd-bugs@netbsd.org, gnats-admin@netbsd.org,
msaitoh@netbsd.org
Subject: Re: kern/53461 (axen doesn't support D-Link DUB-1312 USB network card)
Date: Fri, 8 Feb 2019 23:50:53 +0200
Thank you for the pull up.
On Thu, Feb 7, 2019 at 8:28 AM <msaitoh@netbsd.org> wrote:
>
> Synopsis: axen doesn't support D-Link DUB-1312 USB network card
>
> State-Changed-From-To: pending-pullups->closed
> State-Changed-By: msaitoh@NetBSD.org
> State-Changed-When: Thu, 07 Feb 2019 06:28:17 +0000
> State-Changed-Why:
> Pulled up.
> Thanks.
>
>
>
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home