NetBSD Problem Report #53533

From www@NetBSD.org  Fri Aug 17 07:25:00 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id C742B7A157
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 17 Aug 2018 07:24:59 +0000 (UTC)
Message-Id: <20180817072457.AD19F7A26D@mollari.NetBSD.org>
Date: Fri, 17 Aug 2018 07:24:57 +0000 (UTC)
From: liman@cafax.se
Reply-To: liman@cafax.se
To: gnats-bugs@NetBSD.org
Subject: Suggestion: sysupgrade should terminate gracefully on full partitions.
X-Send-Pr-Version: www-1.0

>Number:         53533
>Category:       pkg
>Synopsis:       Suggestion: sysupgrade should terminate gracefully on full partitions.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jmmv
>State:          analyzed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 17 07:25:00 +0000 2018
>Closed-Date:    
>Last-Modified:  Mon Aug 20 00:58:24 +0000 2018
>Originator:     Lars-Johan Liman
>Release:        sysupgrade-1.5nb3
>Organization:
Cafax AB
>Environment:
NetBSD <hostname> 8.0 NetBSD 8.0 (XEN3_DOMU) #0: Tue Jul 17 14:59:51 UTC 2018  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/xen/compile/XEN3_DOMU amd64
>Description:
Sysupgrade is a fantastic tool. but while using sysupgrade-1.5nb3 to upgrade from NetBSD 7.1.2 to 8.0, my /usr partition went through the roof. Fair enogh. It was indeed too small.

The issue is that sysupgrade didn't notice. It just kept trying to pump new files onto the full partition.

I suggest adding more sensitivity to sysupgrade so that it detects a full partition, and aborts gracefully - possibly leavning a status file behind somewhere so it can continue from where it left off when a sysadmin has addressed the issue with the full partition.

Just a thought ...
>How-To-Repeat:
Fill up your /usr partition almost to the brim, then try to use sysupgrade.
>Fix:
Code needs to be added, I suppose.

>Release-Note:

>Audit-Trail:
From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53533: Suggestion: sysupgrade should terminate gracefully on full partitions.
Date: Fri, 17 Aug 2018 12:32:20 +0200

 Hello Lars-Johan,

 liman@cafax.se writes:
 > [...]
 > >Description:
 > Sysupgrade is a fantastic tool. but while using sysupgrade-1.5nb3 to upg=
 rade from NetBSD 7.1.2 to 8.0, my /usr partition went through the roof. Fa=
 ir enogh. It was indeed too small.
 >
 > The issue is that sysupgrade didn't notice. It just kept trying to pump =
 new files onto the full partition.
 >
 > I suggest adding more sensitivity to sysupgrade so that it detects a ful=
 l partition, and aborts gracefully - possibly leavning a status file behin=
 d somewhere so it can continue from where it left off when a sysadmin has =
 addressed the issue with the full partition.
 >
 > Just a thought ...
 > >How-To-Repeat:
 > Fill up your /usr partition almost to the brim, then try to use sysupgra=
 de.
 > [...]

 Can you please report this problem upstream?

 I think that despite there is no HOMEPAGE in sysutils/sysupgrade its
 HOMEPAGE should be:

  <https://github.com/jmmv/sysupgrade>


 Thank you!

From: Lars-Johan Liman <liman@cafax.se>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53533: Suggestion: sysupgrade should terminate gracefully on full partitions.
Date: Fri, 17 Aug 2018 15:32:47 +0200

 leot@NetBSD.org:
 > The following reply was made to PR pkg/53533; it has been noted by GNATS.

 > From: Leonardo Taccari <leot@NetBSD.org>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: pkg/53533: Suggestion: sysupgrade should terminate
 > gracefully on full partitions.
 > Date: Fri, 17 Aug 2018 12:32:20 +0200

 >  Hello Lars-Johan,

 >  liman@cafax.se writes:
 >> [...]
 >> >Description:
 >> Sysupgrade is a fantastic tool. but while using sysupgrade-1.5nb3 to upg=
 >  rade from NetBSD 7.1.2 to 8.0, my /usr partition went through the roof. Fa=
 >  ir enogh. It was indeed too small.
 >> 
 >> The issue is that sysupgrade didn't notice. It just kept trying to pump =
 >  new files onto the full partition.
 >> 
 >> I suggest adding more sensitivity to sysupgrade so that it detects a ful=
 >  l partition, and aborts gracefully - possibly leavning a status file behin=
 >  d somewhere so it can continue from where it left off when a sysadmin has =
 >  addressed the issue with the full partition.
 >> 
 >> Just a thought ...
 >> >How-To-Repeat:
 >> Fill up your /usr partition almost to the brim, then try to use sysupgra=
 >  de.
 >> [...]

 >  Can you please report this problem upstream?

 Ah. Yes, I'll be happy to. I was just following instructions on

 http://cdn.netbsd.org/pub/pkgsrc/current/pkgsrc/sysutils/sysupgrade/README.html

 which says:

     "Problem reports, updates or *SUGGESTIONS* for this package should be
     reported with send-pr."

 >  I think that despite there is no HOMEPAGE in sysutils/sysupgrade its
 >  HOMEPAGE should be:

 >   <https://github.com/jmmv/sysupgrade>

 Ack! Thanks! Will do!

 Thanks for responding quickly!

 				Cheers,
 				  /Liman

From: Lars-Johan Liman <liman@cafax.se>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53533: Suggestion: sysupgrade should terminate gracefully on full partitions.
Date: Fri, 17 Aug 2018 15:41:30 +0200

 leot@NetBSD.org:
 >> I think that despite there is no HOMEPAGE in sysutils/sysupgrade its
 >> HOMEPAGE should be:

 >> <https://github.com/jmmv/sysupgrade>

 liman@cafax.se:
 > Ack! Thanks! Will do!

 This is now issue #5 in Github:

 https://github.com/jmmv/sysupgrade/issues/5

 Thanks again!

 				Cheers,
 				  /Liman

Responsible-Changed-From-To: pkg-manager->jmmv
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Fri, 17 Aug 2018 17:28:33 +0000
Responsible-Changed-Why:
Julio, can you please give it a look?
(over to MAINTAINER)


State-Changed-From-To: open->analyzed
State-Changed-By: jmmv@NetBSD.org
State-Changed-When: Mon, 20 Aug 2018 00:58:24 +0000
State-Changed-Why:
The issue has been fixed in the upstream code and should be corrected in pkgsrc once there is a new release and it's imported into pkgsrc.


>Unformatted:

Home	PR Database Search