NetBSD Problem Report #53534

From www@NetBSD.org  Fri Aug 17 11:01:32 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 240267A1F1
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 17 Aug 2018 11:01:32 +0000 (UTC)
Message-Id: <20180817110130.A04857A26A@mollari.NetBSD.org>
Date: Fri, 17 Aug 2018 11:01:30 +0000 (UTC)
From: tho@useless-ficus.net
Reply-To: tho@useless-ficus.net
To: gnats-bugs@NetBSD.org
Subject: Update pkgsrc/security/tcl-tls to latest version, fixing build issue with openssl-1.1.x
X-Send-Pr-Version: www-1.0

>Number:         53534
>Category:       pkg
>Synopsis:       Update pkgsrc/security/tcl-tls to latest version, fixing build issue with openssl-1.1.x
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bsiegert
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 17 11:05:00 +0000 2018
>Closed-Date:    Sun Sep 02 18:38:37 +0000 2018
>Last-Modified:  Sun Sep 02 18:40:01 +0000 2018
>Originator:     Anthony Mallet
>Release:        pkgsrc-2018Q2
>Organization:
>Environment:
NetBSD ficus 8.99.23 NetBSD 8.99.23 (FICUS) #14: Mon Aug  6 15:40:09 CEST 2018
>Description:
Hi,

Current tcl-tls 1.5 fails to build with base openssl-1.1.0.

The latest tcl-tls 1.7.16 release fixes this. All local patches removed, they are either fixed upstream (compiler, ldflag) or don't make sense anymore (PLIST).

tcltls is now hosted at http://core.tcl.tk, the ChangeLog can be browsed online at http://core.tcl.tk/tcltls/artifact/7400a29b58b8fe1f
It contains bugfixes or dependencies upgrades (e.g. openssl) but no API changes.

I tested this release only on -current, i.e. not with earlier openssl.

>How-To-Repeat:

>Fix:
Index: security/tcl-tls/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/security/tcl-tls/Makefile,v
retrieving revision 1.15
diff -u -r1.15 Makefile
--- security/tcl-tls/Makefile	5 Mar 2016 11:29:27 -0000	1.15
+++ security/tcl-tls/Makefile	17 Aug 2018 10:52:54 -0000
@@ -1,31 +1,24 @@
 # $NetBSD: Makefile,v 1.15 2016/03/05 11:29:27 jperkin Exp $
 #

-DISTNAME=		tls1.5.0-src
-PKGNAME=		tcl-tls-1.5.0
-PKGREVISION=		8
+DISTNAME=		tcltls-1.7.16
+PKGNAME=		tcl-tls-1.7.16
 CATEGORIES=		security
-MASTER_SITES=		${MASTER_SITE_SOURCEFORGE:=tls/}
+MASTER_SITES=		http://core.tcl.tk/tcltls/uv/

 MAINTAINER=		pkgsrc-users@NetBSD.org
-HOMEPAGE=		http://tls.sourceforge.net/
+HOMEPAGE=		http://core.tcl.tk/tcltls/home
 COMMENT=		TLS (aka SSL) Channel for the Tcl language
 LICENSE=		2-clause-bsd

-WRKSRC=			${WRKDIR}/tls1.5
-
 GNU_CONFIGURE=		yes
-CONFIGURE_ARGS+=	--with-ssl-dir=${BUILDLINK_PREFIX.openssl}
-CONFIGURE_ENV+=		LOCALBASE=${LOCALBASE:Q}
-MAKE_ENV+=		TCLLIB="${BUILDLINK_PREFIX.tcl}/lib"
+CONFIGURE_ARGS+=	--with-openssl-dir=${BUILDLINK_PREFIX.openssl}
+CONFIGURE_ARGS+=	--with-tcl="${BUILDLINK_PREFIX.tcl}/lib"

 TEST_TARGET=		test

 .include "../../lang/tcl/Makefile.version"

-PLIST_SUBST+=		TCL_SONUM=${TCL_SONUM}
-
-
 .include "../../lang/tcl/buildlink3.mk"
 .include "../../security/openssl/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: security/tcl-tls/PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/security/tcl-tls/PLIST,v
retrieving revision 1.3
diff -u -r1.3 PLIST
--- security/tcl-tls/PLIST	21 Aug 2012 21:56:13 -0000	1.3
+++ security/tcl-tls/PLIST	17 Aug 2018 10:52:54 -0000
@@ -1,5 +1,3 @@
 @comment $NetBSD: PLIST,v 1.3 2012/08/21 21:56:13 marino Exp $
-include/tls.h
-lib/libtls${TCL_SONUM}.so
-lib/tls1.50/pkgIndex.tcl
-lib/tls1.50/tls.tcl
+lib/tcltls${PKGVERSION}/pkgIndex.tcl
+lib/tcltls${PKGVERSION}/tcltls.so
Index: security/tcl-tls/distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/tcl-tls/distinfo,v
retrieving revision 1.7
diff -u -r1.7 distinfo
--- security/tcl-tls/distinfo	4 Nov 2015 01:18:11 -0000	1.7
+++ security/tcl-tls/distinfo	17 Aug 2018 10:52:54 -0000
@@ -1,10 +1,6 @@
 $NetBSD: distinfo,v 1.7 2015/11/04 01:18:11 agc Exp $

-SHA1 (tls1.5.0-src.tar.gz) = 66611f384f4b1c5e126ac8fc1cd03040bbe8ac16
-RMD160 (tls1.5.0-src.tar.gz) = fa37bc819ffc63f93991c876ffd318405e6bad85
-SHA512 (tls1.5.0-src.tar.gz) = d77d09d3c9113d6888d2a53b04f81b553719d62fc027c241c88250477472101942b31e552d3ab08f2f0dabf5a792c25e0d65f1d643e1c1010057da5ef8bb5584
-Size (tls1.5.0-src.tar.gz) = 113600 bytes
-SHA1 (patch-aa) = 0d2637038ce203dabdc4c4e9ea36d09a99978d15
-SHA1 (patch-ab) = 19b2a615f710f5b9524dc58cb89f96089f6573d8
-SHA1 (patch-ac) = 350f1b3fc999c27522b2e17e6ba65072095e9b45
-SHA1 (patch-ad) = 59a302a2bd17ae5d5fa55788949de02744cd1d04
+SHA1 (tcltls-1.7.16.tar.gz) = 24f6022bc36bb8a0fe8215d82838d3599200f048
+RMD160 (tcltls-1.7.16.tar.gz) = 136e6c78c565eb3208a6fe2e45973c4b232765ce
+SHA512 (tcltls-1.7.16.tar.gz) = f63b885dbfaec5d9ae811c126bd0ff253787effd7b053282b9ee566e9fae54df940bc058a6c3dd22e31fcb9ec6ae1b286aa40efd69c3f01f5a3014aada730ab1
+Size (tcltls-1.7.16.tar.gz) = 166439 bytes

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sun, 02 Sep 2018 18:38:37 +0000
Responsible-Changed-Why:
take


State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sun, 02 Sep 2018 18:38:37 +0000
State-Changed-Why:
Patch committed, thanks!


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53534 CVS commit: pkgsrc/security/tcl-tls
Date: Sun, 2 Sep 2018 18:37:26 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Sun Sep  2 18:37:26 UTC 2018

 Modified Files:
 	pkgsrc/security/tcl-tls: Makefile PLIST distinfo
 Removed Files:
 	pkgsrc/security/tcl-tls/patches: patch-aa patch-ab patch-ac patch-ad

 Log Message:
 Update tcl-tls to 1.7.16.

 This restores compatibility with OpenSSL 1.1.0. Local patches are no longer
 needed.

 Patch from Anthony Mallet in PR pkg/53534.


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 pkgsrc/security/tcl-tls/Makefile
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/security/tcl-tls/PLIST
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/security/tcl-tls/distinfo
 cvs rdiff -u -r1.1.1.1 -r0 pkgsrc/security/tcl-tls/patches/patch-aa \
     pkgsrc/security/tcl-tls/patches/patch-ac
 cvs rdiff -u -r1.4 -r0 pkgsrc/security/tcl-tls/patches/patch-ab
 cvs rdiff -u -r1.1 -r0 pkgsrc/security/tcl-tls/patches/patch-ad

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search