NetBSD Problem Report #53603

From www@NetBSD.org  Thu Sep 13 12:52:19 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 0103F7A166
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 13 Sep 2018 12:52:18 +0000 (UTC)
Message-Id: <20180913125217.DC3CB7A202@mollari.NetBSD.org>
Date: Thu, 13 Sep 2018 12:52:17 +0000 (UTC)
From: bastiangermann@fishpost.de
Reply-To: bastiangermann@fishpost.de
To: gnats-bugs@NetBSD.org
Subject: qt5-qtwebkit: pkg-config bugs
X-Send-Pr-Version: www-1.0

>Number:         53603
>Category:       pkg
>Synopsis:       qt5-qtwebkit: pkg-config bugs
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bsiegert
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 13 12:55:00 +0000 2018
>Closed-Date:    Sat Nov 10 10:49:20 +0000 2018
>Last-Modified:  Sat Nov 10 10:49:20 +0000 2018
>Originator:     Bastian Germann
>Release:        2018Q2
>Organization:
>Environment:
Linux hostname 4.18.0-1-686-pae #1 SMP Debian 4.18.6-1 (2018-09-06) i686 GNU/Linux
>Description:
qt5-qtwebkit's pkg-config files Qt5WebKit.pc and Qt5WebKitWidgets.pc have two problems each:

They do not contain the mandatory Description field which makes them useless at all. Additionally, the include paths are wrong.

This is an upstream problem. It would be nice to have a patch available in 2018Q3.
>How-To-Repeat:
Install the package and call `pkg-config Qt5WebKit Qt5WebKitWidgets`.
This will result in a 1 return value.
>Fix:
Add a Description and change the include paths to end with QtWebKit* instead of Qt5WebKit*, leaving out the 5, in both files.

>Release-Note:

>Audit-Trail:
From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53603: qt5-qtwebkit: pkg-config bugs
Date: Mon, 17 Sep 2018 14:19:15 +0200

 On Fri, Sep 14, 2018 at 7:33 AM <bastiangermann@fishpost.de> wrote:
 > Add a Description and change the include paths to end with QtWebKit* instead of Qt5WebKit*, leaving out the 5, in both files.

 It sounds like you have a patch. Can you share it please?


 -- 
 Benny

Responsible-Changed-From-To: pkg-manager->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Mon, 17 Sep 2018 12:20:39 +0000
Responsible-Changed-Why:
take (for now)


State-Changed-From-To: open->feedback
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Mon, 17 Sep 2018 12:20:39 +0000
State-Changed-Why:
Asked for feedback


From: Bastian Germann <bastiangermann@fishpost.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53603: qt5-qtwebkit: pkg-config bugs
Date: Mon, 17 Sep 2018 16:48:37 +0200

 You can find the upstream patches at:

 https://github.com/annulen/webkit/commit/0325d51c4a2a05fb
 https://github.com/annulen/webkit/commit/6c7b0f61c12d28cc

 > From: Benny Siegert <bsiegert@gmail.com>
 > To: gnats-bugs@netbsd.org
 > Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
 > Subject: Re: pkg/53603: qt5-qtwebkit: pkg-config bugs
 > Date: Mon, 17 Sep 2018 14:19:15 +0200
 > 
 >  On Fri, Sep 14, 2018 at 7:33 AM <bastiangermann@fishpost.de> wrote:
 >  > Add a Description and change the include paths to end with QtWebKit* instead of Qt5WebKit*, leaving out the 5, in both files.
 >  
 >  It sounds like you have a patch. Can you share it please?
 >  
 >  
 >  -- 
 >  Benny

State-Changed-From-To: feedback->analyzed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Mon, 17 Sep 2018 14:57:48 +0000
State-Changed-Why:
Thanks for sending the patches!


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53603 CVS commit: pkgsrc/x11/qt5-qtwebkit
Date: Fri, 9 Nov 2018 13:45:00 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Fri Nov  9 13:45:00 UTC 2018

 Modified Files:
 	pkgsrc/x11/qt5-qtwebkit: Makefile distinfo

 Log Message:
 Fix pkg-config usage.

 This applies two commits from upstream. Reported by Bastian Germann in
 PR pkg/53603, thanks!

 (Build untested, as one of the dependencies did not build for me. But
 "make patch" works.)


 To generate a diff of this commit:
 cvs rdiff -u -r1.56 -r1.57 pkgsrc/x11/qt5-qtwebkit/Makefile
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/x11/qt5-qtwebkit/distinfo

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: analyzed->feedback
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Fri, 09 Nov 2018 14:34:15 +0000
State-Changed-Why:
I committed the two changes. Does that fix the issue?


From: Bastian Germann <bastiangermann@fishpost.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53603 (qt5-qtwebkit: pkg-config bugs)
Date: Sat, 10 Nov 2018 10:03:28 +0100

 Works for me.

 Am 09.11.18 um 15:34 schrieb bsiegert@NetBSD.org:
 > Synopsis: qt5-qtwebkit: pkg-config bugs
 > 
 > State-Changed-From-To: analyzed->feedback
 > State-Changed-By: bsiegert@NetBSD.org
 > State-Changed-When: Fri, 09 Nov 2018 14:34:15 +0000
 > State-Changed-Why:
 > I committed the two changes. Does that fix the issue?
 > 
 > 
 > 

State-Changed-From-To: feedback->closed
State-Changed-By: leot@NetBSD.org
State-Changed-When: Sat, 10 Nov 2018 10:49:20 +0000
State-Changed-Why:
Feedback provided, problem fixed.

Thank you Bastian for the PR and patches and thanks to
Benny for applying them!


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.