NetBSD Problem Report #53706

From www@NetBSD.org  Wed Nov  7 06:22:44 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E33FF7A152
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  7 Nov 2018 06:22:44 +0000 (UTC)
Message-Id: <20181107062243.1E9EC7A1E5@mollari.NetBSD.org>
Date: Wed,  7 Nov 2018 06:22:43 +0000 (UTC)
From: david@gutteridge.ca
Reply-To: david@gutteridge.ca
To: gnats-bugs@NetBSD.org
Subject: wm/blackbox70 fails to build on NetBSD 8.0_STABLE
X-Send-Pr-Version: www-1.0

>Number:         53706
>Category:       pkg
>Synopsis:       wm/blackbox70 fails to build on NetBSD 8.0_STABLE
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gutteridge
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 07 06:25:00 +0000 2018
>Closed-Date:    Mon Dec 31 23:30:37 +0000 2018
>Last-Modified:  Mon Dec 31 23:30:37 +0000 2018
>Originator:     David H. Gutteridge
>Release:        pkgsrc HEAD
>Organization:
>Environment:
>Description:
When trying to build wm/blackbox70 on NetBSD 8.0_STABLE, I've found it
fails during the "make package" phase, with:

=> Generating post-install file lists
=> Checking file-check results for blackbox70-0.72
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg:
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/da/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/de/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/en@boldquot/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/en@quot/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/es/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/es_AR/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/et/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/fr/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/hu/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/it/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/ja/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/ko/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/lv/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/nl/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/no/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/pl/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/pt_BR/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/ro/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/ru/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/sk/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/sl/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/sv/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/tr/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/uk/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/zh_CN/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/zh_TW/LC_MESSAGES/blackbox.mo
*** Error code 1

In revision 1.16 of Makefile, this was added:

CONFIGURE_ARGS+=        --enable-nls

However, it doesn't actually work as-is, at least on NetBSD:

checking whether NLS is requested... yes
checking for msgfmt... /usr/pkgsrc/wm/blackbox70/work/.tools/bin/msgfmt
checking for gmsgfmt... /usr/pkgsrc/wm/blackbox70/work/.tools/bin/msgfmt
checking for xgettext... /usr/pkg/bin/xgettext
checking for msgmerge... /usr/pkg/bin/msgmerge
checking for ld used by gcc... /usr/pkgsrc/wm/blackbox70/work/.cwrapper/bin/ld
checking if the linker (/usr/pkgsrc/wm/blackbox70/work/.cwrapper/bin/ld) is GNU ld... yes
checking for shared library run path origin... done
checking for CFPreferencesCopyAppValue... no
checking for CFLocaleCopyCurrent... no
checking for GNU gettext in libc... no
checking for iconv... yes
checking for working iconv... yes
checking for GNU gettext in libintl... no
checking whether to use NLS... no

(Please see fix commentary below.)

>How-To-Repeat:
Try building the package.
>Fix:
The following patch allows it to complete "make package" successfully.

--- Makefile.orig       2018-10-29 23:26:40.636076886 -0400
+++ Makefile    2018-11-07 00:57:30.802797411 -0500
@@ -22,14 +22,14 @@

 CONFIGURE_ARGS+=       --enable-nls

-LIBS+=         ${BUILDLINK_LDADD.iconv}
+LIBS+=         ${BUILDLINK_LDADD.gettext}

 BUILDLINK_DEPMETHOD.libXt?=    build

 pre-configure:
        cd ${WRKSRC}; ${SH} ./autogen.sh

-.include "../../converters/libiconv/buildlink3.mk"
+.include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../x11/libX11/buildlink3.mk"
 .include "../../x11/libXt/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"

(The buildlink3.mk file of devel/gettext-lib already has:

.include "../../converters/libiconv/buildlink3.mk"

and

BUILDLINK_LDADD.gettext+=	${BUILDLINK_LDADD.iconv}

so in my understanding neither reference would need to be explicitly
provided in blackbox70's Makefile anymore.)

>Release-Note:

>Audit-Trail:
From: "David H. Gutteridge" <gutteridge@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53706 CVS commit: pkgsrc/wm/blackbox70
Date: Sat, 29 Dec 2018 04:33:17 +0000

 Module Name:	pkgsrc
 Committed By:	gutteridge
 Date:		Sat Dec 29 04:33:16 UTC 2018

 Modified Files:
 	pkgsrc/wm/blackbox70: Makefile

 Log Message:
 wm/blackbox70: Fix build failure on NetBSD

 Address PR pkg/53706: build failure on NetBSD. Build tested on NetBSD
 and Linux. (No PKGREVISION since NetBSD was broken, and there are no
 anticipated changes to OSes where it was already building.)


 To generate a diff of this commit:
 cvs rdiff -u -r1.16 -r1.17 pkgsrc/wm/blackbox70/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: pkg-manager->gutteridge
Responsible-Changed-By: gutteridge@NetBSD.org
Responsible-Changed-When: Sat, 29 Dec 2018 22:38:49 +0000
Responsible-Changed-Why:
Take.

State-Changed-From-To: open->closed
State-Changed-By: gutteridge@NetBSD.org
State-Changed-When: Mon, 31 Dec 2018 23:30:37 +0000
State-Changed-Why:
Issue resolved, and branched into 2018Q4.

>Unformatted:

Home	PR Database Search