NetBSD Problem Report #53745

From tsutsui@ceres.dti.ne.jp  Mon Nov 26 14:33:39 2018
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id DD8847A188
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 26 Nov 2018 14:33:39 +0000 (UTC)
Message-Id: <201811261433.wAQEXYFt023914@ceres.dti.ne.jp>
Date: Mon, 26 Nov 2018 23:33:34 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: pkgsrc/misc/raspberrypi-userland fails with PKG_DEVELOPER=yes
X-Send-Pr-Version: 3.95

>Number:         53745
>Category:       pkg
>Synopsis:       pkgsrc/misc/raspberrypi-userland fails with PKG_DEVELOPER=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jmcneill
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 26 14:35:00 +0000 2018
>Closed-Date:    Mon Dec 24 13:36:44 +0000 2018
>Last-Modified:  Mon Dec 24 13:36:44 +0000 2018
>Originator:     Izumi Tsutsui
>Release:        NetBSD 8.0
>Organization:
>Environment:
System: NetBSD rpi3 8.0 NetBSD 8.0 (RPI2) #0: Tue Jul 17 14:59:51 UTC 2018  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/evbarm/compile/RPI2 evbarm
Architecture: earmv6hf
Machine: evbarm RPI3B
>Description:
pkgsrc-2018Q3 pkgsrc/misc/raspberrypi-userland fails on make package
with PKG_DEVELOPER=yes:

---
 :
=> Automatic manual page handling
=> Generating post-install file lists
=> Checking file-check results for raspberrypi-userland-20170109nb1
=> Checking for non-existent script interpreters in raspberrypi-userland-20170109nb1
ERROR: [check-interpreter.mk] The interpreter "/bin/bash" of "/usr/obj.earmv6hf/pkgsrc/misc/raspberrypi-userland/work.earmv6hf/.destdir/usr/pkg/bin/dtoverlay-post" does not exist.
ERROR: [check-interpreter.mk] The interpreter "/bin/bash" of "/usr/obj.earmv6hf/pkgsrc/misc/raspberrypi-userland/work.earmv6hf/.destdir/usr/pkg/bin/dtoverlay-pre" does not exist.
*** Error code 1

Stop.
make[1]: stopped in /usr/pkgsrc/misc/raspberrypi-userland
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/misc/raspberrypi-userland

---

>How-To-Repeat:
% cd pkgsrc/misc/raspberrypi-userland
% env PKG_DEVELOPER=yes make package

>Fix:
Replace the paths using SUBST? or disable check-interpreter?

--- Makefile	2018-11-26 14:11:32.557535021 +0000
+++ Makefile.1	2018-11-26 14:24:59.971424021 +0000
@@ -29,6 +29,14 @@
 SUBST_FILES.vc=		makefiles/cmake/vmcs.cmake
 SUBST_SED.vc=		-e 's,/opt/vc,${PREFIX},g'

+SUBST_CLASSES+=		bash
+SUBST_STAGE.bash=	pre-configure
+SUBST_MESSAGE.bash=	Fixing hard-coded /bin/bash paths.
+SUBST_FILES.bash=	buildme	\
+			host_applications/linux/apps/dtoverlay/dtoverlay-post \
+			host_applications/linux/apps/dtoverlay/dtoverlay-pre
+SUBST_SED.bash=		-e 's,/bin/bash,${PREFIX}/bin/bash,g'
+
 .include "options.mk"

 .include "../../mk/bsd.pkg.mk"

>Release-Note:

>Audit-Trail:
From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53745: pkgsrc/misc/raspberrypi-userland fails with
 PKG_DEVELOPER=yes
Date: Mon, 26 Nov 2018 14:43:23 +0000

 If these are ever used at runtime, please add a dependency on bash too.
 USE_TOOLS+= bash:run

 We have REPLACE_BASH which should probably be used instead.
 e.g. devel/monodevelop:

 USE_TOOLS+=	gmake:run perl:run pkg-config bash:run msgfmt

 REPLACE_BASH+=	monodevelop.in
 REPLACE_BASH+=	src/addins/MonoDevelop.Autotools/templates/configure.template


 This is worth the hassle because bash may be a builtin (in linux).

From: Jonathan Perkin <jperkin@joyent.com>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53745: pkgsrc/misc/raspberrypi-userland fails with
 PKG_DEVELOPER=yes
Date: Mon, 26 Nov 2018 14:46:24 +0000

 * On 2018-11-26 at 14:35 GMT, Izumi Tsutsui wrote:

 > Replace the paths using SUBST? or disable check-interpreter?

 Never disable check-interpreter.  Use REPLACE_BASH.

 -- 
 Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: Re: pkg/53745: pkgsrc/misc/raspberrypi-userland fails with PKG_DEVELOPER=yes
Date: Sat, 1 Dec 2018 21:36:51 +0900

 As suggested the following patch solves the warnings:

 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/misc/raspberrypi-userland/Makefile,v
 retrieving revision 1.12
 diff -u -p -r1.12 Makefile
 --- Makefile	30 Jul 2017 22:32:19 -0000	1.12
 +++ Makefile	1 Dec 2018 11:48:52 -0000
 @@ -22,6 +22,7 @@ USE_LANGUAGES=	c c++

  USE_CMAKE=	yes
  CMAKE_ARGS+=	-DCMAKE_TOOLCHAIN_FILE=${WRKSRC}/makefiles/cmake/toolchains/arm-netbsdelf.cmake
 +USE_TOOLS+=		bash:run

  SUBST_CLASSES+=		vc
  SUBST_STAGE.vc=		pre-configure
 @@ -29,6 +30,10 @@ SUBST_MESSAGE.vc=	Fixing hard-coded inst
  SUBST_FILES.vc=		makefiles/cmake/vmcs.cmake
  SUBST_SED.vc=		-e 's,/opt/vc,${PREFIX},g'

 +REPLACE_BASH+=		buildme \
 +			host_applications/linux/apps/dtoverlay/dtoverlay-post \
 +			host_applications/linux/apps/dtoverlay/dtoverlay-pre
 +
  .include "options.mk"

  .include "../../mk/bsd.pkg.mk"

 ---
 Izumi Tsutsui

Responsible-Changed-From-To: pkg-manager->jmcneill
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Sat, 01 Dec 2018 13:01:17 +0000
Responsible-Changed-Why:
Jared, can you please give it a look?
(over to MAINTAINER)


From: "Izumi Tsutsui" <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53745 CVS commit: pkgsrc/misc/raspberrypi-userland
Date: Mon, 24 Dec 2018 01:53:51 +0000

 Module Name:	pkgsrc
 Committed By:	tsutsui
 Date:		Mon Dec 24 01:53:51 UTC 2018

 Modified Files:
 	pkgsrc/misc/raspberrypi-userland: Makefile

 Log Message:
 raspberrypi-userland: fix build errors on PKG_DEVELOPER=yes. PR pkg/53745

 Bump PKGREVISION for the changed files and dependency change.
 Ok'ed by wiz@


 To generate a diff of this commit:
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/misc/raspberrypi-userland/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Mon, 24 Dec 2018 13:36:44 +0000
State-Changed-Why:
Fix committed.


>Unformatted:

Home	PR Database Search