NetBSD Problem Report #53787

From www@NetBSD.org  Sat Dec 15 10:17:41 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 7C8117A183
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 15 Dec 2018 10:17:41 +0000 (UTC)
Message-Id: <20181215101739.2E7557A225@mollari.NetBSD.org>
Date: Sat, 15 Dec 2018 10:17:39 +0000 (UTC)
From: jonthn+pkgsrc@pinacea.com
Reply-To: jonthn+pkgsrc@pinacea.com
To: gnats-bugs@NetBSD.org
Subject: Update devel/lua-filesytem to 1.7.0_2
X-Send-Pr-Version: www-1.0

>Number:         53787
>Category:       pkg
>Synopsis:       Update devel/lua-filesytem to 1.7.0_2
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    fhajny
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 15 10:20:00 +0000 2018
>Closed-Date:    Tue May 28 20:44:23 +0000 2019
>Last-Modified:  Tue May 28 20:45:01 +0000 2019
>Originator:     Jonathan Buschmann
>Release:        latest branch
>Organization:
>Environment:
>Description:
I tried to contact the maintainer 'filip' but this mailbox doesn't exist anymore.

See this diff to update to latest (only tested on macOS)

----

diff --git c/devel/lua-filesystem/Makefile i/devel/lua-filesystem/Makefile
index 2f34b1b95f8..4010617c29d 100644
--- c/devel/lua-filesystem/Makefile
+++ i/devel/lua-filesystem/Makefile
@@ -1,22 +1,25 @@
 # $NetBSD: Makefile,v 1.9 2015/03/24 13:35:49 fhajny Exp $
 #

-DISTNAME=		luafilesystem-1.6.3
+DISTNAME=		luafilesystem-1.7.0
 PKGNAME=		${DISTNAME:S/lua/${LUA_PKGPREFIX}-/}
 CATEGORIES=		devel
-MASTER_SITES=		-http://github.com/keplerproject/luafilesystem/archive/v_1_6_3.tar.gz
+MASTER_SITES=		${MASTER_SITE_GITHUB:=keplerproject/}
+GITHUB_PROJECT=		luafilesystem
+GITHUB_TAG=		v${PKGVERSION_NOREV:S/./_/g}_2

 MAINTAINER=		filip@joyent.com
 HOMEPAGE=		http://keplerproject.github.com/luafilesystem/
 COMMENT=		File system related library for Lua
 LICENSE=		mit

-WRKSRC=			${WRKDIR}/luafilesystem-v_${PKGVERSION_NOREV:S/./_/g}
+WRKSRC=			${WRKDIR}/luafilesystem-${PKGVERSION_NOREV:S/./_/g}_2

-USE_TOOLS+=		gmake
+USE_TOOLS+=		gmake pkg-config
 BUILD_TARGET=		lib

 MAKE_ENV+=		LUA_CDIR=${LUA_CDIR}
+MAKE_ENV+=		LUA_LINKVERSION=${LUA_VERSION_MAJOR}.${LUA_VERSION_MINOR}

 .include "../../lang/lua/module.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git c/devel/lua-filesystem/distinfo i/devel/lua-filesystem/distinfo
index 7d2fcf383ea..6d7c6202add 100644
--- c/devel/lua-filesystem/distinfo
+++ i/devel/lua-filesystem/distinfo
@@ -1,7 +1,8 @@
 $NetBSD: distinfo,v 1.5 2015/11/03 03:27:47 agc Exp $

-SHA1 (luafilesystem-1.6.3.tar.gz) = 72bc1415e7eefb339742538505675c59bd69e6bb
-RMD160 (luafilesystem-1.6.3.tar.gz) = cb949e36d9d09061be5eed9c67332cb3178250b5
-SHA512 (luafilesystem-1.6.3.tar.gz) = abfa1b3ac22ed80189560a1a025a7ea21a954defe14e5b539e08f266d180962a691262efc7eb2ddacc2d4aae14d6e356b1a276165b5bed46a13e4d6c61ab99f1
-Size (luafilesystem-1.6.3.tar.gz) = 30379 bytes
-SHA1 (patch-aa) = c287a1203f4a85e616ef3d31276aabfb0a1ed83d
+SHA1 (luafilesystem-1.7.0.tar.gz) = 910de0959ff72703b284c26783979b663c4dc0d2
+RMD160 (luafilesystem-1.7.0.tar.gz) = 6770d25f1d0928c347560425d7c5758788038fd9
+SHA512 (luafilesystem-1.7.0.tar.gz) = a1d4d077776e57cd878dbcd21656da141ea3686c587b5420a2b039aeaf086b7e7d05d531ee1cc2bbd7d06660d1315b09593e52143f6711f033ce8eecdc550511
+Size (luafilesystem-1.7.0.tar.gz) = 30877 bytes
+SHA1 (patch-Makefile) = 6356dbf1c4ba7d8ed1b775c3ddddde40570677df
+SHA1 (patch-config) = 1ea446296ea2d5f08753c127e99984fead120cac
diff --git c/devel/lua-filesystem/patches/patch-Makefile i/devel/lua-filesystem/patches/patch-Makefile
new file mode 100644
index 00000000000..e14b79d24da
--- /dev/null
+++ i/devel/lua-filesystem/patches/patch-Makefile
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- Makefile.orig	2018-12-15 04:00:31.000000000 +0000
++++ Makefile
+@@ -12,7 +12,7 @@ OBJS= src/$T.o
+ lib: src/lfs.so
+ 
+ src/lfs.so: $(OBJS)
+-	MACOSX_DEPLOYMENT_TARGET="10.3"; export MACOSX_DEPLOYMENT_TARGET; $(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
++	$(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
+ 
+ test: lib
+ 	LUA_CPATH=./src/?.so lua tests/test.lua
diff --git c/devel/lua-filesystem/patches/patch-aa i/devel/lua-filesystem/patches/patch-config
similarity index 66%
rename from devel/lua-filesystem/patches/patch-aa
rename to devel/lua-filesystem/patches/patch-config
index 9dc3373d6f8..bb0a27b5440 100644
--- c/devel/lua-filesystem/patches/patch-aa
+++ i/devel/lua-filesystem/patches/patch-config
@@ -1,9 +1,9 @@
 $NetBSD: patch-aa,v 1.2 2013/09/13 12:09:37 fhajny Exp $

 Fix default directory locations
---- config.orig	2012-10-04 14:25:54.000000000 +0000
+--- config.orig	2017-09-15 23:07:33.000000000 +0000
 +++ config
-@@ -1,10 +1,10 @@
+@@ -1,22 +1,22 @@
  # Installation directories

  # Default installation prefix
@@ -16,7 +16,13 @@ Fix default directory locations

  # Lua includes directory
  LUA_INC= $(PREFIX)/include
-@@ -16,7 +16,7 @@ LIB_OPTION= -shared #for Linux
+ 
+ # OS dependent
+-LIB_OPTION= -shared #for Linux
+-#LIB_OPTION= -bundle -undefined dynamic_lookup #for MacOS X
++LIB_OPTION+= $(shell pkg-config --libs lua-${LUA_LINKVERSION}) -shared #for Linux
++#LIB_OPTION+= -bundle -undefined dynamic_lookup #for MacOS X
+ 
  LIBNAME= $T.so.$V

  # Compilation directives

>How-To-Repeat:

>Fix:
diff --git c/devel/lua-filesystem/Makefile i/devel/lua-filesystem/Makefile
index 2f34b1b95f8..4010617c29d 100644
--- c/devel/lua-filesystem/Makefile
+++ i/devel/lua-filesystem/Makefile
@@ -1,22 +1,25 @@
 # $NetBSD: Makefile,v 1.9 2015/03/24 13:35:49 fhajny Exp $
 #

-DISTNAME=		luafilesystem-1.6.3
+DISTNAME=		luafilesystem-1.7.0
 PKGNAME=		${DISTNAME:S/lua/${LUA_PKGPREFIX}-/}
 CATEGORIES=		devel
-MASTER_SITES=		-http://github.com/keplerproject/luafilesystem/archive/v_1_6_3.tar.gz
+MASTER_SITES=		${MASTER_SITE_GITHUB:=keplerproject/}
+GITHUB_PROJECT=		luafilesystem
+GITHUB_TAG=		v${PKGVERSION_NOREV:S/./_/g}_2

 MAINTAINER=		filip@joyent.com
 HOMEPAGE=		http://keplerproject.github.com/luafilesystem/
 COMMENT=		File system related library for Lua
 LICENSE=		mit

-WRKSRC=			${WRKDIR}/luafilesystem-v_${PKGVERSION_NOREV:S/./_/g}
+WRKSRC=			${WRKDIR}/luafilesystem-${PKGVERSION_NOREV:S/./_/g}_2

-USE_TOOLS+=		gmake
+USE_TOOLS+=		gmake pkg-config
 BUILD_TARGET=		lib

 MAKE_ENV+=		LUA_CDIR=${LUA_CDIR}
+MAKE_ENV+=		LUA_LINKVERSION=${LUA_VERSION_MAJOR}.${LUA_VERSION_MINOR}

 .include "../../lang/lua/module.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git c/devel/lua-filesystem/distinfo i/devel/lua-filesystem/distinfo
index 7d2fcf383ea..6d7c6202add 100644
--- c/devel/lua-filesystem/distinfo
+++ i/devel/lua-filesystem/distinfo
@@ -1,7 +1,8 @@
 $NetBSD: distinfo,v 1.5 2015/11/03 03:27:47 agc Exp $

-SHA1 (luafilesystem-1.6.3.tar.gz) = 72bc1415e7eefb339742538505675c59bd69e6bb
-RMD160 (luafilesystem-1.6.3.tar.gz) = cb949e36d9d09061be5eed9c67332cb3178250b5
-SHA512 (luafilesystem-1.6.3.tar.gz) = abfa1b3ac22ed80189560a1a025a7ea21a954defe14e5b539e08f266d180962a691262efc7eb2ddacc2d4aae14d6e356b1a276165b5bed46a13e4d6c61ab99f1
-Size (luafilesystem-1.6.3.tar.gz) = 30379 bytes
-SHA1 (patch-aa) = c287a1203f4a85e616ef3d31276aabfb0a1ed83d
+SHA1 (luafilesystem-1.7.0.tar.gz) = 910de0959ff72703b284c26783979b663c4dc0d2
+RMD160 (luafilesystem-1.7.0.tar.gz) = 6770d25f1d0928c347560425d7c5758788038fd9
+SHA512 (luafilesystem-1.7.0.tar.gz) = a1d4d077776e57cd878dbcd21656da141ea3686c587b5420a2b039aeaf086b7e7d05d531ee1cc2bbd7d06660d1315b09593e52143f6711f033ce8eecdc550511
+Size (luafilesystem-1.7.0.tar.gz) = 30877 bytes
+SHA1 (patch-Makefile) = 6356dbf1c4ba7d8ed1b775c3ddddde40570677df
+SHA1 (patch-config) = 1ea446296ea2d5f08753c127e99984fead120cac
diff --git c/devel/lua-filesystem/patches/patch-Makefile i/devel/lua-filesystem/patches/patch-Makefile
new file mode 100644
index 00000000000..e14b79d24da
--- /dev/null
+++ i/devel/lua-filesystem/patches/patch-Makefile
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- Makefile.orig	2018-12-15 04:00:31.000000000 +0000
++++ Makefile
+@@ -12,7 +12,7 @@ OBJS= src/$T.o
+ lib: src/lfs.so
+ 
+ src/lfs.so: $(OBJS)
+-	MACOSX_DEPLOYMENT_TARGET="10.3"; export MACOSX_DEPLOYMENT_TARGET; $(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
++	$(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
+ 
+ test: lib
+ 	LUA_CPATH=./src/?.so lua tests/test.lua
diff --git c/devel/lua-filesystem/patches/patch-aa i/devel/lua-filesystem/patches/patch-config
similarity index 66%
rename from devel/lua-filesystem/patches/patch-aa
rename to devel/lua-filesystem/patches/patch-config
index 9dc3373d6f8..bb0a27b5440 100644
--- c/devel/lua-filesystem/patches/patch-aa
+++ i/devel/lua-filesystem/patches/patch-config
@@ -1,9 +1,9 @@
 $NetBSD: patch-aa,v 1.2 2013/09/13 12:09:37 fhajny Exp $

 Fix default directory locations
---- config.orig	2012-10-04 14:25:54.000000000 +0000
+--- config.orig	2017-09-15 23:07:33.000000000 +0000
 +++ config
-@@ -1,10 +1,10 @@
+@@ -1,22 +1,22 @@
  # Installation directories

  # Default installation prefix
@@ -16,7 +16,13 @@ Fix default directory locations

  # Lua includes directory
  LUA_INC= $(PREFIX)/include
-@@ -16,7 +16,7 @@ LIB_OPTION= -shared #for Linux
+ 
+ # OS dependent
+-LIB_OPTION= -shared #for Linux
+-#LIB_OPTION= -bundle -undefined dynamic_lookup #for MacOS X
++LIB_OPTION+= $(shell pkg-config --libs lua-${LUA_LINKVERSION}) -shared #for Linux
++#LIB_OPTION+= -bundle -undefined dynamic_lookup #for MacOS X
+ 
  LIBNAME= $T.so.$V

  # Compilation directives

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->fhajny
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Sat, 15 Dec 2018 10:30:38 +0000
Responsible-Changed-Why:
Filip, can you please give it a look?
(Over to MAINTAINER)


State-Changed-From-To: open->feedback
State-Changed-By: leot@NetBSD.org
State-Changed-When: Sat, 15 Dec 2018 10:59:08 +0000
State-Changed-Why:
Some questions asked.


From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53787: Update devel/lua-filesytem to 1.7.0_2
Date: Sat, 15 Dec 2018 11:57:51 +0100

 Hello Jonathan,

 jonthn+pkgsrc@pinacea.com writes:
 > [...]
 > I tried to contact the maintainer 'filip' but this mailbox doesn't exist anymore.
 >
 > See this diff to update to latest (only tested on macOS)
 > [...]

 Thank you for the PR and patch!

 Just some possible comments directly inline!

 > +$NetBSD$
 > +
 > +--- Makefile.orig	2018-12-15 04:00:31.000000000 +0000
 > ++++ Makefile
 > +@@ -12,7 +12,7 @@ OBJS= src/$T.o
 > + lib: src/lfs.so
 > + 
 > + src/lfs.so: $(OBJS)
 > +-	MACOSX_DEPLOYMENT_TARGET="10.3"; export MACOSX_DEPLOYMENT_TARGET; $(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
 > ++	$(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
 > + 
 > + test: lib
 > + 	LUA_CPATH=./src/?.so lua tests/test.lua

 Why is it needed to remove MACOSX_DEPLOYMENT_TARGET?
 (please add comment to patch)

 > diff --git c/devel/lua-filesystem/patches/patch-aa i/devel/lua-filesystem/patches/patch-config
 > similarity index 66%
 > rename from devel/lua-filesystem/patches/patch-aa
 > rename to devel/lua-filesystem/patches/patch-config
 > index 9dc3373d6f8..bb0a27b5440 100644
 > --- c/devel/lua-filesystem/patches/patch-aa
 > +++ i/devel/lua-filesystem/patches/patch-config
 > [...]
 > -@@ -16,7 +16,7 @@ LIB_OPTION= -shared #for Linux
 > + 
 > + # OS dependent
 > +-LIB_OPTION= -shared #for Linux
 > +-#LIB_OPTION= -bundle -undefined dynamic_lookup #for MacOS X
 > ++LIB_OPTION+= $(shell pkg-config --libs lua-${LUA_LINKVERSION}) -shared #for Linux
 > ++#LIB_OPTION+= -bundle -undefined dynamic_lookup #for MacOS X
 > + 
 >   LIBNAME= $T.so.$V
 >   
 >   # Compilation directives
 >

 Why is it needed to adjust LIB_OPTION? 
 (please add comment to this hunk of patch)

 If this in not needed the `pkg-config' from USE_TOOLS can be removed
 and also exporting LUA_LINKVERSION via MAKE_ENV.


 (If you can please also provide a changelog for the update, thanks!)


 Thank you again!

From: Jonathan Buschmann <jonthn+pkgsrc@pinacea.com>
To: gnats-bugs@netbsd.org
Cc: fhajny@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53787: Update devel/lua-filesytem to 1.7.0_2
Date: Thu, 3 Jan 2019 23:29:27 +0800

 --0000000000003ffc98057e8f6ee2
 Content-Type: multipart/alternative; boundary="0000000000003ffc95057e8f6ee0"

 --0000000000003ffc95057e8f6ee0
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 Hello Leonardo,

 I have reworked the patch to avoid using pkg-config, not sure it's better
 this way though.
 Also put some comments in the patches

 The changelog :

 *Version 1.7.0* [15/Sep/2017]

    - symlinkattributes function now provides 'target' field, containing
    name of the file that the symlink points to.
    - attributes, symlinkattributes, touch, mkdir, and rmdir functions now
    return system-dependent error code as the third value on error.
    - Fixed detection of closed files for Lua 5.2+ in setmode, lock, and
    unlock functions.
    - Fixed various compiler warnings.


 Sorry for the late reply.

 Thank you,


 Le sam. 15 d=C3=A9c. 2018 =C3=A0 19:00, Leonardo Taccari <leot@netbsd.org> =
 a =C3=A9crit :

 > The following reply was made to PR pkg/53787; it has been noted by GNATS.
 >
 > From: Leonardo Taccari <leot@NetBSD.org>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: pkg/53787: Update devel/lua-filesytem to 1.7.0_2
 > Date: Sat, 15 Dec 2018 11:57:51 +0100
 >
 >  Hello Jonathan,
 >
 >  jonthn+pkgsrc@pinacea.com writes:
 >  > [...]
 >  > I tried to contact the maintainer 'filip' but this mailbox doesn't
 > exist anymore.
 >  >
 >  > See this diff to update to latest (only tested on macOS)
 >  > [...]
 >
 >  Thank you for the PR and patch!
 >
 >  Just some possible comments directly inline!
 >
 >  > +$NetBSD$
 >  > +
 >  > +--- Makefile.orig   2018-12-15 04:00:31.000000000 +0000
 >  > ++++ Makefile
 >  > +@@ -12,7 +12,7 @@ OBJS=3D src/$T.o
 >  > + lib: src/lfs.so
 >  > +
 >  > + src/lfs.so: $(OBJS)
 >  > +-   MACOSX_DEPLOYMENT_TARGET=3D"10.3"; export MACOSX_DEPLOYMENT_TARGE=
 T;
 > $(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
 >  > ++   $(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
 >  > +
 >  > + test: lib
 >  > +    LUA_CPATH=3D./src/?.so lua tests/test.lua
 >
 >  Why is it needed to remove MACOSX_DEPLOYMENT_TARGET?
 >  (please add comment to patch)
 >
 >  > diff --git c/devel/lua-filesystem/patches/patch-aa
 > i/devel/lua-filesystem/patches/patch-config
 >  > similarity index 66%
 >  > rename from devel/lua-filesystem/patches/patch-aa
 >  > rename to devel/lua-filesystem/patches/patch-config
 >  > index 9dc3373d6f8..bb0a27b5440 100644
 >  > --- c/devel/lua-filesystem/patches/patch-aa
 >  > +++ i/devel/lua-filesystem/patches/patch-config
 >  > [...]
 >  > -@@ -16,7 +16,7 @@ LIB_OPTION=3D -shared #for Linux
 >  > +
 >  > + # OS dependent
 >  > +-LIB_OPTION=3D -shared #for Linux
 >  > +-#LIB_OPTION=3D -bundle -undefined dynamic_lookup #for MacOS X
 >  > ++LIB_OPTION+=3D $(shell pkg-config --libs lua-${LUA_LINKVERSION})
 > -shared #for Linux
 >  > ++#LIB_OPTION+=3D -bundle -undefined dynamic_lookup #for MacOS X
 >  > +
 >  >   LIBNAME=3D $T.so.$V
 >  >
 >  >   # Compilation directives
 >  >
 >
 >  Why is it needed to adjust LIB_OPTION?
 >  (please add comment to this hunk of patch)
 >
 >  If this in not needed the `pkg-config' from USE_TOOLS can be removed
 >  and also exporting LUA_LINKVERSION via MAKE_ENV.
 >
 >
 >  (If you can please also provide a changelog for the update, thanks!)
 >
 >
 >  Thank you again!
 >
 >

 --0000000000003ffc95057e8f6ee0
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr"><div>Hello Leonardo,</div><div><br></div><div>I have rewor=
 ked the patch to avoid using pkg-config, not sure it&#39;s better this way =
 though.</div><div>Also put some comments in the patches</div><div><br></div=
 ><div>The changelog :</div><div><br></div><div><dl><dt>Version 1.7.0=
  [15/Sep/2017]</dt>
     <dd><ul><li>symlinkattributes function now provides &#39;target&#39; fi=
 eld, containing name of the file that the symlink points to.</li><li>attrib=
 utes, symlinkattributes, touch, mkdir, and rmdir=20
 functions now return system-dependent error code as the third value on=20
 error.</li><li>Fixed detection of closed files for Lua 5.2+ in setmode, loc=
 k, and unlock functions.</li><li>Fixed various compiler warnings.</li></ul>=
 </dd></dl></div><div><br></div><div>Sorry for the late reply.</div><div><br=
 ></div><div>Thank you,<br></div><div><br></div><br><div class=3D"gmail_quot=
 e"><div dir=3D"ltr">Le=C2=A0sam. 15 d=C3=A9c. 2018 =C3=A0=C2=A019:00, Leona=
 rdo Taccari &lt;<a href=3D"mailto:leot@netbsd.org" target=3D"_blank">leot@n=
 etbsd.org</a>&gt; a =C3=A9crit=C2=A0:<br></div><blockquote class=3D"gmail_q=
 uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2=
 04);padding-left:1ex">The following reply was made to PR pkg/53787; it has =
 been noted by GNATS.<br>
 <br>
 From: Leonardo Taccari &lt;leot@NetBSD.org&gt;<br>
 To: gnats-bugs@NetBSD.org<br>
 Cc: <br>
 Subject: Re: pkg/53787: Update devel/lua-filesytem to 1.7.0_2<br>
 Date: Sat, 15 Dec 2018 11:57:51 +0100<br>
 <br>
 =C2=A0Hello Jonathan,<br>
 <br>
 =C2=A0<a href=3D"mailto:jonthn%2Bpkgsrc@pinacea.com" target=3D"_blank">jont=
 hn+pkgsrc@pinacea.com</a> writes:<br>
 =C2=A0&gt; [...]<br>
 =C2=A0&gt; I tried to contact the maintainer &#39;filip&#39; but this mailb=
 ox doesn&#39;t exist anymore.<br>
 =C2=A0&gt;<br>
 =C2=A0&gt; See this diff to update to latest (only tested on macOS)<br>
 =C2=A0&gt; [...]<br>
 <br>
 =C2=A0Thank you for the PR and patch!<br>
 <br>
 =C2=A0Just some possible comments directly inline!<br>
 <br>
 =C2=A0&gt; +$NetBSD$<br>
 =C2=A0&gt; +<br>
 =C2=A0&gt; +--- Makefile.orig=C2=A0 =C2=A02018-12-15 04:00:31.000000000 +00=
 00<br>
 =C2=A0&gt; ++++ Makefile<br>
 =C2=A0&gt; +@@ -12,7 +12,7 @@ OBJS=3D src/$T.o<br>
 =C2=A0&gt; + lib: src/lfs.so<br>
 =C2=A0&gt; + <br>
 =C2=A0&gt; + src/lfs.so: $(OBJS)<br>
 =C2=A0&gt; +-=C2=A0 =C2=A0MACOSX_DEPLOYMENT_TARGET=3D&quot;10.3&quot;; expo=
 rt MACOSX_DEPLOYMENT_TARGET; $(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)<br>
 =C2=A0&gt; ++=C2=A0 =C2=A0$(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)<br>
 =C2=A0&gt; + <br>
 =C2=A0&gt; + test: lib<br>
 =C2=A0&gt; +=C2=A0 =C2=A0 LUA_CPATH=3D./src/?.so lua tests/test.lua<br>
 <br>
 =C2=A0Why is it needed to remove MACOSX_DEPLOYMENT_TARGET?<br>
 =C2=A0(please add comment to patch)<br>
 <br>
 =C2=A0&gt; diff --git c/devel/lua-filesystem/patches/patch-aa i/devel/lua-f=
 ilesystem/patches/patch-config<br>
 =C2=A0&gt; similarity index 66%<br>
 =C2=A0&gt; rename from devel/lua-filesystem/patches/patch-aa<br>
 =C2=A0&gt; rename to devel/lua-filesystem/patches/patch-config<br>
 =C2=A0&gt; index 9dc3373d6f8..bb0a27b5440 100644<br>
 =C2=A0&gt; --- c/devel/lua-filesystem/patches/patch-aa<br>
 =C2=A0&gt; +++ i/devel/lua-filesystem/patches/patch-config<br>
 =C2=A0&gt; [...]<br>
 =C2=A0&gt; -@@ -16,7 +16,7 @@ LIB_OPTION=3D -shared #for Linux<br>
 =C2=A0&gt; + <br>
 =C2=A0&gt; + # OS dependent<br>
 =C2=A0&gt; +-LIB_OPTION=3D -shared #for Linux<br>
 =C2=A0&gt; +-#LIB_OPTION=3D -bundle -undefined dynamic_lookup #for MacOS X<=
 br>
 =C2=A0&gt; ++LIB_OPTION+=3D $(shell pkg-config --libs lua-${LUA_LINKVERSION=
 }) -shared #for Linux<br>
 =C2=A0&gt; ++#LIB_OPTION+=3D -bundle -undefined dynamic_lookup #for MacOS X=
 <br>
 =C2=A0&gt; + <br>
 =C2=A0&gt;=C2=A0 =C2=A0LIBNAME=3D $T.so.$V<br>
 =C2=A0&gt;=C2=A0 =C2=A0<br>
 =C2=A0&gt;=C2=A0 =C2=A0# Compilation directives<br>
 =C2=A0&gt;<br>
 <br>
 =C2=A0Why is it needed to adjust LIB_OPTION? <br>
 =C2=A0(please add comment to this hunk of patch)<br>
 <br>
 =C2=A0If this in not needed the `pkg-config&#39; from USE_TOOLS can be remo=
 ved<br>
 =C2=A0and also exporting LUA_LINKVERSION via MAKE_ENV.<br>
 <br>
 <br>
 =C2=A0(If you can please also provide a changelog for the update, thanks!)<=
 br>
 <br>
 <br>
 =C2=A0Thank you again!<br>
 <br>
 </blockquote></div></div>

 --0000000000003ffc95057e8f6ee0--
 --0000000000003ffc98057e8f6ee2
 Content-Type: application/octet-stream; name="patch-lua-filesystem.diff"
 Content-Disposition: attachment; filename="patch-lua-filesystem.diff"
 Content-Transfer-Encoding: base64
 Content-ID: <f_jqgrkksp0>
 X-Attachment-Id: f_jqgrkksp0

 ZGlmZiAtLWdpdCBjL2RldmVsL2x1YS1maWxlc3lzdGVtL01ha2VmaWxlIGkvZGV2ZWwvbHVhLWZp
 bGVzeXN0ZW0vTWFrZWZpbGUKaW5kZXggMmYzNGIxYjk1ZjguLjQyOGIyNWQ0OGJkIDEwMDY0NAot
 LS0gYy9kZXZlbC9sdWEtZmlsZXN5c3RlbS9NYWtlZmlsZQorKysgaS9kZXZlbC9sdWEtZmlsZXN5
 c3RlbS9NYWtlZmlsZQpAQCAtMSwyMiArMSwyNSBAQAogIyAkTmV0QlNEOiBNYWtlZmlsZSx2IDEu
 OSAyMDE1LzAzLzI0IDEzOjM1OjQ5IGZoYWpueSBFeHAgJAogIwogCi1ESVNUTkFNRT0JCWx1YWZp
 bGVzeXN0ZW0tMS42LjMKK0RJU1ROQU1FPQkJbHVhZmlsZXN5c3RlbS0xLjcuMAogUEtHTkFNRT0J
 CSR7RElTVE5BTUU6Uy9sdWEvJHtMVUFfUEtHUFJFRklYfS0vfQogQ0FURUdPUklFUz0JCWRldmVs
 Ci1NQVNURVJfU0lURVM9CQktaHR0cDovL2dpdGh1Yi5jb20va2VwbGVycHJvamVjdC9sdWFmaWxl
 c3lzdGVtL2FyY2hpdmUvdl8xXzZfMy50YXIuZ3oKK01BU1RFUl9TSVRFUz0JCSR7TUFTVEVSX1NJ
 VEVfR0lUSFVCOj1rZXBsZXJwcm9qZWN0L30KK0dJVEhVQl9QUk9KRUNUPQkJbHVhZmlsZXN5c3Rl
 bQorR0lUSFVCX1RBRz0JCXYke1BLR1ZFUlNJT05fTk9SRVY6Uy8uL18vZ31fMgogCiBNQUlOVEFJ
 TkVSPQkJZmlsaXBAam95ZW50LmNvbQogSE9NRVBBR0U9CQlodHRwOi8va2VwbGVycHJvamVjdC5n
 aXRodWIuY29tL2x1YWZpbGVzeXN0ZW0vCiBDT01NRU5UPQkJRmlsZSBzeXN0ZW0gcmVsYXRlZCBs
 aWJyYXJ5IGZvciBMdWEKIExJQ0VOU0U9CQltaXQKIAotV1JLU1JDPQkJCSR7V1JLRElSfS9sdWFm
 aWxlc3lzdGVtLXZfJHtQS0dWRVJTSU9OX05PUkVWOlMvLi9fL2d9CitXUktTUkM9CQkJJHtXUktE
 SVJ9L2x1YWZpbGVzeXN0ZW0tJHtQS0dWRVJTSU9OX05PUkVWOlMvLi9fL2d9XzIKIAogVVNFX1RP
 T0xTKz0JCWdtYWtlCiBCVUlMRF9UQVJHRVQ9CQlsaWIKIAogTUFLRV9FTlYrPQkJTFVBX0NESVI9
 JHtMVUFfQ0RJUn0KK01BS0VfRU5WKz0JCUxVQV9WRVJTPSR7TFVBX1ZFUlNJT05fTUFKT1J9LiR7
 TFVBX1ZFUlNJT05fTUlOT1J9CiAKIC5pbmNsdWRlICIuLi8uLi9sYW5nL2x1YS9tb2R1bGUubWsi
 CiAuaW5jbHVkZSAiLi4vLi4vbWsvYnNkLnBrZy5tayIKZGlmZiAtLWdpdCBjL2RldmVsL2x1YS1m
 aWxlc3lzdGVtL2Rpc3RpbmZvIGkvZGV2ZWwvbHVhLWZpbGVzeXN0ZW0vZGlzdGluZm8KaW5kZXgg
 N2QyZmNmMzgzZWEuLjI5N2I1N2YzNmE3IDEwMDY0NAotLS0gYy9kZXZlbC9sdWEtZmlsZXN5c3Rl
 bS9kaXN0aW5mbworKysgaS9kZXZlbC9sdWEtZmlsZXN5c3RlbS9kaXN0aW5mbwpAQCAtMSw3ICsx
 LDggQEAKICROZXRCU0Q6IGRpc3RpbmZvLHYgMS41IDIwMTUvMTEvMDMgMDM6Mjc6NDcgYWdjIEV4
 cCAkCiAKLVNIQTEgKGx1YWZpbGVzeXN0ZW0tMS42LjMudGFyLmd6KSA9IDcyYmMxNDE1ZTdlZWZi
 MzM5NzQyNTM4NTA1Njc1YzU5YmQ2OWU2YmIKLVJNRDE2MCAobHVhZmlsZXN5c3RlbS0xLjYuMy50
 YXIuZ3opID0gY2I5NDllMzZkOWQwOTA2MWJlNWVlZDljNjczMzJjYjMxNzgyNTBiNQotU0hBNTEy
 IChsdWFmaWxlc3lzdGVtLTEuNi4zLnRhci5neikgPSBhYmZhMWIzYWMyMmVkODAxODk1NjBhMWEw
 MjVhN2VhMjFhOTU0ZGVmZTE0ZTViNTM5ZTA4ZjI2NmQxODA5NjJhNjkxMjYyZWZjN2ViMmRkYWNj
 MmQ0YWFlMTRkNmUzNTZiMWEyNzYxNjViNWJlZDQ2YTEzZTRkNmM2MWFiOTlmMQotU2l6ZSAobHVh
 ZmlsZXN5c3RlbS0xLjYuMy50YXIuZ3opID0gMzAzNzkgYnl0ZXMKLVNIQTEgKHBhdGNoLWFhKSA9
 IGMyODdhMTIwM2Y0YTg1ZTYxNmVmM2QzMTI3NmFhYmZiMGExZWQ4M2QKK1NIQTEgKGx1YWZpbGVz
 eXN0ZW0tMS43LjAudGFyLmd6KSA9IDkxMGRlMDk1OWZmNzI3MDNiMjg0YzI2NzgzOTc5YjY2M2M0
 ZGMwZDIKK1JNRDE2MCAobHVhZmlsZXN5c3RlbS0xLjcuMC50YXIuZ3opID0gNjc3MGQyNWYxZDA5
 MjhjMzQ3NTYwNDI1ZDdjNTc1ODc4ODAzOGZkOQorU0hBNTEyIChsdWFmaWxlc3lzdGVtLTEuNy4w
 LnRhci5neikgPSBhMWQ0ZDA3Nzc3NmU1N2NkODc4ZGJjZDIxNjU2ZGExNDFlYTM2ODZjNTg3YjU0
 MjBhMmIwMzlhZWFmMDg2YjdlN2QwNWQ1MzFlZTFjYzJiYmQ3ZDA2NjYwZDEzMTViMDk1OTNlNTIx
 NDNmNjcxMWYwMzNjZThlZWNkYzU1MDUxMQorU2l6ZSAobHVhZmlsZXN5c3RlbS0xLjcuMC50YXIu
 Z3opID0gMzA4NzcgYnl0ZXMKK1NIQTEgKHBhdGNoLU1ha2VmaWxlKSA9IDg5OTMyYTdiNTgxMTdj
 MTMyZTY0NDRmNWE2N2YxY2QwNzdhMWQzN2MKK1NIQTEgKHBhdGNoLWNvbmZpZykgPSBkY2U0OGYx
 M2YyNDg0OGI4NjFkYjY0NmEyNWUzMmFjOGI1ODk3ZTBhCmRpZmYgLS1naXQgYy9kZXZlbC9sdWEt
 ZmlsZXN5c3RlbS9wYXRjaGVzL3BhdGNoLU1ha2VmaWxlIGkvZGV2ZWwvbHVhLWZpbGVzeXN0ZW0v
 cGF0Y2hlcy9wYXRjaC1NYWtlZmlsZQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw
 MDAwMC4uZWFmMGNiNTY0YzUKLS0tIC9kZXYvbnVsbAorKysgaS9kZXZlbC9sdWEtZmlsZXN5c3Rl
 bS9wYXRjaGVzL3BhdGNoLU1ha2VmaWxlCkBAIC0wLDAgKzEsMTYgQEAKKyROZXRCU0QkCisKKyAt
 IFJlbW92ZSBNQUNPU1hfREVQTE9ZTUVOVF9UQVJHRVQgYXMgaXQgd2lsbCBnaXZlIHByb2JsZW0g
 b24gbmV3ZXIgbWFjT1MKKyAgICAgYW5kIGFsc28gdGFyZ2V0aW5nL2J1aWxkaW5nIGZvciBjdXJy
 ZW50IG1hY09TIHZlcnNpb24gaXMgZW5vdWdoCisKKy0tLSBNYWtlZmlsZS5vcmlnCTIwMTgtMTIt
 MTUgMDQ6MDA6MzEuMDAwMDAwMDAwICswMDAwCisrKysgTWFrZWZpbGUKK0BAIC0xMiw3ICsxMiw3
 IEBAIE9CSlM9IHNyYy8kVC5vCisgbGliOiBzcmMvbGZzLnNvCisgCisgc3JjL2xmcy5zbzogJChP
 QkpTKQorLQlNQUNPU1hfREVQTE9ZTUVOVF9UQVJHRVQ9IjEwLjMiOyBleHBvcnQgTUFDT1NYX0RF
 UExPWU1FTlRfVEFSR0VUOyAkKENDKSAkKExJQl9PUFRJT04pIC1vIHNyYy9sZnMuc28gJChPQkpT
 KQorKwkkKENDKSAkKExJQl9PUFRJT04pIC1vIHNyYy9sZnMuc28gJChPQkpTKQorIAorIHRlc3Q6
 IGxpYgorIAlMVUFfQ1BBVEg9Li9zcmMvPy5zbyBsdWEgdGVzdHMvdGVzdC5sdWEKZGlmZiAtLWdp
 dCBjL2RldmVsL2x1YS1maWxlc3lzdGVtL3BhdGNoZXMvcGF0Y2gtYWEgaS9kZXZlbC9sdWEtZmls
 ZXN5c3RlbS9wYXRjaGVzL3BhdGNoLWNvbmZpZwpzaW1pbGFyaXR5IGluZGV4IDUwJQpyZW5hbWUg
 ZnJvbSBkZXZlbC9sdWEtZmlsZXN5c3RlbS9wYXRjaGVzL3BhdGNoLWFhCnJlbmFtZSB0byBkZXZl
 bC9sdWEtZmlsZXN5c3RlbS9wYXRjaGVzL3BhdGNoLWNvbmZpZwppbmRleCA5ZGMzMzczZDZmOC4u
 YTY3YjEyNTEyY2QgMTAwNjQ0Ci0tLSBjL2RldmVsL2x1YS1maWxlc3lzdGVtL3BhdGNoZXMvcGF0
 Y2gtYWEKKysrIGkvZGV2ZWwvbHVhLWZpbGVzeXN0ZW0vcGF0Y2hlcy9wYXRjaC1jb25maWcKQEAg
 LTEsOSArMSwxMSBAQAogJE5ldEJTRDogcGF0Y2gtYWEsdiAxLjIgMjAxMy8wOS8xMyAxMjowOToz
 NyBmaGFqbnkgRXhwICQKIAotRml4IGRlZmF1bHQgZGlyZWN0b3J5IGxvY2F0aW9ucwotLS0tIGNv
 bmZpZy5vcmlnCTIwMTItMTAtMDQgMTQ6MjU6NTQuMDAwMDAwMDAwICswMDAwCistIEZpeCBkZWZh
 dWx0IGRpcmVjdG9yeSBsb2NhdGlvbnMKKy0gQ2hhbmdlIExJQl9PUFRJT04gdG8gc2V0IGxpbmtp
 bmcgZmxhZ3MgZm9yIHRoZSBzcGVjaWZpZWQgTHVhIHZlcnNpb24gZnJvbQorICAgIE1ha2VmaWxl
 IGFuZCBhbHNvIHNldCB0aGUgcmlnaHQgbmFtZSBmb3IgdGhlIGxpYnJhcnkgb24gbWFjT1MKKy0t
 LSBjb25maWcub3JpZwkyMDE3LTA5LTE1IDIzOjA3OjMzLjAwMDAwMDAwMCArMDAwMAogKysrIGNv
 bmZpZwotQEAgLTEsMTAgKzEsMTAgQEAKK0BAIC0xLDIyICsxLDI3IEBACiAgIyBJbnN0YWxsYXRp
 b24gZGlyZWN0b3JpZXMKICAKICAjIERlZmF1bHQgaW5zdGFsbGF0aW9uIHByZWZpeApAQCAtMTYs
 NyArMTgsMTggQEAgRml4IGRlZmF1bHQgZGlyZWN0b3J5IGxvY2F0aW9ucwogIAogICMgTHVhIGlu
 Y2x1ZGVzIGRpcmVjdG9yeQogIExVQV9JTkM9ICQoUFJFRklYKS9pbmNsdWRlCi1AQCAtMTYsNyAr
 MTYsNyBAQCBMSUJfT1BUSU9OPSAtc2hhcmVkICNmb3IgTGludXgKKyAKKyAjIE9TIGRlcGVuZGVu
 dAorLUxJQl9PUFRJT049IC1zaGFyZWQgI2ZvciBMaW51eAorLSNMSUJfT1BUSU9OPSAtYnVuZGxl
 IC11bmRlZmluZWQgZHluYW1pY19sb29rdXAgI2ZvciBNYWNPUyBYCisraWZlcSAoJChzaGVsbCB1
 bmFtZSAtcyAyPi9kZXYvbnVsbCksIERhcndpbikKKysjIGZvciBtYWNPUworK0xJQl9PUFRJT04r
 PSAtTCQoUFJFRklYKS9saWIgLWxsdWEkKExVQV9WRVJTKSAtbG0gLXNoYXJlZCAtaW5zdGFsbF9u
 YW1lICQoUFJFRklYKS8kKExVQV9DRElSKS8kKG5vdGRpciAkQCkKKytlbHNlCisrIyBmb3IgTGlu
 dXggJiBvdGhlciB1bml4CisrTElCX09QVElPTis9IC1MJChQUkVGSVgpL2xpYiAtbGx1YSR7TFVB
 X1ZFUlN9IC1sbSAtc2hhcmVkCisrZW5kaWYKKyAKICBMSUJOQU1FPSAkVC5zby4kVgogIAogICMg
 Q29tcGlsYXRpb24gZGlyZWN0aXZlcwo=
 --0000000000003ffc98057e8f6ee2--

State-Changed-From-To: feedback->open
State-Changed-By: leot@NetBSD.org
State-Changed-When: Sat, 05 Jan 2019 13:47:48 +0000
State-Changed-Why:
Feedback provided.


State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Tue, 28 May 2019 20:44:23 +0000
State-Changed-Why:
Committed, thanks!
I agree, pkgconfig is better. I felt obligated to add it, because I needed the RPATH specified.
Also lets us avoid using -llua -lm, because -lm is already mentioned by pkgconfig --libs lua-5.2.


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53787 CVS commit: pkgsrc/devel/lua-filesystem
Date: Tue, 28 May 2019 20:43:04 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Tue May 28 20:43:04 UTC 2019

 Modified Files:
 	pkgsrc/devel/lua-filesystem: Makefile distinfo
 Added Files:
 	pkgsrc/devel/lua-filesystem/patches: patch-Makefile patch-config
 Removed Files:
 	pkgsrc/devel/lua-filesystem/patches: patch-aa

 Log Message:
 lua-filesystem: update to 1.7.0

 Update provided by Jonathan Buschmann in PR pkg/53787.
 I added some pkgconfig invocations, because otherwise it was linking
 to lua without the RPATH to liblua.
 Added a test target.

 Version 1.7.0 [15/Sep/2017]

         symlinkattributes function now provides 'target' field, containing name of the file that the symlink points to.
         attributes, symlinkattributes, touch, mkdir, and rmdir functions now return system-dependent error code as the third value on error.
         Fixed detection of closed files for Lua 5.2+ in setmode, lock, and unlock functions.
         Fixed various compiler warnings.
 s: ----------------------------------------------------------------------


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.11 pkgsrc/devel/lua-filesystem/Makefile
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/devel/lua-filesystem/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/devel/lua-filesystem/patches/patch-Makefile \
     pkgsrc/devel/lua-filesystem/patches/patch-config
 cvs rdiff -u -r1.2 -r0 pkgsrc/devel/lua-filesystem/patches/patch-aa

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search