NetBSD Problem Report #53829

From www@NetBSD.org  Thu Jan  3 10:51:58 2019
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 360587A103
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  3 Jan 2019 10:51:58 +0000 (UTC)
Message-Id: <20190103105157.5E7267A1E3@mollari.NetBSD.org>
Date: Thu,  3 Jan 2019 10:51:57 +0000 (UTC)
From: bsiegert@NetBSD.org
Reply-To: bsiegert@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: multimedia/ffmpeg2 is incompatible with OpenSSL 1.1
X-Send-Pr-Version: www-1.0

>Number:         53829
>Category:       pkg
>Synopsis:       multimedia/ffmpeg2 is incompatible with OpenSSL 1.1
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 03 10:55:00 +0000 2019
>Closed-Date:    Sun May 24 10:32:17 +0000 2020
>Last-Modified:  Sun May 24 10:32:17 +0000 2020
>Originator:     Benny Siegert
>Release:        pkgsrc-current as of 2019-01-02
>Organization:
The NetBSD Foundation
>Environment:
NetBSD shiso.mirbsd.org 8.99.27 NetBSD 8.99.27 (LARGEFONT) #2: Mon Dec 10 19:59:30 CET 2018  bsiegert@shiso.mirbsd.org:/usr/obj/sys/arch/amd64/compile/LARGEFONT amd64
>Description:
ffmpeg2 (ffmpeg2-2.8.14nb7) has the "openssl" option enabled by default.
I have a patch to configure so that OpenSSL is found at all.
However, then, building fails with the following error:

ibavformat/rtmpdh.c: In function 'ff_dh_init':
libavformat/rtmpdh.c:260:14: error: dereferencing pointer to incomplete type 'FF_DH {aka struct dh_st}'
     bn_new(dh->g);
              ^
libavformat/rtmpdh.c:171:37: note: in definition of macro 'bn_new'
 #define bn_new(bn)                  bn = BN_new()
                                     ^~

>How-To-Repeat:
cd pkgsrc/multimedia/ffmpeg2
make PKG_OPTIONS.ffmpeg2=openssl
>Fix:
I remember that this is a common compatibility issue when moving to OpenSSL 1.1. Some of you probably know better how to patch this than I do :)

>Release-Note:

>Audit-Trail:
From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53829 CVS commit: pkgsrc/multimedia/ffmpeg2
Date: Thu, 3 Jan 2019 11:56:09 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Thu Jan  3 11:56:09 UTC 2019

 Modified Files:
 	pkgsrc/multimedia/ffmpeg2: Makefile distinfo options.mk
 	pkgsrc/multimedia/ffmpeg2/patches: patch-configure
 Added Files:
 	pkgsrc/multimedia/ffmpeg2/patches: patch-libavcodec_x86_ac3dsp__init.c
 Removed Files:
 	pkgsrc/multimedia/ffmpeg2/patches: patch-libavcodec_x86_ac3dsp_init.c

 Log Message:
 ffmpeg2: fix configuring with OpenSSL 1.1.

 The build still fails, thus remove openssl from the list of suggested
 options.
 Rename a patch.
 Bump revision.
 PR pkg/53829.


 To generate a diff of this commit:
 cvs rdiff -u -r1.47 -r1.48 pkgsrc/multimedia/ffmpeg2/Makefile
 cvs rdiff -u -r1.56 -r1.57 pkgsrc/multimedia/ffmpeg2/distinfo
 cvs rdiff -u -r1.14 -r1.15 pkgsrc/multimedia/ffmpeg2/options.mk
 cvs rdiff -u -r1.10 -r1.11 pkgsrc/multimedia/ffmpeg2/patches/patch-configure
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/multimedia/ffmpeg2/patches/patch-libavcodec_x86_ac3dsp__init.c
 cvs rdiff -u -r1.2 -r0 \
     pkgsrc/multimedia/ffmpeg2/patches/patch-libavcodec_x86_ac3dsp_init.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: nia@NetBSD.org
State-Changed-When: Sun, 24 May 2020 10:32:17 +0000
State-Changed-Why:
this was fixed, and we no longer build ffmpeg with openssl
but rather gnutls to avoid licensing conflicts


>Unformatted:

Home	PR Database Search