NetBSD Problem Report #53902

From msaitoh@execsw.org  Wed Jan 23 03:22:51 2019
Return-Path: <msaitoh@execsw.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E32917A1AE
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 23 Jan 2019 03:22:51 +0000 (UTC)
Message-Id: <20190123032248.13ECC8051D3@vslock.execsw.org>
Date: Wed, 23 Jan 2019 12:22:48 +0900 (JST)
From: msaitoh@execsw.org
Reply-To: msaitoh@execsw.org
To: gnats-bugs@NetBSD.org
Subject: Some drivers do infinite loop in mii_{read,write}reg().
X-Send-Pr-Version: 3.95

>Number:         53902
>Category:       kern
>Synopsis:       Some drivers do infinite loop in mii_{read,write}reg().
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 23 03:25:00 +0000 2019
>Originator:     msaitoh@execsw.org
>Release:        all
>Organization:
>Description:
	I noticed that the following code do infinite loop in the MII register
	read/wirte function. If it accesses an unimplemented PHY register,
	it will hang. It should be fixed:

		arm/at91/at91emac.c
		arm/ep93xx/epe.c
		arm/omap/omapl1x_emac.c
		mips/ralink/ralink_eth.c
		arch/powerpc/booke/dev/pq3etsec.c(read)
		dev/cadence/if_cemac.c
		dev/ic/lan9118.c

>How-To-Repeat:
	Attach a PHY driver which accesses an unimplemented PHY register.
>Fix:
	Add timeout.

>Unformatted:
 System: *
 Architecture: *
 Machine: *

Home	PR Database Search