NetBSD Problem Report #53908

From www@NetBSD.org  Fri Jan 25 13:27:12 2019
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 95A257A18E
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 25 Jan 2019 13:27:12 +0000 (UTC)
Message-Id: <20190125132711.8B8D27A232@mollari.NetBSD.org>
Date: Fri, 25 Jan 2019 13:27:11 +0000 (UTC)
From: raschi.alex@gmail.com
Reply-To: raschi.alex@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Building -current with MKKERBEROS=no and MKKMOD=no fails
X-Send-Pr-Version: www-1.0

>Number:         53908
>Category:       misc
>Synopsis:       Building -current with MKKERBEROS=no and MKKMOD=no fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 25 13:30:00 +0000 2019
>Last-Modified:  Fri Jan 25 18:35:01 +0000 2019
>Originator:     Alex Raschi
>Release:        current
>Organization:
>Environment:
NetBSD server0 8.99.30 NetBSD 8.99.30 (LOCAL) amd64
>Description:
Trying to build a very minimal base results in two build errors. I think
that MKKERBEROS=no and MKKMOD=no cause the two issues. The first error
is related to openssh, sys/socket.h doesn't get included. The second is:

=======  2 extra files in DESTDIR  =========
Files in DESTDIR but missing from flist.
File is obsolete or flist is out of date ?
------------------------------------------
./usr/tests/kernel/threadpool_tester
./usr/tests/kernel/threadpool_tester/threadpool_tester.kmod
=========  end of 2 extra files  ===========

This patch fixes the build for me:

Index: crypto/external/bsd/openssh/dist/auth-pam.c
===================================================================
RCS file: /cvsroot/src/crypto/external/bsd/openssh/dist/auth-pam.c,v
retrieving revision 1.17
diff -r1.17 auth-pam.c
69a70,72
> #ifdef USE_PAM
> #include <sys/socket.h>
> #endif
Index: tests/kernel/Makefile
===================================================================
RCS file: /cvsroot/src/tests/kernel/Makefile,v
retrieving revision 1.55
diff -r1.55 Makefile
27a28
> .if ${MKKMOD} != "no"
28a30
> .endif

If i understood correctly threadpool_tester shouldn't be built unless
modules are enabled too [1]. sys/socket.h get included by kerberos when
enabled, if the latter is disabled but at least pam is enabled we need
to include the header.

[1] http://cvsweb.netbsd.org/bsdweb.cgi/src/distrib/sets/lists/tests/module.mi?rev=1.14&content-type=text/x-cvsweb-markup&only_with_tag=MAIN
>How-To-Repeat:
Clone -current with cvs and build with:

./build.sh -j 4 -m i386 -O ../obj/i386 -T ../tools/amd64 distribution kernel=LOCAL

or something similar, i don't think that matters anyway.

src related part of /etc/mk.conf:

COPTS+=-pipe
MAKEVERBOSE=0
MKBSDTAR=yes
MKCATPAGES=no
MKCOMPAT=no
MKCTF=no
MKDTRACE=no
MKGDB=no
MKHESIOD=no
MKHTML=no
MKINFO=no
MKIPFILTER=no
MKISCSI=no
MKKERBEROS=no
MKKMOD=no
MKLDAP=no
MKLVM=no
MKMANZ=yes
MKMDNS=no
MKPF=no
MKPIE=yes
MKPIGZGZIP=yes
MKRELRO=full
MKREPRO=yes
MKRUMP=no
MKSKEY=no
MKUNBOUND=no
MKUNPRIVED=yes
MKUPDATE=yes
MKYP=no
MKZFS=no
USE_FORT=yes
USE_SSP=yes
USE_PIGZGZIP=yes
MKBSDGREP=yes
MKDTC=no
>Fix:
Apply the patch above and rebuild, remove threadpool_tester dirs if
necessary.

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/53908: Building -current with MKKERBEROS=no and MKKMOD=no
 fails
Date: Fri, 25 Jan 2019 14:35:40 +0100

 The threadpool test kernel module should not live under src/tests at all,
 we should move it to sys/modules.

 src/tests is for the ATF test suite.

 Martin

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53908 CVS commit: src/crypto/external/bsd/openssh/dist
Date: Fri, 25 Jan 2019 09:29:05 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jan 25 14:29:05 UTC 2019

 Modified Files:
 	src/crypto/external/bsd/openssh/dist: auth-pam.c

 Log Message:
 PR/53908: Alex Raschi: Include <sys/socket.h> for socketpair(2)


 To generate a diff of this commit:
 cvs rdiff -u -r1.17 -r1.18 src/crypto/external/bsd/openssh/dist/auth-pam.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, misc-bug-people@netbsd.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, raschi.alex@gmail.com
Cc: 
Subject: Re: misc/53908: Building -current with MKKERBEROS=no and MKKMOD=no fails
Date: Fri, 25 Jan 2019 09:32:28 -0500

 On Jan 25,  1:40pm, martin@duskware.de (Martin Husemann) wrote:
 -- Subject: Re: misc/53908: Building -current with MKKERBEROS=no and MKKMOD=n

 |  The threadpool test kernel module should not live under src/tests at all,
 |  we should move it to sys/modules.
 |  
 |  src/tests is for the ATF test suite.

 You mean src/tests/kernel -> src/test/modules. Yes, I have all the changes,
 I am doing a test build.

 christos

From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/53908: Building -current with MKKERBEROS=no and MKKMOD=no
 fails
Date: Fri, 25 Jan 2019 17:05:02 +0000

 On Fri, Jan 25, 2019 at 01:30:00PM +0000, raschi.alex@gmail.com wrote:
  > Trying to build a very minimal base results in two build errors. I think
  > that MKKERBEROS=no and MKKMOD=no cause the two issues. The first error
  > is related to openssh, sys/socket.h doesn't get included. The second is:
  >    :
  > > #ifdef USE_PAM
  > > #include <sys/socket.h>
  > > #endif

 Be warned that as far as I know PR 40599 remains open and building
 with MKKERBEROS=no and MKPAM=yes will give you a system you can't log
 in to.

 -- 
 David A. Holland
 dholland@netbsd.org

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53908 CVS commit: src
Date: Fri, 25 Jan 2019 13:33:59 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jan 25 18:33:59 UTC 2019

 Modified Files:
 	src/distrib/sets/lists/tests: mi module.mi
 	src/tests/kernel: Makefile
 	src/tests/modules: Makefile
 Added Files:
 	src/tests/modules/threadpool_tester: Makefile threadpool_tester.c
 Removed Files:
 	src/tests/kernel: t_threadpool.sh

 Log Message:
 PR/53908: Alex Raschi: Test that require modules belong in modules; move the
 threadpool test from kernel to modules.


 To generate a diff of this commit:
 cvs rdiff -u -r1.803 -r1.804 src/distrib/sets/lists/tests/mi
 cvs rdiff -u -r1.14 -r1.15 src/distrib/sets/lists/tests/module.mi
 cvs rdiff -u -r1.55 -r1.56 src/tests/kernel/Makefile
 cvs rdiff -u -r1.2 -r0 src/tests/kernel/t_threadpool.sh
 cvs rdiff -u -r1.13 -r1.14 src/tests/modules/Makefile
 cvs rdiff -u -r0 -r1.1 src/tests/modules/threadpool_tester/Makefile \
     src/tests/modules/threadpool_tester/threadpool_tester.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53908 CVS commit: src/tests/modules
Date: Fri, 25 Jan 2019 13:34:45 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jan 25 18:34:45 UTC 2019

 Added Files:
 	src/tests/modules: t_threadpool.sh

 Log Message:
 PR/53908: Alex Raschi: One more file needs to move.


 To generate a diff of this commit:
 cvs rdiff -u -r0 -r1.1 src/tests/modules/t_threadpool.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search