NetBSD Problem Report #53956
From he@smistad.uninett.no Thu Feb 7 13:36:45 2019
Return-Path: <he@smistad.uninett.no>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 6456F7A166
for <gnats-bugs@gnats.NetBSD.org>; Thu, 7 Feb 2019 13:36:45 +0000 (UTC)
Message-Id: <20190207133637.AF26143F3DB@smistad.uninett.no>
Date: Thu, 7 Feb 2019 14:36:37 +0100 (CET)
From: he@NetBSD.org
Reply-To: he@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: raidframe fails to create raid set
X-Send-Pr-Version: 3.95
>Number: 53956
>Category: bin
>Synopsis: raidframe fails to create raid set
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: bin-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Feb 07 13:40:00 +0000 2019
>Closed-Date: Mon Apr 08 18:34:13 +0000 2019
>Last-Modified: Mon Apr 08 18:34:13 +0000 2019
>Originator: he@NetBSD.org
>Release: NetBSD 8.0
>Organization:
I try...
>Environment:
System: NetBSD 8.0 NetBSD 8.0 (GENERIC) #0: Tue Jul 17 14:59:51 UTC 2018 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
I'm trying to configure raidframe on a "new" system, having
booted from the USB image. I've labeled the disks using
disklabel:
# disklabel wd0
# /dev/rwd0:
type: ESDI
disk: MB2000EBZQC
label: fictitious
flags:
bytes/sector: 512
sectors/track: 63
tracks/cylinder: 16
sectors/cylinder: 1008
cylinders: 3876021
total sectors: 3907029168
rpm: 3600
interleave: 1
trackskew: 0
cylinderskew: 0
headswitch: 0 # microseconds
track-to-track seek: 0 # microseconds
drivedata: 0
8 partitions:
# size offset fstype [fsize bsize cpg/sgs]
a: 2098176 0 4.2BSD 1024 8192 2000 # (Cyl. 0 - 2081*)
d: 3907029168 0 unused 0 0 # (Cyl. 0 - 3876020)
e: 3904930992 2098176 RAID # (Cyl. 2081*- 3876020)
# disklabel wd1
# /dev/rwd1:
type: ESDI
disk: MB2000EBZQC
label: fictitious
flags:
bytes/sector: 512
sectors/track: 63
tracks/cylinder: 16
sectors/cylinder: 1008
cylinders: 3876021
total sectors: 3907029168
rpm: 3600
interleave: 1
trackskew: 0
cylinderskew: 0
headswitch: 0 # microseconds
track-to-track seek: 0 # microseconds
drivedata: 0
8 partitions:
# size offset fstype [fsize bsize cpg/sgs]
a: 2098176 0 4.2BSD 1024 8192 2000 # (Cyl. 0 - 2081*)
d: 3907029168 0 unused 0 0 # (Cyl. 0 - 3876020)
e: 3904930992 2098176 RAID # (Cyl. 2081*- 3876020)
and I've prepared a raid config file:
# ed /tmp/raid0.conf
/tmp/raid0.conf: No such file or directory
a
START array
1 2 0
START disks
/dev/wd0e
/dev/wd1e
START layout
32 1 1 0
START queue
fifo 100
.
w
96
q
#
However, when using this with raidctl, it fails, and attempts
at initializing the raid also fails:
# raidctl -C /tmp/raid0.conf raid0
Hosed component: /dev/wd1e
Hosed component: /dev/wd0e
raid0: Ignoring /dev/wd0e
raid0: Component /dev/wd1e being configured at col: 1
Column: 1883401063 Num Columns: 1131244131
Version: 1934767458 Serial Number: 1095391567 Mod Counter: 1413903690
Clean: Yes Status: 828011592
/dev/wd1e has a different serial number: -427209529 1095391567
Row out of alignment for: /dev/wd1e
Column out of alignment for: /dev/wd1e
Number of columns do not match for: /dev/wd1e
raid0: There were fatal errors
raid0: Fatal errors being ignored.
raid0: RAID Level 0
raid0: Components: /dev/wd0e[**FAILED**] /dev/wd1e[**FAILED**]
raid0: Total Sectors: 7809861824 (3813409 MB)
raid0: failed to create a dag. Too many component failures.
raid0d: error reading fsbn 0 (raid0 bn 0; cn 0 tn 0 sn 0)
raid0: failed to create a dag. Too many component failures.
raid0d: error reading fsbn 0 of 0-31 (raid0 bn 0; cn 0 tn 0 sn 0)
raid0: failed to create a dag. Too many component failures.
raid0d: error reading fsbn 1 (raid0 bn 1; cn 0 tn 0 sn 1)
# raidctl -I 11223344 raid0
raid0: failed to create a dag. Too many component failures.
raid0d: error reading fsbn 0 (raid0 bn 0; cn 0 tn 0 sn 0)
#
# raidctl -iv raid0
raid0: failed to create a dag. Too many component failures.
raid0d: error reading fsbn 0 (raid0 bn 0; cn 0 tn 0 sn 0)
Initiating re-wite of parity
Parity Re-write status:
# raidctl -s raid0
raid0: failed to create a dag. Too many component failures.
raid0d: error reading fsbn 0 (raid0 bn 0; cn 0 tn 0 sn 0)
Components:
/dev/wd0e: failed
/dev/wd1e: failed
No spares.
/dev/wd0e status is: failed. Skipping label.
/dev/wd1e status is: failed. Skipping label.
Parity status: clean
Reconstruction is 100% complete.
Parity Re-write is 100% complete.
Copyback is 100% complete.
#
The disks are readable just fine:
# dd if=/dev/rwd0d of=/dev/null bs=32k
load: 0.08 cmd: dd 45 [physio] 0.02u 0.17s 0% 1000k
6243+0 records in
6243+0 records out
204570624 bytes transferred in 2.218 secs (92232021 bytes/sec)
load: 0.08 cmd: dd 45 [physio] 0.03u 0.35s 2% 1044k
12558+0 records in
12558+0 records out
411500544 bytes transferred in 4.139 secs (99420281 bytes/sec)
load: 0.08 cmd: dd 45 [physio] 0.04u 0.55s 2% 1044k
19397+0 records in
19397+0 records out
635600896 bytes transferred in 6.221 secs (102170213 bytes/sec)
load: 0.15 cmd: dd 45 [physio] 0.06u 0.70s 2% 1044k
25108+0 records in
25108+0 records out
822738944 bytes transferred in 7.952 secs (103463146 bytes/sec)
^C30090+0 records in
30090+0 records out
985989120 bytes transferred in 9.464 secs (104183127 bytes/sec)
#
# dd if=/dev/rwd0e count=1000 bs=32k of=/dev/null
1000+0 records in
1000+0 records out
32768000 bytes transferred in 0.326 secs (100515337 bytes/sec)
# dd if=/dev/rwd1e count=1000 bs=32k of=/dev/null
1000+0 records in
1000+0 records out
32768000 bytes transferred in 0.327 secs (100207951 bytes/sec)
#
>How-To-Repeat:
Try to create a fresh raid set using the 8.0 USB install
image; watch it fail.
>Fix:
I do not know, sorry.
>Release-Note:
>Audit-Trail:
From: Havard Eidnes <he@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: bin/53956: raidframe fails to create raid set
Date: Thu, 07 Feb 2019 15:36:56 +0100 (CET)
BTW,
the 7.2_STABLE kernel + utils manages to create the raid set just
fine (OK, this is raid1, previous attempt was raid0, but I did
also try raid1 with 8.0 which also failed):
# ed /tmp/raid0.conf
/tmp/raid0.conf: No such file or directory
a
START array
1 2 0
START disks
/dev/wd0e
/dev/wd1e
START layout
32 1 1 1
START queue
fifo 100
.
w
96
q
# raidctl -C /tmp/raid0.conf raid0
Hosed component: /dev/wd1e
Hosed component: /dev/wd0e
raid0: Component /dev/wd0e being configured at col: 0
Column: -396846104 Num Columns: 159780
Version: -1991704577 Serial Number: -427209529 Mod Counter: -403409944
Clean: Yes Status: 5239572
/dev/wd0e has a different modification count: 1413903690 -403409944
Row out of alignment for: /dev/wd0e
Column out of alignment for: /dev/wd0e
Number of columns do not match for: /dev/wd0e
raid0: Component /dev/wd1e being configured at col: 1
Column: 1883401063 Num Columns: 1131244131
Version: 1934767458 Serial Number: 1095391567 Mod Counter: 1413903690
Clean: Yes Status: 828011592
/dev/wd1e has a different serial number: -427209529 1095391567
Row out of alignment for: /dev/wd1e
Column out of alignment for: /dev/wd1e
Number of columns do not match for: /dev/wd1e
raid0: There were fatal errors
raid0: Fatal errors being ignored.
raid0: RAID Level 1
raid0: Components: /dev/wd0e /dev/wd1e
raid0: Total Sectors: 3904930912 (1906704 MB)
# raidctl -I 112233456 raid0
# raidctl -iv raid0
Initiating re-write of parity
Parity Re-write status:
0% | | ETA: 549:41:00 |
^C
# raidctl -s raid0
Components:
/dev/wd0e: optimal
/dev/wd1e: optimal
No spares.
Component label for /dev/wd0e:
Row: 0, Column: 0, Num Rows: 1, Num Columns: 2
Version: 2, Serial Number: 112233456, Mod Counter: 1413903699
Clean: No, Status: 0
sectPerSU: 32, SUsPerPU: 1, SUsPerRU: 1
Queue size: 100, blocksize: 512, numBlocks: 3904930912
RAID Level: 1
Autoconfig: No
Root partition: No
Last configured as: raid0
Component label for /dev/wd1e:
Row: 0, Column: 1, Num Rows: 1, Num Columns: 2
Version: 2, Serial Number: 112233456, Mod Counter: 1413903699
Clean: No, Status: 0
sectPerSU: 32, SUsPerPU: 1, SUsPerRU: 1
Queue size: 100, blocksize: 512, numBlocks: 3904930912
RAID Level: 1
Autoconfig: No
Root partition: No
Last configured as: raid0
Parity status: DIRTY
Reconstruction is 100% complete.
Parity Re-write is 0% complete.
Copyback is 100% complete.
#
# uname -a
NetBSD 7.2_STABLE NetBSD 7.2_STABLE (GENERIC.201902040720Z) amd64
#
From: Greg Oster <oster@netbsd.org>
To: he@NetBSD.org
Cc: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: bin/53956: raidframe fails to create raid set
Date: Thu, 7 Feb 2019 08:53:39 -0600
On Thu, 7 Feb 2019 13:40:00 +0000 (UTC)
he@NetBSD.org wrote:
> >Number: 53956
> >Category: bin
> >Synopsis: raidframe fails to create raid set
> >Confidential: no
> >Severity: serious
> >Priority: medium
> >Responsible: bin-bug-people
> >State: open
> >Class: sw-bug
> >Submitter-Id: net
> >Arrival-Date: Thu Feb 07 13:40:00 +0000 2019
> >Originator: he@NetBSD.org
> >Release: NetBSD 8.0
> >Organization:
> I try...
> >Environment:
> System: NetBSD 8.0 NetBSD 8.0 (GENERIC) #0: Tue Jul 17 14:59:51 UTC
> 2018
> mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC
> amd64 Architecture: x86_64 Machine: amd64
> >Description:
> I'm trying to configure raidframe on a "new" system, having
> booted from the USB image. I've labeled the disks using
> disklabel:
>
> # disklabel wd0
> # /dev/rwd0:
> type: ESDI
> disk: MB2000EBZQC
> label: fictitious
> flags:
> bytes/sector: 512
> sectors/track: 63
> tracks/cylinder: 16
> sectors/cylinder: 1008
> cylinders: 3876021
> total sectors: 3907029168
> rpm: 3600
> interleave: 1
> trackskew: 0
> cylinderskew: 0
> headswitch: 0 # microseconds
> track-to-track seek: 0 # microseconds
> drivedata: 0
>
> 8 partitions:
> # size offset fstype [fsize bsize cpg/sgs]
> a: 2098176 0 4.2BSD 1024 8192 2000 # (Cyl. 0
> - 2081*) d: 3907029168 0 unused 0 0 #
> (Cyl. 0 - 3876020) e: 3904930992 2098176
> RAID # (Cyl. 2081*- 3876020) # disklabel wd1
> # /dev/rwd1:
> type: ESDI
> disk: MB2000EBZQC
> label: fictitious
> flags:
> bytes/sector: 512
> sectors/track: 63
> tracks/cylinder: 16
> sectors/cylinder: 1008
> cylinders: 3876021
> total sectors: 3907029168
> rpm: 3600
> interleave: 1
> trackskew: 0
> cylinderskew: 0
> headswitch: 0 # microseconds
> track-to-track seek: 0 # microseconds
> drivedata: 0
>
> 8 partitions:
> # size offset fstype [fsize bsize cpg/sgs]
> a: 2098176 0 4.2BSD 1024 8192 2000 # (Cyl. 0
> - 2081*) d: 3907029168 0 unused 0 0 #
> (Cyl. 0 - 3876020) e: 3904930992 2098176
> RAID # (Cyl. 2081*- 3876020)
>
> and I've prepared a raid config file:
>
> # ed /tmp/raid0.conf
> /tmp/raid0.conf: No such file or directory
> a
> START array
> 1 2 0
>
> START disks
> /dev/wd0e
> /dev/wd1e
>
> START layout
> 32 1 1 0
>
> START queue
> fifo 100
> .
> w
> 96
> q
> #
>
> However, when using this with raidctl, it fails, and attempts
> at initializing the raid also fails:
>
> # raidctl -C /tmp/raid0.conf raid0
> Hosed component: /dev/wd1e
> Hosed component: /dev/wd0e
> raid0: Ignoring /dev/wd0e
[snip]
> raid0: Components: /dev/wd0e[**FAILED**] /dev/wd1e[**FAILED**]
Somehow cftPtr->force is not set to 1 as it should be in this case.
Later...
Greg Oster
From: christos@zoulas.com (Christos Zoulas)
To: Greg Oster <oster@netbsd.org>, he@NetBSD.org
Cc: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: bin/53956: raidframe fails to create raid set
Date: Thu, 7 Feb 2019 12:28:44 -0500
On Feb 7, 8:53am, oster@netbsd.org (Greg Oster) wrote:
-- Subject: Re: bin/53956: raidframe fails to create raid set
| On Thu, 7 Feb 2019 13:40:00 +0000 (UTC)
| he@NetBSD.org wrote:
|
| > >Number: 53956
| > >Category: bin
| > >Synopsis: raidframe fails to create raid set
| > >Confidential: no
| > >Severity: serious
| > >Priority: medium
| > >Responsible: bin-bug-people
| > >State: open
| > >Class: sw-bug
| > >Submitter-Id: net
| > >Arrival-Date: Thu Feb 07 13:40:00 +0000 2019
| > >Originator: he@NetBSD.org
| > >Release: NetBSD 8.0
| > >Organization:
| > I try...
| > >Environment:
| > System: NetBSD 8.0 NetBSD 8.0 (GENERIC) #0: Tue Jul 17 14:59:51 UTC
| > 2018
| > mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC
| > amd64 Architecture: x86_64 Machine: amd64
| > >Description:
| > I'm trying to configure raidframe on a "new" system, having
| > booted from the USB image. I've labeled the disks using
| > disklabel:
| >
| > # disklabel wd0
| > # /dev/rwd0:
| > type: ESDI
| > disk: MB2000EBZQC
| > label: fictitious
| > flags:
| > bytes/sector: 512
| > sectors/track: 63
| > tracks/cylinder: 16
| > sectors/cylinder: 1008
| > cylinders: 3876021
| > total sectors: 3907029168
| > rpm: 3600
| > interleave: 1
| > trackskew: 0
| > cylinderskew: 0
| > headswitch: 0 # microseconds
| > track-to-track seek: 0 # microseconds
| > drivedata: 0
| >
| > 8 partitions:
| > # size offset fstype [fsize bsize cpg/sgs]
| > a: 2098176 0 4.2BSD 1024 8192 2000 # (Cyl. 0
| > - 2081*) d: 3907029168 0 unused 0 0 #
| > (Cyl. 0 - 3876020) e: 3904930992 2098176
| > RAID # (Cyl. 2081*- 3876020) # disklabel wd1
| > # /dev/rwd1:
| > type: ESDI
| > disk: MB2000EBZQC
| > label: fictitious
| > flags:
| > bytes/sector: 512
| > sectors/track: 63
| > tracks/cylinder: 16
| > sectors/cylinder: 1008
| > cylinders: 3876021
| > total sectors: 3907029168
| > rpm: 3600
| > interleave: 1
| > trackskew: 0
| > cylinderskew: 0
| > headswitch: 0 # microseconds
| > track-to-track seek: 0 # microseconds
| > drivedata: 0
| >
| > 8 partitions:
| > # size offset fstype [fsize bsize cpg/sgs]
| > a: 2098176 0 4.2BSD 1024 8192 2000 # (Cyl. 0
| > - 2081*) d: 3907029168 0 unused 0 0 #
| > (Cyl. 0 - 3876020) e: 3904930992 2098176
| > RAID # (Cyl. 2081*- 3876020)
| >
| > and I've prepared a raid config file:
| >
| > # ed /tmp/raid0.conf
| > /tmp/raid0.conf: No such file or directory
| > a
| > START array
| > 1 2 0
| >
| > START disks
| > /dev/wd0e
| > /dev/wd1e
| >
| > START layout
| > 32 1 1 0
| >
| > START queue
| > fifo 100
| > .
| > w
| > 96
| > q
| > #
| >
| > However, when using this with raidctl, it fails, and attempts
| > at initializing the raid also fails:
| >
| > # raidctl -C /tmp/raid0.conf raid0
| > Hosed component: /dev/wd1e
| > Hosed component: /dev/wd0e
| > raid0: Ignoring /dev/wd0e
| [snip]
| > raid0: Components: /dev/wd0e[**FAILED**] /dev/wd1e[**FAILED**]
Can you dd some zeros in wd0e and wd1e and see if that changes the
situation?
christos
From: matthew green <mrg@eterna.com.au>
To: christos@zoulas.com (Christos Zoulas)
Cc: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org,
netbsd-bugs@netbsd.org, Greg Oster <oster@netbsd.org>, he@NetBSD.org
Subject: re: bin/53956: raidframe fails to create raid set
Date: Fri, 08 Feb 2019 11:20:43 +1100
> | > # raidctl -C /tmp/raid0.conf raid0
> | > Hosed component: /dev/wd1e
> | > Hosed component: /dev/wd0e
> | > raid0: Ignoring /dev/wd0e
> | [snip]
> | > raid0: Components: /dev/wd0e[**FAILED**] /dev/wd1e[**FAILED**]
>
> Can you dd some zeros in wd0e and wd1e and see if that changes the
> situation?
can you save the current contents as first! so we can debug
the problem i this turns out to be the cause..
.mrg.
From: Havard Eidnes <he@NetBSD.org>
To: mrg@eterna.com.au
Cc: christos@zoulas.com, gnats-bugs@NetBSD.org, netbsd-bugs@netbsd.org,
oster@netbsd.org
Subject: Re: bin/53956: raidframe fails to create raid set
Date: Fri, 08 Feb 2019 10:00:48 +0100 (CET)
>> | > # raidctl -C /tmp/raid0.conf raid0
>> | > Hosed component: /dev/wd1e
>> | > Hosed component: /dev/wd0e
>> | > raid0: Ignoring /dev/wd0e
>> | [snip]
>> | > raid0: Components: /dev/wd0e[**FAILED**] /dev/wd1e[**FAILED**]
>>
>> Can you dd some zeros in wd0e and wd1e and see if that changes the
>> situation?
>
> can you save the current contents as first! so we can debug
> the problem i this turns out to be the cause..
Hmm... The raid has now been created using the 7.2_STABLE kernel and
tools, and is presently undergoing initialization ("raidctl -i").
I suspect therefore that the initial content has been overwritten.
However, the point of the "-C" option to raidctl is that no matter the
contents on the drives (zeroed or "random"), any errors related to the
contents on the drives must be ignored, and the raid should be
created, as long as the components can be physically read or written
(I proved they could be read, and 7.2_STABLE certainly can write them,
so I don't see why 8.0 should fail to do so).
As you saw from the 7.2_STABLE transcript, "raidctl -C" spewed
basically the same sort of errors as on 8.0 ("hosed component", "row
out of alignment", "coloumn out of alignment" etc.), although some
error messages didn't come on 7.2_STABLE ("ignoring <component>",
"failed to create a dag. Too many component failures."), but on
7.2_STABLE those errors it did spew were ignored, while that didn't
happen on 8.0. Therefore, I lean towards Greg's explanation, that the
"ignore errors" flag has somehow become unset in 8.0 even though "-C"
is specified.
Hmm, this function was introduced in netbsd-8:
static void
rf_handle_hosed(RF_Raid_t *raidPtr, RF_Config_t *cfgPtr, int hosed_column,
int again)
{
printf("Hosed component: %s\n", &cfgPtr->devnames[0][hosed_column][0]);
if (!cfgPtr->force)
return;
/* we'll fail this component, as if there are
other major errors, we aren't forcing things
and we'll abort the config anyways */
if (again && raidPtr->Disks[hosed_column].status == rf_ds_failed)
return;
raidPtr->Disks[hosed_column].status = rf_ds_failed;
raidPtr->numFailures++;
raidPtr->status = rf_rs_degraded;
}
Compare this to the open-coded version in netbsd-7:
printf("Hosed component: %s\n",
&cfgPtr->devnames[0][hosed_column][0]);
if (!force) {
/* we'll fail this component, as if there are
other major errors, we arn't forcing things
and we'll abort the config anyways */
if (raidPtr->Disks[hosed_column].status != rf_ds_failed) {
raidPtr->Disks[hosed_column].status
= rf_ds_failed;
raidPtr->numFailures++;
raidPtr->status = rf_rs_degraded;
}
}
Am I reading this wrong, or shouldn't the test in rf_handle_hosed()
instead be
if (cfgPtr->force)
return;
i.e. the sense of the test is wrong?
Regards,
- Havard
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/53956 CVS commit: src/sys/dev/raidframe
Date: Fri, 8 Feb 2019 08:37:46 -0500
Module Name: src
Committed By: christos
Date: Fri Feb 8 13:37:46 UTC 2019
Modified Files:
src/sys/dev/raidframe: rf_disks.c
Log Message:
PR/53956: Havard Eidnes: raidframe fails to create raid set on disks.
The test to check if force was reversed when the code was factored out.
To generate a diff of this commit:
cvs rdiff -u -r1.89 -r1.90 src/sys/dev/raidframe/rf_disks.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Greg Oster <oster@netbsd.org>
To: Havard Eidnes <he@NetBSD.org>
Cc: mrg@eterna.com.au, christos@zoulas.com, gnats-bugs@NetBSD.org,
netbsd-bugs@netbsd.org
Subject: Re: bin/53956: raidframe fails to create raid set
Date: Fri, 8 Feb 2019 08:45:36 -0600
On Fri, 08 Feb 2019 10:00:48 +0100 (CET)
Havard Eidnes <he@NetBSD.org> wrote:
> Am I reading this wrong, or shouldn't the test in rf_handle_hosed()
> instead be
>
> if (cfgPtr->force)
> return;
>
> i.e. the sense of the test is wrong?
You are correct. Christos fixed it. The fix should be pulled up to
netbsd-8 and friends too...
Later...
Greg Oster
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/53956 CVS commit: [netbsd-8] src/sys/dev/raidframe
Date: Fri, 8 Feb 2019 16:03:04 +0000
Module Name: src
Committed By: martin
Date: Fri Feb 8 16:03:04 UTC 2019
Modified Files:
src/sys/dev/raidframe [netbsd-8]: rf_disks.c
Log Message:
Pull up following revision(s) (requested by christos in ticket #1183):
sys/dev/raidframe/rf_disks.c: revision 1.90
PR/53956: Havard Eidnes: raidframe fails to create raid set on disks.
The test to check if force was reversed when the code was factored out.
To generate a diff of this commit:
cvs rdiff -u -r1.89 -r1.89.8.1 src/sys/dev/raidframe/rf_disks.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Mon, 08 Apr 2019 18:34:13 +0000
State-Changed-Why:
Fix committed and pulled up.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home