NetBSD Problem Report #53958

From dholland@macaran.eecs.harvard.edu  Fri Feb  8 00:49:05 2019
Return-Path: <dholland@macaran.eecs.harvard.edu>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BF6927A1C9
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  8 Feb 2019 00:49:04 +0000 (UTC)
Message-Id: <20190208004834.15C1E6E2B6@macaran.eecs.harvard.edu>
Date: Thu,  7 Feb 2019 19:48:34 -0500 (EST)
From: dholland@eecs.harvard.edu
Reply-To: dholland@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: cannot turn off OVERRIDE_GNU_CONFIG_SCRIPTS
X-Send-Pr-Version: 3.95

>Number:         53958
>Category:       pkg
>Synopsis:       cannot turn off OVERRIDE_GNU_CONFIG_SCRIPTS
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 08 00:50:00 +0000 2019
>Last-Modified:  Sat Feb 09 16:55:00 +0000 2019
>Originator:     David Holland
>Release:        NetBSD 8.99.27 (20181205) pkgsrc 20190207
>Organization:
>Environment:
System: NetBSD macaran 8.99.27 NetBSD 8.99.27 (MACARAN) #50: Wed Dec 5 19:34:11 EST 2018 dholland@macaran:/usr/src/sys/arch/amd64/compile/MACARAN amd64
Architecture: x86_64
Machine: amd64
>Description:

mk/configure/configure.mk has a switch to turn on and off replacing
config.guess and config.sub: OVERRIDE_GNU_CONFIG_SCRIPTS. However, it
is tested with defined() and assigned unconditionally in
gnu-configure.mk, which is included immediately previously.

This is useless.

One needs this switch when building exotic toolchains (or the like)
that have custom patches to config.guess and config.sub: replacing
with the pkgsrc versions loses the patches and then the packages
involved can't configure as intended.

>How-To-Repeat:

>Fix:

Change it to test for yes or no. But this is kind of a can of worms --
should all the adjacent related variables be changed as well? And if
so, Someone(TM) needs to spend time tracking down all the uses to make
sure they set "yes" and not "#defined".

>Release-Note:

>Audit-Trail:
From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53958: cannot turn off OVERRIDE_GNU_CONFIG_SCRIPTS
Date: Fri, 8 Feb 2019 12:55:12 +0100

 On Fri, Feb 08, 2019 at 12:50:00AM +0000, dholland@eecs.harvard.edu wrote:
 > mk/configure/configure.mk has a switch to turn on and off replacing
 > config.guess and config.sub: OVERRIDE_GNU_CONFIG_SCRIPTS. However, it
 > is tested with defined() and assigned unconditionally in
 > gnu-configure.mk, which is included immediately previously.

 Just set OVERRIDE_DIRDEPTH=0.

 Joerg

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53958: cannot turn off OVERRIDE_GNU_CONFIG_SCRIPTS
Date: Sat, 9 Feb 2019 16:47:04 +0000

 On Fri, Feb 08, 2019 at 12:00:01PM +0000, Joerg Sonnenberger wrote:
  >  On Fri, Feb 08, 2019 at 12:50:00AM +0000, dholland@eecs.harvard.edu wrote:
  >  > mk/configure/configure.mk has a switch to turn on and off replacing
  >  > config.guess and config.sub: OVERRIDE_GNU_CONFIG_SCRIPTS. However, it
  >  > is tested with defined() and assigned unconditionally in
  >  > gnu-configure.mk, which is included immediately previously.
  >  
  >  Just set OVERRIDE_DIRDEPTH=0.

 That works as a workaround (except it needs to be -1, not 0) but we
 should still clean up the logic.

 -- 
 David A. Holland
 dholland@netbsd.org

>Unformatted:

Home	PR Database Search