NetBSD Problem Report #53975

From martin@duskware.de  Thu Feb 14 08:36:47 2019
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id F3BF67A154
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 14 Feb 2019 08:36:46 +0000 (UTC)
Message-Id: <20190214083637.EC0765CC81A@emmas.aprisoft.de>
Date: Thu, 14 Feb 2019 09:36:37 +0100 (CET)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: x11/mate-applets is broken
X-Send-Pr-Version: 3.95

>Number:         53975
>Category:       pkg
>Synopsis:       x11/mate-applets is broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    youri
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 14 08:40:00 +0000 2019
>Closed-Date:    
>Last-Modified:  Mon Jul 19 04:12:04 +0000 2021
>Originator:     Martin Husemann
>Release:        NetBSD 8.99.34
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD painkiller.duskware.de 8.99.34 NetBSD 8.99.34 (GENERIC64) #41: Mon Feb 11 16:51:45 CET 2019 martin@seven-days-to-the-wolves.aprisoft.de:/work/src/sys/arch/evbarm/compile/GENERIC64 evbarm
Architecture: aarch64
Machine: evbarm
>Description:

The x11/mate-applets pkg has multiple issues:

 1) the PLIST vars (cpufreq and batt) are not in the PLIST anymore,
    so building fails everywhere they are not selected
 2) the condition when to enable cpufreq may be wrong (unnecessarily
    too small list of NetBSD architectures)
 3) the pkg only will be able to build cpufreq support if there is
    a source tree at /usr/src, as by default it uses -I /usr/src/sys
    to search for cpufreq.h. This is the default for ACPIINC, a
    ac_subst_var, so should be properly set to "sys" (I guess)


>How-To-Repeat:

Try to build on non-x86 or check the pkg and configure script.

>Fix:

n/a

>Release-Note:

>Audit-Trail:
From: "David H. Gutteridge" <gutteridge@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53975 CVS commit: pkgsrc/x11/mate-applets
Date: Sat, 16 Feb 2019 07:22:49 +0000

 Module Name:	pkgsrc
 Committed By:	gutteridge
 Date:		Sat Feb 16 07:22:49 UTC 2019

 Modified Files:
 	pkgsrc/x11/mate-applets: PLIST

 Log Message:
 x11/mate-applets: reflect PLIST conditionals

 Address the first part of PR pkg/53975: add conditional PLIST variables
 for the "batt" and "cpufreq" options.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/x11/mate-applets/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: pkg-manager->youri
Responsible-Changed-By: gutteridge@NetBSD.org
Responsible-Changed-When: Tue, 12 Mar 2019 00:04:06 +0000
Responsible-Changed-Why:
Over to youri@ for the remainder of the PR.

From: "David H. Gutteridge" <david@gutteridge.ca>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/53975 (x11/mate-applets is broken)
Date: Tue, 12 Mar 2019 15:29:56 -0400

 jperkin@ suggested changing how PLIST conditionals are handled for this
 package (especially given how long the list is). His suggested approach
 is here:

 http://mail-index.netbsd.org/pkgsrc-changes/2019/02/16/msg187670.html

 Alternately, we could break out the cpufreq and battstat options into
 their own separate PLIST files, another common approach.

 Dave


State-Changed-From-To: open->feedback
State-Changed-By: nia@NetBSD.org
State-Changed-When: Sun, 24 May 2020 10:35:24 +0000
State-Changed-Why:
is this fixed?


State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 19 Jul 2021 04:12:04 +0000
State-Changed-Why:
doesn't appear so


>Unformatted:

Home	PR Database Search