NetBSD Problem Report #54418

From www@netbsd.org  Sun Jul 28 15:32:51 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 925247A162
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 28 Jul 2019 15:32:51 +0000 (UTC)
Message-Id: <20190728153250.920B67A1C0@mollari.NetBSD.org>
Date: Sun, 28 Jul 2019 15:32:50 +0000 (UTC)
From: clement.bouvier.europe@gmail.com
Reply-To: clement.bouvier.europe@gmail.com
To: gnats-bugs@NetBSD.org
Subject: audio/alure bad header directory naming  in PLIST under macos
X-Send-Pr-Version: www-1.0

>Number:         54418
>Category:       pkg
>Synopsis:       audio/alure bad header directory naming  in PLIST under macos
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    macos-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 28 15:35:00 +0000 2019
>Closed-Date:    Wed Oct 23 00:18:13 +0000 2019
>Last-Modified:  Wed Oct 23 00:20:01 +0000 2019
>Originator:     Clement Bouvier
>Release:        current
>Organization:
>Environment:
MacOS Mojave 10.14.6
>Description:
audio/alure does not use the correct directory for the header alure.h leading to PLIST error during install.
The error is also noticeable on joyent darwin pbulk build
(http://us-east.manta.joyent.com/pkgsrc/public/reports/Darwin/trunk/x86_64/20190727.1045/alure-1.2/install.log)

=> Checking file-check results for alure-1.2
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /Users/pbulk/build/audio/alure/work/.destdir/opt/pkg:
ERROR:         /Users/pbulk/build/audio/alure/work/.destdir/opt/pkg/include/AL/alure.h
ERROR: ************************************************************
ERROR: The following files are in /Users/pbulk/build/audio/alure/work/.destdir/opt/pkg but not in the PLIST:
ERROR:         /Users/pbulk/build/audio/alure/work/.destdir/opt/pkg/include/OpenAL/alure.h
*** Error code 1
>How-To-Repeat:
install audio/alure on macosx.
>Fix:
In the top CMakeLists.txt, the relative include directory is
OpenAL not AL concerning Apple platform:

line 494:
#add an install target here
IF(APPLE)
    SET(INCPATH OpenAL)
ELSE(APPLE)
    SET(INCPATH AL)
ENDIF(APPLE)

The folowing patch adapt the PLIST consequently:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/alure/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	24 Jun 2019 10:36:50 -0000	1.2
+++ Makefile	28 Jul 2019 15:29:18 -0000
@@ -17,6 +17,14 @@
 PKGCONFIG_OVERRIDE+=	alure-static.pc.in
 PKGCONFIG_OVERRIDE+=	alure.pc.in

+.include "../../mk/bsd.prefs.mk"
+
+PLIST_VARS+=    alincldir
+
+.if ${OPSYS} != "Darwin"
+PLIST.alincldir=	yes
+.endif
+
 .include "options.mk"
 .include "../../audio/openal-soft/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/audio/alure/PLIST,v
retrieving revision 1.1
diff -u -r1.1 PLIST
--- PLIST	21 Sep 2018 13:24:34 -0000	1.1
+++ PLIST	28 Jul 2019 15:29:18 -0000
@@ -1,5 +1,5 @@
 @comment $NetBSD: PLIST,v 1.1 2018/09/21 13:24:34 maya Exp $
-include/AL/alure.h
+${PLIST.alincldir}include/AL/alure.h
 lib/libalure-static.a
 lib/libalure.so
 lib/libalure.so.1
Index: PLIST.Darwin
===================================================================
RCS file: PLIST.Darwin
diff -N PLIST.Darwin
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ PLIST.Darwin	28 Jul 2019 15:29:18 -0000
@@ -0,0 +1 @@
+include/OpenAL/alure.h


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->macos-pkg-people
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Sun, 28 Jul 2019 15:54:09 +0000
Responsible-Changed-Why:
macOS problem


From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/54418: audio/alure bad header directory naming  in PLIST
 under macos
Date: Sun, 28 Jul 2019 19:12:00 +0000

 On Sun, Jul 28, 2019 at 03:35:00PM +0000, clement.bouvier.europe@gmail.com wrote:
  > +.include "../../mk/bsd.prefs.mk"
  > +
  > +PLIST_VARS+=    alincldir
  > +
  > +.if ${OPSYS} != "Darwin"
  > +PLIST.alincldir=	yes
  > +.endif
  > +

  > -include/AL/alure.h
  > +${PLIST.alincldir}include/AL/alure.h

 Better way to do this is:

  > +.include "../../mk/bsd.prefs.mk"
  > +
  > +PLIST_VARS+=    alincldir
  > +
  > +.if ${OPSYS} == "Darwin"
  > +PLIST.openalincldir=	yes
  > +.else
  > +PLIST.alincldir=		yes
  > +.endif
  > +

  > -include/AL/alure.h
  > +${PLIST.openalincldir}include/OpenAL/alure.h
  > +${PLIST.alincldir}include/AL/alure.h

 because in addition to being clearer to read it also continues to work
 if the conditional becomes more complicated.

 -- 
 David A. Holland
 dholland@netbsd.org

From: =?utf-8?Q?cl=C3=A9ment_bouvier?= <clement.bouvier.europe@gmail.com>
To: gnats-bugs@netbsd.org
Cc: macos-pkg-people@netbsd.org,
 gnats-admin@netbsd.org,
 pkgsrc-bugs@netbsd.org
Subject: Re: pkg/54418: audio/alure bad header directory naming  in PLIST
 under macos
Date: Mon, 29 Jul 2019 01:09:44 +0400

 Hi David,

 Thank you, I will remember it. The openalcldir is not included in =
 PLIST_VARS ?

 Clement

 > Le 28 juil. 2019 =C3=A0 23:15, David Holland =
 <dholland-pbugs@netbsd.org> a =C3=A9crit :
 >=20
 > The following reply was made to PR pkg/54418; it has been noted by =
 GNATS.
 >=20
 > From: David Holland <dholland-pbugs@netbsd.org>
 > To: gnats-bugs@netbsd.org
 > Cc:=20
 > Subject: Re: pkg/54418: audio/alure bad header directory naming  in =
 PLIST
 > under macos
 > Date: Sun, 28 Jul 2019 19:12:00 +0000
 >=20
 > On Sun, Jul 28, 2019 at 03:35:00PM +0000, =
 clement.bouvier.europe@gmail.com wrote:
 >> +.include "../../mk/bsd.prefs.mk"
 >> +
 >> +PLIST_VARS+=3D    alincldir
 >> +
 >> +.if ${OPSYS} !=3D "Darwin"
 >> +PLIST.alincldir=3D	yes
 >> +.endif
 >> +
 >=20
 >> -include/AL/alure.h
 >> +${PLIST.alincldir}include/AL/alure.h
 >=20
 > Better way to do this is:
 >=20
 >> +.include "../../mk/bsd.prefs.mk"
 >> +
 >> +PLIST_VARS+=3D    alincldir
 >> +
 >> +.if ${OPSYS} =3D=3D "Darwin"
 >> +PLIST.openalincldir=3D	yes
 >> +.else
 >> +PLIST.alincldir=3D		yes
 >> +.endif
 >> +
 >=20
 >> -include/AL/alure.h
 >> +${PLIST.openalincldir}include/OpenAL/alure.h
 >> +${PLIST.alincldir}include/AL/alure.h
 >=20
 > because in addition to being clearer to read it also continues to work
 > if the conditional becomes more complicated.
 >=20
 > --=20
 > David A. Holland
 > dholland@netbsd.org
 >=20

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/54418: audio/alure bad header directory naming  in PLIST
 under macos
Date: Thu, 1 Aug 2019 15:53:17 +0000

 On Sun, Jul 28, 2019 at 09:10:01PM +0000, cl?ment bouvier wrote:
  >  Hi David,
  >  
  >  Thank you, I will remember it. The openalcldir is not included in
  >  PLIST_VARS ?

 No, it should be. Sorry, my fault. Too many re-editing passes...

 -- 
 David A. Holland
 dholland@netbsd.org

From: =?utf-8?Q?cl=C3=A9ment_bouvier?= <clement.bouvier.europe@gmail.com>
To: gnats-bugs@netbsd.org
Cc: macos-pkg-people@netbsd.org,
 gnats-admin@netbsd.org,
 pkgsrc-bugs@netbsd.org
Subject: Re: pkg/54418: audio/alure bad header directory naming  in PLIST
 under macos
Date: Fri, 2 Aug 2019 09:43:32 +0400

 --Apple-Mail=_85D13FF2-1F58-4818-A8B3-F02A5AC8A468
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=utf-8

 Finally the patch with David's corrections.

 Cl=C3=A9ment.


 --Apple-Mail=_85D13FF2-1F58-4818-A8B3-F02A5AC8A468
 Content-Disposition: attachment;
 	filename=patch-alure.diff
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="patch-alure.diff"
 Content-Transfer-Encoding: 7bit

 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/audio/alure/Makefile,v
 retrieving revision 1.2
 diff -u -r1.2 Makefile
 --- Makefile	24 Jun 2019 10:36:50 -0000	1.2
 +++ Makefile	2 Aug 2019 05:39:30 -0000
 @@ -17,6 +17,16 @@
  PKGCONFIG_OVERRIDE+=	alure-static.pc.in
  PKGCONFIG_OVERRIDE+=	alure.pc.in

 +.include "../../mk/bsd.prefs.mk"
 +
 +PLIST_VARS+=    alincldir openalincldir
 +
 +.if ${OPSYS} == "Darwin"
 +PLIST.openalincldir=	yes
 +.else
 +PLIST.alincldir=	yes
 +.endif
 +
  .include "options.mk"
  .include "../../audio/openal-soft/buildlink3.mk"
  .include "../../mk/bsd.pkg.mk"
 Index: PLIST
 ===================================================================
 RCS file: /cvsroot/pkgsrc/audio/alure/PLIST,v
 retrieving revision 1.1
 diff -u -r1.1 PLIST
 --- PLIST	21 Sep 2018 13:24:34 -0000	1.1
 +++ PLIST	2 Aug 2019 05:39:30 -0000
 @@ -1,5 +1,5 @@
  @comment $NetBSD: PLIST,v 1.1 2018/09/21 13:24:34 maya Exp $
 -include/AL/alure.h
 +${PLIST.alincldir}include/AL/alure.h
  lib/libalure-static.a
  lib/libalure.so
  lib/libalure.so.1
 Index: PLIST.Darwin
 ===================================================================
 RCS file: PLIST.Darwin
 diff -N PLIST.Darwin
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ PLIST.Darwin	2 Aug 2019 05:39:30 -0000
 @@ -0,0 +1 @@
 +${PLIST.openalincldir}include/OpenAL/alure.h

 --Apple-Mail=_85D13FF2-1F58-4818-A8B3-F02A5AC8A468--

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 23 Oct 2019 00:18:13 +0000
State-Changed-Why:
commited, thanks!


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54418 CVS commit: pkgsrc/audio/alure
Date: Wed, 23 Oct 2019 00:17:54 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Wed Oct 23 00:17:54 UTC 2019

 Modified Files:
 	pkgsrc/audio/alure: Makefile PLIST

 Log Message:
 alure: use a PLIST variable to account for different names on macos.

 From Clement Bouvier in PR pkg/54418, modified to be in the existing
 PLIST file, to make it obvious for non-macos updates that if a new
 file gets added, it shoudl be added for the mac variant naming as well.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/audio/alure/Makefile
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/audio/alure/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search