NetBSD Problem Report #54705

From www@netbsd.org  Sun Nov 17 17:36:10 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 94BA57A159
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 17 Nov 2019 17:36:10 +0000 (UTC)
Message-Id: <20191117173609.CF3FE7A25A@mollari.NetBSD.org>
Date: Sun, 17 Nov 2019 17:36:09 +0000 (UTC)
From: kuleshovmail@gmail.com
Reply-To: kuleshovmail@gmail.com
To: gnats-bugs@NetBSD.org
Subject: uaudio: move computing of the number of input channels under UAUDIO_DEBUG
X-Send-Pr-Version: www-1.0

>Number:         54705
>Category:       kern
>Synopsis:       uaudio: move computing of the number of input channels under UAUDIO_DEBUG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 17 17:40:00 +0000 2019
>Originator:     Alexander Kuleshov
>Release:        NetBSD-current
>Organization:
Travelping
>Environment:
NetBSD localhost 9.99.17 NetBSD 9.99.17 (MY_KERN) #3: Sun Nov 17 18:10:31 +06 2019  alex@localhost:/usr/obj/sys/arch/amd64/compile/MY_KERN amd64
>Description:
Hello,

The uaudio_add_mixer() function from src/sys/dev/usb/uaudio.c contains computing of number of input channels, but its result is only used in DPRINTF macro which does the stuff only if UAUDIO_DEBUG is defined.

The patch is attached below. Can you take a look please:

Index: uaudio.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uaudio.c,v
retrieving revision 1.162
diff -r1.162 uaudio.c
758c758
< 	int c, chs, ichs, ochs, i, o, bno, p, mo, mc, k;
---
> 	int c, chs, ochs, i, o, bno, p, mo, mc, k;
760a761,763
> #ifdef UAUDIO_DEBUG
>         int ichs;
> #endif
765c768
< 
---
> #ifdef UAUDIO_DEBUG
770c773
< 
---
> #endif


Thank you.
>How-To-Repeat:

>Fix:

Home	PR Database Search