NetBSD Problem Report #54772
From www@netbsd.org Mon Dec 16 16:06:54 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 403747A1B2
for <gnats-bugs@gnats.NetBSD.org>; Mon, 16 Dec 2019 16:06:54 +0000 (UTC)
Message-Id: <20191216160653.341A57A1EE@mollari.NetBSD.org>
Date: Mon, 16 Dec 2019 16:06:53 +0000 (UTC)
From: ottavio2006-usenet2012@yahoo.com
Reply-To: ottavio2006-usenet2012@yahoo.com
To: gnats-bugs@NetBSD.org
Subject: emulators/qemu: failed install on Linux/Debian (PLIST mismatch)
X-Send-Pr-Version: www-1.0
>Number: 54772
>Category: pkg
>Synopsis: emulators/qemu: failed install on Linux/Debian (PLIST mismatch)
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: gutteridge
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Dec 16 16:10:00 +0000 2019
>Closed-Date: Mon Jan 27 21:46:37 +0000 2020
>Last-Modified: Mon Jan 27 21:46:37 +0000 2020
>Originator: Ottavio Caruso
>Release: pkgsrc-current
>Organization:
>Environment:
Linux e130 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3+deb9u1 (2019-09-20) x86_64 GNU/Linux
>Description:
I had the same problem with qemu 4.1. I've just updated the cvs tree and rebuilt from v 4.2, and I have a failed install:
Last lines of log:
/usr/bin/install -c -o oc -g oc -m 644 /home/oc/pkgsrc/current/pkgsrc/emulators/qemu/files/Makefile.multinode-NetBSD /home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg/share/doc/qemu/
/bin/rm -f /home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg/share/doc/qemu/interop/.buildinfo
/bin/rm -f /home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg/share/doc/qemu/specs/.buildinfo
/bin/rm -f /home/oc/pkgsrc/work/emulators/qemu/work/PLIST.STATIC
cd /home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg && /usr/bin/find share/doc/qemu -path '*/_static/*' -type f -print > /home/oc/pkgsrc/work/emulators/qemu/work/PLIST.STATIC
=> Automatic manual page handling
=> Generating post-install file lists
pkg_create: can't stat `/home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg/bin/virtfs-proxy-helper'
pkg_create: can't stat `/home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg/man/man1/virtfs-proxy-helper.1'
=> Checking file-check results for qemu-4.2.0
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg:
ERROR: /home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg/bin/virtfs-proxy-helper
ERROR: /home/oc/pkgsrc/work/emulators/qemu/work/.destdir/usr/pkg/man/man1/virtfs-proxy-helper.1
*** Error code 1
Stop.
bmake[2]: stopped in /home/oc/pkgsrc/current/pkgsrc/emulators/qemu
*** Error code 1
Stop.
bmake[1]: stopped in /home/oc/pkgsrc/current/pkgsrc/emulators/qemu
*** Error code 1
Stop.
bmake: stopped in /home/oc/pkgsrc/current/pkgsrc/emulators/qemu
Full log:
http://paste.debian.net/plainh/0d36fac7
>How-To-Repeat:
cd emulators/qemu
bmake bin-install
>Fix:
>Release-Note:
>Audit-Trail:
From: "David H. Gutteridge" <david@gutteridge.ca>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/54772: emulators/qemu: failed install on Linux/Debian
(PLIST mismatch)
Date: Sun, 29 Dec 2019 17:06:20 -0500
I can reproduce this on Debian 9 and Fedora 31. The issue is that
virtfs-proxy-helper is only built if two development libraries (libcap
and libattr) are installed, which typically aren't included by default
in Linux distros. I think virtfs support should be made a non-default
option that someone would enable when they expressly want it, and have
first installed the necessary upstream header packages to support
compilation. By default, it will break more often than not.
Regards,
Dave
From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
Ottavio Caruso <ottavio2006-usenet2012@yahoo.com>
Subject: Re: pkg/54772: emulators/qemu: failed install on Linux/Debian (PLIST mismatch)
Date: Fri, 3 Jan 2020 14:21:46 +0100
On Sun, Dec 29, 2019 at 11:10 PM David H. Gutteridge
<david@gutteridge.ca> wrote:
> I think virtfs support should be made a non-default
> option that someone would enable when they expressly want it, and have
> first installed the necessary upstream header packages to support
> compilation. By default, it will break more often than not.
Makes sense. Do you want to propose a patch?
--
Benny
Responsible-Changed-From-To: pkg-manager->gutteridge
Responsible-Changed-By: gutteridge@NetBSD.org
Responsible-Changed-When: Sat, 04 Jan 2020 02:10:53 +0000
Responsible-Changed-Why:
I'll propose a patch for this soon.
From: "David H. Gutteridge" <david@gutteridge.ca>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/54772: emulators/qemu: failed install on Linux/Debian
(PLIST mismatch)
Date: Tue, 07 Jan 2020 13:02:22 -0500
I've tested the following patches on Fedora 31 where the libcap and
libattr header libraries are absent and present (in the latter case
with the new option enabled), and both builds worked as expected.
There are a couple of things to note. A conditional adding to
PKG_SUPPORTED_OPTIONS isn't a common construct as far as I've noticed,
but I see there's precedent in sysutils/dbus, and it makes the most
sense. I didn't bother conditionalizing PLIST_VARS, as it wasn't
necessary, but I moved virtfs-proxy-helper to options.mk so all
references to it are found in one place. I can commit this if everybody
likes.
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/emulators/qemu/options.mk,v
retrieving revision 1.5
diff -u -r1.5 options.mk
--- options.mk 14 Aug 2018 06:57:26 -0000 1.5
+++ options.mk 7 Jan 2020 03:32:51 -0000
@@ -5,13 +5,17 @@
.include "../../mk/bsd.fast.prefs.mk"
+.if ${OPSYS} == "Linux"
+PKG_SUPPORTED_OPTIONS+= virtfs-proxy-helper
+.endif
+
.if ${OPSYS} != "Darwin"
PKG_SUGGESTED_OPTIONS+= sdl
.endif
.include "../../mk/bsd.options.mk"
-PLIST_VARS+= gtk
+PLIST_VARS+= gtk virtfs-proxy-helper
.if !empty(PKG_OPTIONS:Mgtk3)
PLIST.gtk= yes
@@ -27,3 +31,12 @@
.else
CONFIGURE_ARGS+= --disable-sdl
.endif
+
+# NB to successfully build virtfs-proxy-helper, the upstream Linux
+# header/development libraries libcap and libattr must be installed.
+.if !empty(PKG_OPTIONS:Mvirtfs-proxy-helper)
+PLIST.virtfs-proxy-helper= yes
+CONFIGURE_ARGS+= --enable-virtfs
+.else
+CONFIGURE_ARGS+= --disable-virtfs
+.endif
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/emulators/qemu/Makefile,v
retrieving revision 1.223
diff -u -r1.223 Makefile
--- Makefile 4 Jan 2020 13:46:59 -0000 1.223
+++ Makefile 7 Jan 2020 03:33:23 -0000
@@ -125,14 +125,13 @@
PLIST.nbd= yes
PLIST.ivshmem= yes
PLIST.pr-helper= yes
-PLIST.virtfs-proxy-helper= yes
.elif !empty(MACHINE_PLATFORM:MSunOS-5.11-*)
PLIST.ivshmem= yes
PLIST.nbd= yes
CONFIGURE_ARGS+= --disable-coroutine-pool
.endif
-PLIST_VARS+= ${UE_ARCHS} bridge-helper ivshmem nbd pr-helper virtfs-proxy-helper
+PLIST_VARS+= ${UE_ARCHS} bridge-helper ivshmem nbd pr-helper
.for pvar in ${USER_EMUL}
PLIST.${pvar}= yes
.endfor
From: "David H. Gutteridge" <david@gutteridge.ca>
To: Ottavio Caruso <ottavio2006-usenet2012@yahoo.com>
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/54772: emulators/qemu: failed install on Linux/Debian
(PLIST mismatch)
Date: Tue, 07 Jan 2020 23:09:40 -0500
On Tue, 2020-01-07 at 22:38 +0000, Ottavio Caruso wrote:
> With the patch provided by David Gutteridge, and using the standard
> options, I was able to build and install qemu 4.2.
>
> Running qemu-system-x86_64 with default "-display sdl", I get a black
> screen and a warning "guest has not initialized the display yet" and
> then a freeze.
>
> Adding the option "-nographic", the program runs fine, as I previously
> configured the guest to boot from serial console.
>
> To be fair I did have problems running qemu with sdl with previous
> pkgsrc builds.
>
> I'd like to have some more time and rebuild qemu with gtk3, before a
> final commit is made. if this is fine with everybody.
Sure, there's no rush here. :) (The SDL issue should be unrelated to
the build failure, though.)
Dave
From: Ottavio Caruso <ottavio2006-usenet2012@yahoo.com>
To: gnats-bugs@netbsd.org
Cc: gutteridge@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/54772: emulators/qemu: failed install on Linux/Debian (PLIST mismatch)
Date: Wed, 8 Jan 2020 08:06:46 +0000
I've rebuilt and installed qemu with David's patch and, this time, with:
PKG_OPTIONS.qemu = gtk3 -sdl
Build and install went fine. Apart from a couple of niggles, which are
most likely non-pkgsrc related, I'd say that the problem is now
solved.
--
Ottavio Caruso
From: "David H. Gutteridge" <gutteridge@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/54772 CVS commit: pkgsrc/emulators/qemu
Date: Mon, 13 Jan 2020 02:50:25 +0000
Module Name: pkgsrc
Committed By: gutteridge
Date: Mon Jan 13 02:50:25 UTC 2020
Modified Files:
pkgsrc/emulators/qemu: Makefile options.mk
Log Message:
qemu: fix Linux build in most environments
Addresses PR pkg/54772, reported by and patch tested by Ottavio Caruso.
virtfs-proxy-helper is only built if two development libraries (for
libcap and libattr) are installed, which typically aren't included by
default in Linux distros. Make virtfs support a non-default option that
someone would enable when they expressly want it, and they have first
installed the necessary upstream header packages to support the
compilation of this option.
To generate a diff of this commit:
cvs rdiff -u -r1.225 -r1.226 pkgsrc/emulators/qemu/Makefile
cvs rdiff -u -r1.5 -r1.6 pkgsrc/emulators/qemu/options.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->pending-pullups
State-Changed-By: gutteridge@NetBSD.org
State-Changed-When: Sun, 26 Jan 2020 02:30:21 +0000
State-Changed-Why:
Pullup request #6123 submitted for inclusion in 2019Q4 branch.
From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/54772 CVS commit: [pkgsrc-2019Q4] pkgsrc
Date: Mon, 27 Jan 2020 10:59:05 +0000
Module Name: pkgsrc
Committed By: bsiegert
Date: Mon Jan 27 10:59:05 UTC 2020
Modified Files:
pkgsrc/emulators/qemu [pkgsrc-2019Q4]: Makefile PLIST options.mk
pkgsrc/mk/defaults [pkgsrc-2019Q4]: options.description
Log Message:
Pullup ticket #6123 - requested by gutteridge
emulators/qemu: build fix
Revisions pulled up:
- emulators/qemu/Makefile 1.223-1.224,1.226
- emulators/qemu/PLIST 1.64-1.65
- emulators/qemu/options.mk 1.6
- mk/defaults/options.description 1.605
---
Module Name: pkgsrc
Committed By: ryoon
Date: Sat Jan 4 13:47:00 UTC 2020
Modified Files:
pkgsrc/emulators/qemu: Makefile PLIST
Log Message:
Include xkbcommon unconditionally and directly to reduce PLIST divergence
* Bump PKGREVISION.
---
Module Name: pkgsrc
Committed By: adam
Date: Fri Jan 10 20:27:04 UTC 2020
Modified Files:
pkgsrc/emulators/qemu: Makefile PLIST
Log Message:
qemu: fix build on macOS
---
Module Name: pkgsrc
Committed By: gutteridge
Date: Mon Jan 13 02:50:25 UTC 2020
Modified Files:
pkgsrc/emulators/qemu: Makefile options.mk
Log Message:
qemu: fix Linux build in most environments
Addresses PR pkg/54772, reported by and patch tested by Ottavio Caruso.
virtfs-proxy-helper is only built if two development libraries (for
libcap and libattr) are installed, which typically aren't included by
default in Linux distros. Make virtfs support a non-default option that
someone would enable when they expressly want it, and they have first
installed the necessary upstream header packages to support the
compilation of this option.
---
Module Name: pkgsrc
Committed By: gutteridge
Date: Mon Jan 13 02:52:28 UTC 2020
Modified Files:
pkgsrc/mk/defaults: options.description
Log Message:
options.description: add virtfs-proxy-helper
To generate a diff of this commit:
cvs rdiff -u -r1.222 -r1.222.4.1 pkgsrc/emulators/qemu/Makefile
cvs rdiff -u -r1.63 -r1.63.4.1 pkgsrc/emulators/qemu/PLIST
cvs rdiff -u -r1.5 -r1.5.14.1 pkgsrc/emulators/qemu/options.mk
cvs rdiff -u -r1.601 -r1.601.4.1 pkgsrc/mk/defaults/options.description
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: pending-pullups->closed
State-Changed-By: gutteridge@NetBSD.org
State-Changed-When: Mon, 27 Jan 2020 21:46:37 +0000
State-Changed-Why:
Pulled up to 2019Q4. Thanks for the PR, and for testing!
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home