NetBSD Problem Report #54779

From tsutsui@ceres.dti.ne.jp  Wed Dec 18 12:14:36 2019
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4E20B7A186
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 18 Dec 2019 12:14:36 +0000 (UTC)
Message-Id: <201912181214.xBICEQBZ027603@ceres.dti.ne.jp>
Date: Wed, 18 Dec 2019 21:14:26 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: pkgsrc/audio/mpg123 for softfloat arm uses FPU
X-Send-Pr-Version: 3.95

>Number:         54779
>Category:       pkg
>Synopsis:       pkgsrc/audio/mpg123 for softfloat arm uses FPU
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 18 12:15:00 +0000 2019
>Closed-Date:    Sat Aug 01 23:48:21 +0000 2020
>Last-Modified:  Sat Aug 01 23:48:21 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0_RC1 + pkgsrc-2019Q3
>Organization:
>Environment:
System: NetBSD 9.0_RC1
Architecture: earm
Machine: zaurus / evbarm
>Description:
pkgsrc/audio/mpg123/options.mk has the following statements to check
FPU options per ${MACHINE_ARCH}:
---
.if (${MACHINE_ARCH} == "i386")
.  if empty(MACHINE_PLATFORM:MDarwin-11.*-i386) && \
      empty(MACHINE_PLATFORM:MSunOS-*) && \
      empty(MACHINE_PLATFORM:MNetBSD-[89]*-i386)
PKG_OPTIONS_GROUP.fpu=		mpg123-x86-dither mpg123-with-fpu
PKG_SUGGESTED_OPTIONS+=		mpg123-x86-dither
.  else
PKG_OPTIONS_GROUP.fpu=		mpg123-with-fpu
PKG_SUGGESTED_OPTIONS+=		mpg123-with-fpu
.  endif
.elif (${MACHINE_ARCH} == "arm") || (${MACHINE_ARCH} == "arm32")
PKG_OPTIONS_GROUP.fpu=		mpg123-with-fpu 
.elif (${MACHINE_ARCH} == "aarch64")
PKG_OPTIONS_GROUP.fpu=		mpg123-neon64 mpg123-aarch64
PKG_SUGGESTED_OPTIONS+=		mpg123-aarch64
.elif (${MACHINE_ARCH} == "powerpc")
PKG_OPTIONS_GROUP.fpu=		mpg123-altivec mpg123-with-fpu
PKG_SUGGESTED_OPTIONS+=		mpg123-altivec
.else
PKG_OPTIONS_GROUP.fpu=		mpg123-with-fpu
PKG_SUGGESTED_OPTIONS+=		mpg123-with-fpu
.endif
---

> (${MACHINE_ARCH} == "arm") || (${MACHINE_ARCH} == "arm32")
This won't match for any new earm machines, so mpg123 for earm is build
with mpg123-with-fpu per the PKG_SUGGESTED_OPTIONS in the else clause,
then mpg123 binary (including mplayer with libmpg123) is almost
non-functional (i.e. choppy sound).

>How-To-Repeat:
Build mpg123 on earm and see SUGEESTED options.

>Fix:
Is there proper way to check "softfloat" using MACHINE_ARCH?

---
Izumi Tsutsui

>Release-Note:

>Audit-Trail:
From: "Izumi Tsutsui" <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54779 CVS commit: pkgsrc/audio/mpg123
Date: Sat, 1 Aug 2020 23:44:06 +0000

 Module Name:	pkgsrc
 Committed By:	tsutsui
 Date:		Sat Aug  1 23:44:06 UTC 2020

 Modified Files:
 	pkgsrc/audio/mpg123: Makefile options.mk

 Log Message:
 Don't set PKG_SUGGESTED_OPTIONS=mpg123-with-fpu on softfloat arm.

 Fixes PR/54779.
 Bump PKGREVISION to rebuild arm binaries.


 To generate a diff of this commit:
 cvs rdiff -u -r1.58 -r1.59 pkgsrc/audio/mpg123/Makefile
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/audio/mpg123/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sat, 01 Aug 2020 23:48:21 +0000
State-Changed-Why:
Fix committed.


>Unformatted:

Home	PR Database Search