NetBSD Problem Report #54794

From www@netbsd.org  Sun Dec 22 17:07:35 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 90BF57A17A
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 22 Dec 2019 17:07:35 +0000 (UTC)
Message-Id: <20191222170734.996017A1EF@mollari.NetBSD.org>
Date: Sun, 22 Dec 2019 17:07:34 +0000 (UTC)
From: ci4ic4@gmail.com
Reply-To: ci4ic4@gmail.com
To: gnats-bugs@NetBSD.org
Subject: sysutils/lsof does not build under -current after 9.99.18
X-Send-Pr-Version: www-1.0

>Number:         54794
>Category:       pkg
>Synopsis:       sysutils/lsof does not build under -current after 9.99.18
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 22 17:10:00 +0000 2019
>Closed-Date:    Tue Oct 13 03:24:58 +0000 2020
>Last-Modified:  Tue Oct 13 08:50:01 +0000 2020
>Originator:     Chavdar Ivanov
>Release:        pkgsrc branch -current as of 22/12/2019
>Organization:
CI4 Consulting Ltd
>Environment:
NetBSD ymir 9.99.28 NetBSD 9.99.28 (GENERIC) #3: Sun Dec 22 15:23:57 GMT 2019  sysbuild@ymir:/home/sysbuild/amd64/obj/home/sysbuild/src/sys/arch/amd64/compile/GENERIC amd64

>Description:
Since 9.99.18 lsof does not build with the same error:
...
gcc -O2  -DNETBSDV=7000000 -DN_UNIXV=/dev/ksyms -DHASKVMGETPROC2 -DHASNFSPROTO -DHASIPv6 -DHASFDESCFS=1 -DHASFDLINK -DHASNULLFS -DHASPROCFS
 -DHASPROCFS_PFSROOT -DHASBUFQ_H -DHAS9660FS=1 -DHASMSDOSFS=1 -DHASKERNFS -DHASKERNFS_KFS_KT -DHASI_FFS1 -DHASEXT2FS -DHASI_E2FS_PTR -DHASLFS -DHASPTYFS -DHASTMPFS -DHASNFSVATTRP -DHAS_ADVLOCK_ARGS -DHAS_LWP_H -DHAS_SYS_PIPEH -DHASSTATVFS -DUVM -I/usr/pkgsrc/sysutils/lsof/work/
lsof_4.91/lsof_4.91_src/dialects/n+obsd/include -DHAS_UVM_INCL -DHAS_STRFTIME -DLSOF_VSTR="9.99.28"    -D_KMEMUSER -D__NAMECACHE_PRIVATE -c
 dvch.c
In file included from /usr/include/sys/ptrace.h:63,
                 from /usr/include/miscfs/procfs/procfs.h:75,
                 from ../dlsof.h:369,
                 from ../lsof.h:221,
                 from dvch.c:43:
/usr/include/amd64/ptrace.h:104:10: fatal error: sys/module_hook.h: No such file or directory
 #include <sys/module_hook.h>
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
*** Error code 1
.....

The above is included conditionaly on _KERNEL.  

The last version I have apparently starts up, but the output is mostly garbage on later versions, which is to be expected. 
>How-To-Repeat:
Try to build sysutils/lsof past 9.99.18. 
>Fix:
N/A

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Tue, 13 Oct 2020 03:24:58 +0000
State-Changed-Why:
Fixed by manu@ in:
https://github.com/NetBSD/pkgsrc/commit/4dbf4b674afac0c6719fc84d705b011adb5fee9f#diff-146d92cf2e393dc91ec1c0020e3e012fdfff8239ae8a6f97425783ebc42a5484


From: maya@NetBSD.org
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/54794 (sysutils/lsof does not build under -current after
 9.99.18)
Date: Tue, 13 Oct 2020 03:25:47 +0000

 On Tue, Oct 13, 2020 at 03:24:59AM +0000, maya@NetBSD.org wrote:
 > Synopsis: sysutils/lsof does not build under -current after 9.99.18
 > 
 > State-Changed-From-To: open->closed
 > State-Changed-By: maya@NetBSD.org
 > State-Changed-When: Tue, 13 Oct 2020 03:24:58 +0000
 > State-Changed-Why:
 > Fixed by manu@ in:
 > https://github.com/NetBSD/pkgsrc/commit/4dbf4b674afac0c6719fc84d705b011adb5fee9f#diff-146d92cf2e393dc91ec1c0020e3e012fdfff8239ae8a6f97425783ebc42a5484
 > 
 > 
 > 

 "Probably". It does build now at least.

From: Tobias Nygren <tnn@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/54794 (sysutils/lsof does not build under -current after
 9.99.18)
Date: Tue, 13 Oct 2020 10:47:44 +0200

 On Tue, 13 Oct 2020 03:30:02 +0000 (UTC)
 maya@NetBSD.org wrote:

 >  "Probably". It does build now at least.

 It builds but is crippled. Can no longer resolve pathnames after the
 "ad-namecache" merge. lsof needs to be taught to walk the namei cache
 rbtrees using kmem. c.f. patch-af. (Should be filed as new PR.)

>Unformatted:

Home	PR Database Search