NetBSD Problem Report #54859
From www@netbsd.org Tue Jan 14 18:44:07 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 5431F7A18A
for <gnats-bugs@gnats.NetBSD.org>; Tue, 14 Jan 2020 18:44:07 +0000 (UTC)
Message-Id: <20200114184406.9E3827A1D8@mollari.NetBSD.org>
Date: Tue, 14 Jan 2020 18:44:06 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/dev/pci/if_rge.c: 2 * bad expression
X-Send-Pr-Version: www-1.0
>Number: 54859
>Category: kern
>Synopsis: src/sys/dev/pci/if_rge.c: 2 * bad expression
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Jan 14 18:45:00 +0000 2020
>Originator: David Binderman
>Release: cvs-20200114
>Organization:
>Environment:
>Description:
1.
src/sys/dev/pci/if_rge.c:1870:38: style: Expression '(X & 0x80) == 0x2' is always false. [comparisonError]
Source code is
if ((rge_read_phy_ocp(sc, 0xa420) & 0x0080) == 2)
2.
src/sys/dev/pci/if_rge.c:1429:38: style: Expression '(X & 0x80) == 0x3' is always false. [comparisonError]
Source code is
if ((rge_read_phy_ocp(sc, 0xa420) & 0x0080) == 3)
>How-To-Repeat:
>Fix:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.