NetBSD Problem Report #54990

From www@netbsd.org  Thu Feb 20 11:46:45 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A24741A9213
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 20 Feb 2020 11:46:45 +0000 (UTC)
Message-Id: <20200220114644.DCEDC1A9217@mollari.NetBSD.org>
Date: Thu, 20 Feb 2020 11:46:44 +0000 (UTC)
From: rares.aioanei@gmail.com
Reply-To: rares.aioanei@gmail.com
To: gnats-bugs@NetBSD.org
Subject: After upgrade from 9.0-RC2 to 9.0, the release candidate is still present
X-Send-Pr-Version: www-1.0

>Number:         54990
>Category:       install
>Synopsis:       After upgrade from 9.0-RC2 to 9.0, the release candidate is still present
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    install-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 20 11:50:00 +0000 2020
>Closed-Date:    Fri Aug 13 21:27:15 +0000 2021
>Last-Modified:  Fri Aug 13 21:27:15 +0000 2021
>Originator:     Rares Aioanei
>Release:        9.0
>Organization:
>Environment:
NetBSD localhost 9.0 NetBSD 9.0 (GENERIC) #0: Fri Feb 14 00:06:28 UTC 2020  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64

>Description:
I just upgraded NetBSD 9.0-RC2 to 9.0 via iso. The release went fine, but when I log in, I'm still greeted by the message that warns me that this is a RC, bugs may be encountered, etc. 
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: leot@NetBSD.org
State-Changed-When: Thu, 20 Feb 2020 11:54:43 +0000
State-Changed-Why:
Feedback requested (maybe /etc/update was not updated and
etcupdate(8) needs to be invoked to eventually update it).


From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: install/54990: After upgrade from 9.0-RC2 to 9.0, the release candidate is still present
Date: Thu, 20 Feb 2020 12:53:38 +0100

 Hello Rares,

 rares.aioanei@gmail.com writes:
 > [...]
 > >Description:
 > I just upgraded NetBSD 9.0-RC2 to 9.0 via iso. The release went fine, but when I log in, I'm still greeted by the message that warns me that this is a RC, bugs may be encountered, etc. 
 > [...]

 Was /etc/motd updated?

 (if not `etcupdate -val -s etc.tgz -s xetc.tgz' or similar invocations
 should permit to update it.)

From: Rares Aioanei <bsdlisten@gmail.com>
To: gnats-bugs@netbsd.org
Cc: install-manager@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org, rares.aioanei@gmail.com
Subject: Re: install/54990: After upgrade from 9.0-RC2 to 9.0, the release
 candidate is still present
Date: Thu, 20 Feb 2020 14:03:30 +0200

 On Thu, Feb 20, 2020 at 11:55:01AM +0000, Leonardo Taccari wrote:
 > The following reply was made to PR install/54990; it has been noted by GNATS.
 > 
 > From: Leonardo Taccari <leot@NetBSD.org>
 > To: gnats-bugs@netbsd.org
 > Cc: 
 > Subject: Re: install/54990: After upgrade from 9.0-RC2 to 9.0, the release candidate is still present
 > Date: Thu, 20 Feb 2020 12:53:38 +0100
 > 
 >  Hello Rares,
 >  
 >  rares.aioanei@gmail.com writes:
 >  > [...]
 >  > >Description:
 >  > I just upgraded NetBSD 9.0-RC2 to 9.0 via iso. The release went fine, but when I log in, I'm still greeted by the message that warns me that this is a RC, bugs may be encountered, etc. 
 >  > [...]
 >  
 >  Was /etc/motd updated?
 >  
 >  (if not `etcupdate -val -s etc.tgz -s xetc.tgz' or similar invocations
 >  should permit to update it.)
 >  
 Hey, thanks for the reply. I know how to fix this, but I was thinking it was something that should've taken place as part of the upgrade process.
 -- 
 Best, 
 Rares

From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: install/54990: After upgrade from 9.0-RC2 to 9.0, the release candidate is still present
Date: Thu, 20 Feb 2020 13:08:25 +0100

 Rares Aioanei writes:
 > Hey, thanks for the reply. I know how to fix this, but I was thinking it was something that should've taken place as part of the upgrade process.

 I don't think there is any way to check that the `/etc/motd' was not
 modified and that's why it is not automatically updated and
 etcupdate(8) is needed.

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: install/54990: After upgrade from 9.0-RC2 to 9.0, the release
 candidate is still present
Date: Thu, 20 Feb 2020 13:09:56 +0100

 The problem is that

  (a) postinstall(8), which we run during an update, does not "fix" it.
  (b) formally /etc/motd is considered a user-editable file and should not
      be managed automatically.

 I guess we should change postinstall to recognize unmodified files (of all
 three (?) variants) and just replace them.

 Martin

From: Martin Husemann <martin@duskware.de>
To: Takeshi Nakayama <tn@catvmics.ne.jp>
Cc: gnats-bugs@NetBSD.org
Subject: Re: install/54990: After upgrade from 9.0-RC2 to 9.0, the release
 candidate is still present
Date: Mon, 24 Feb 2020 19:51:51 +0100

 On Fri, Feb 21, 2020 at 04:05:52PM +0900, Takeshi Nakayama wrote:
 > +++ usr.sbin/postinstall/postinstall.in	21 Feb 2020 06:59:55 -0000
 > @@ -1271,7 +1271,7 @@
 >  
 >  	if ${GREP} -i 'http://www.NetBSD.org/Misc/send-pr.html' \
 >  		"${DEST_DIR}/etc/motd" >/dev/null 2>&1 \
 > -	    || ${GREP} -i 'http://www.NetBSD.org/support/send-pr.html' \
 > +	    || ${GREP} -i 'https*://www.NetBSD.org/support/send-pr.html' \
 >  		"${DEST_DIR}/etc/motd" >/dev/null 2>&1
 >  	then
 >  		tmp1="$(mktemp /tmp/postinstall.motd.XXXXXXXX)"

 Yes, that looks good - please commit and request pullup.

 Martin

From: "Takeshi Nakayama" <nakayama@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54990 CVS commit: src/usr.sbin/postinstall
Date: Tue, 25 Feb 2020 10:27:01 +0000

 Module Name:	src
 Committed By:	nakayama
 Date:		Tue Feb 25 10:27:01 UTC 2020

 Modified Files:
 	src/usr.sbin/postinstall: postinstall.in

 Log Message:
 Fix the fixup script to follow the URL change in /etc/motd (http->https).

 PR install/54990, pullup-9


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 src/usr.sbin/postinstall/postinstall.in

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54990 CVS commit: [netbsd-9] src/usr.sbin/postinstall
Date: Thu, 27 Feb 2020 18:53:04 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Thu Feb 27 18:53:04 UTC 2020

 Modified Files:
 	src/usr.sbin/postinstall [netbsd-9]: postinstall.in

 Log Message:
 Pull up following revision(s) (requested by nakayama in ticket #738):

 	usr.sbin/postinstall/postinstall.in: revision 1.15

 Fix the fixup script to follow the URL change in /etc/motd (http->https).
 PR install/54990, pullup-9


 To generate a diff of this commit:
 cvs rdiff -u -r1.5.2.3 -r1.5.2.4 src/usr.sbin/postinstall/postinstall.in

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 13 Aug 2021 21:27:15 +0000
State-Changed-Why:
fixed and pulled up to -9 in february 2020


>Unformatted:

Home	PR Database Search