NetBSD Problem Report #55225
From bjjl@chaos.lorenz.place Fri May 1 12:57:05 2020
Return-Path: <bjjl@chaos.lorenz.place>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 444851A9217
for <gnats-bugs@gnats.NetBSD.org>; Fri, 1 May 2020 12:57:05 +0000 (UTC)
Message-Id: <20200501125702.9DAE3410845@chaos.lorenz.place>
Date: Fri, 1 May 2020 14:57:02 +0200 (CEST)
From: ben@pocket.services
To: gnats-bugs@NetBSD.org
Subject: git push not displaying username
X-Send-Pr-Version: 3.95
>Number: 55225
>Category: pkg
>Synopsis: git push not displaying username
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri May 01 13:00:00 +0000 2020
>Closed-Date: Sat Jul 10 21:50:02 +0000 2021
>Last-Modified: Sat Jul 10 21:50:02 +0000 2021
>Originator: Benjamin Lorenz
>Release: NetBSD 9.0
>Organization:
>Environment:
System: NetBSD chaos.lorenz.place 9.0 NetBSD 9.0 (GENERIC) #0: Sun Feb 23 00:32:42 CET 2020 bjjl@chaos.lorenz.place:/home/bjjl/9.0/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
When executing the `git push´command, then, during manual authentication,
the password should be hidden, but not the username. This is the behavior
e.g. on MacOS. On NetBSD 9.0 with the latest pkgsrc-2020Q1, the username
is also hidden while typing:
bjjl@chaos[pts/1]<faq>% git push (0) 14:41
Username for 'https://github.com': <-- when typing here, the characters are not displayed
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback
State-Changed-By: leot@NetBSD.org
State-Changed-When: Fri, 01 May 2020 17:11:05 +0000
State-Changed-Why:
Probably better to open such PR upstream (not really a pkgsrc issue)
From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/55225: git push not displaying username
Date: Fri, 01 May 2020 19:10:07 +0200
Hello Benjamin,
ben@pocket.services writes:
> [...]
> >Description:
>
> When executing the `git push´command, then, during manual authentication,
> the password should be hidden, but not the username. This is the behavior
> e.g. on MacOS. On NetBSD 9.0 with the latest pkgsrc-2020Q1, the username
> is also hidden while typing:
>
> bjjl@chaos[pts/1]<faq>% git push (0) 14:41
> Username for 'https://github.com': <-- when typing here, the characters are not displayed
> [...]
I don't think that's actually a pkgsrc bug (all pkgsrc patches seems
unrelated to prompt/credentials) and it's probably worth to fill a bug
report upstream.
Can you please open a bug report upstream and let us know about it so
we can reference it and follow/discuss/partecipate there?
Thanks!
From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/55225 (git push not displaying username)
Date: Fri, 01 May 2020 19:20:00 +0200
JFTR, possible simpler way to reproduce it (does not need any Git repo
around):
% printf 'protocol=http\nhost=example.org\n' | git credential fill
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55225 CVS commit: pkgsrc/devel/git-base
Date: Sat, 10 Jul 2021 19:06:01 +0000
Module Name: pkgsrc
Committed By: dholland
Date: Sat Jul 10 19:06:01 UTC 2021
Modified Files:
pkgsrc/devel/git-base: Makefile
Log Message:
PR 55225 from Benjamin Lorenz: git push not displaying username
Seems that the input code depends on a HAVE_DEV_TTY setting that
autoconf doesn't actually check. I guess Linux packagers set this
explicitly; we shall too. Otherwise it falls back to libc getpass()
for all input, which disables echo unconditionally.
PKGREVISION -> 1
To generate a diff of this commit:
cvs rdiff -u -r1.89 -r1.90 pkgsrc/devel/git-base/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 10 Jul 2021 21:50:02 +0000
State-Changed-Why:
fixed
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.