NetBSD Problem Report #55348

From www@netbsd.org  Fri Jun  5 19:36:24 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B9D8D1A9219
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  5 Jun 2020 19:36:23 +0000 (UTC)
Message-Id: <20200605193622.BE2361A921E@mollari.NetBSD.org>
Date: Fri,  5 Jun 2020 19:36:22 +0000 (UTC)
From: cmhanson@eschatologist.net
Reply-To: cmhanson@eschatologist.net
To: gnats-bugs@NetBSD.org
Subject: ham/rtl-sdr does not install manpages
X-Send-Pr-Version: www-1.0

>Number:         55348
>Category:       pkg
>Synopsis:       ham/rtl-sdr does not install manpages
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 05 19:40:00 +0000 2020
>Closed-Date:    Tue Jul 13 18:51:02 +0000 2021
>Last-Modified:  Tue Jul 13 18:51:02 +0000 2021
>Originator:     Chris Hanson
>Release:        9.0_2020Q1
>Organization:
>Environment:
NetBSD core.eschatologist.net 9.0_STABLE NetBSD 9.0_STABLE (GENERIC) #2: Mon Jun  1 14:08:20 PDT 2020  cmh@core.eschatologist.net:/usr/obj/sys/arch/amd64/compile/GENERIC amd64

>Description:
The pkgsrc build of ham/rtl-sdr does not include man pages for the rtl-sdr tools. This is probably because they’re in a “debian” subdirectory and not part of the main build for the project. The pkgsrc build should be adjusted to also install these man pages, otherwise they have to be installed by hand.
>How-To-Repeat:
1. Install ham/rtl-sdr from binary or pkgsrc.
2. man rtl_fm
3. Observe no man page found.
>Fix:
Adjust the pkgsrc build of ham/rtl-sdr to install the manpages from the debian subdirectory of the source project; the man pages are written for Debian Linux, but usable by others.

>Release-Note:

>Audit-Trail:
From: Makoto Fujiwara <makoto@if.t.u-tokyo.ac.jp>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/55348: ham/rtl-sdr does not install manpages
Date: Sat, 06 Jun 2020 15:29:23 +0900

 How about attached patch ?
 -- 
 Makoto Fujiwara
 mef@NetBSD.org
 makoto@if.t.u-tokyo.ac.jp
 Index: ham/rtl-sdr/Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/ham/rtl-sdr/Makefile,v
 retrieving revision 1.15
 diff -u -r1.15 Makefile
 --- ham/rtl-sdr/Makefile	3 Nov 2019 19:32:08 -0000	1.15
 +++ ham/rtl-sdr/Makefile	6 Jun 2020 06:23:54 -0000
 @@ -22,9 +22,17 @@
  PKGCONFIG_OVERRIDE+=	librtlsdr.pc.in

  LDFLAGS.SunOS+=		-lsocket -lnsl
 +INSTALLATION_DIRS+=	${PKGMANDIR}/man1"

  pre-configure:
  	${MKDIR} ${WRKSRC}/build

 +post-install:
 +.for i  in rtl_adsb.1   rtl_eeprom.1 rtl_fm.1     rtl_power.1  rtl_sdr.1    rtl_tcp.1    rtl_test.1
 +	(cd ${WRKSRC}/debian;  \
 +	${INSTALL} ${i} ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1 ; \
 +	)
 +.endfor
 +
  .include "../../devel/libusb1/buildlink3.mk"
  .include "../../mk/bsd.pkg.mk"
 Index: ham/rtl-sdr/PLIST
 ===================================================================
 RCS file: /cvsroot/pkgsrc/ham/rtl-sdr/PLIST,v
 retrieving revision 1.2
 diff -u -r1.2 PLIST
 --- ham/rtl-sdr/PLIST	26 Jan 2016 09:10:39 -0000	1.2
 +++ ham/rtl-sdr/PLIST	6 Jun 2020 06:23:54 -0000
 @@ -1,4 +1,4 @@
 -@comment $NetBSD: PLIST,v 1.2 2016/01/26 09:10:39 dbj Exp $
 +@comment $NetBSD$
  bin/rtl_adsb
  bin/rtl_eeprom
  bin/rtl_fm
 @@ -13,3 +13,10 @@
  lib/librtlsdr.so.0
  lib/librtlsdr.so.${PKGVERSION}
  lib/pkgconfig/librtlsdr.pc
 +man/man1/rtl_adsb.1
 +man/man1/rtl_eeprom.1
 +man/man1/rtl_fm.1
 +man/man1/rtl_power.1
 +man/man1/rtl_sdr.1
 +man/man1/rtl_tcp.1
 +man/man1/rtl_test.1

From: Thomas Klausner <tk@giga.or.at>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/55348: ham/rtl-sdr does not install manpages
Date: Sat, 6 Jun 2020 10:16:15 +0200

 On Sat, Jun 06, 2020 at 06:30:02AM +0000, Makoto Fujiwara wrote:
 > The following reply was made to PR pkg/55348; it has been noted by GNATS.
 > 
 > From: Makoto Fujiwara <makoto@if.t.u-tokyo.ac.jp>
 > To: gnats-bugs@netbsd.org
 > Cc: 
 > Subject: Re: pkg/55348: ham/rtl-sdr does not install manpages
 > Date: Sat, 06 Jun 2020 15:29:23 +0900
 > 
 >  How about attached patch ?
 >  -- 
 >  Makoto Fujiwara
 >  mef@NetBSD.org
 >  makoto@if.t.u-tokyo.ac.jp
 >  Index: ham/rtl-sdr/Makefile
 >  ===================================================================
 >  RCS file: /cvsroot/pkgsrc/ham/rtl-sdr/Makefile,v
 >  retrieving revision 1.15
 >  diff -u -r1.15 Makefile
 >  --- ham/rtl-sdr/Makefile	3 Nov 2019 19:32:08 -0000	1.15
 >  +++ ham/rtl-sdr/Makefile	6 Jun 2020 06:23:54 -0000
 >  @@ -22,9 +22,17 @@
 >   PKGCONFIG_OVERRIDE+=	librtlsdr.pc.in
 >   
 >   LDFLAGS.SunOS+=		-lsocket -lnsl
 >  +INSTALLATION_DIRS+=	${PKGMANDIR}/man1"

 That quote seems so alone and lost :)
  Thomas

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55348 CVS commit: pkgsrc/ham/rtl-sdr
Date: Sat, 10 Jul 2021 16:48:00 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Sat Jul 10 16:48:00 UTC 2021

 Modified Files:
 	pkgsrc/ham/rtl-sdr: Makefile PLIST

 Log Message:
 ham/rtl-sdr: apply patch from mef@ to fix PR pkg/55348.

 Install the man pages. PKGREVISION -> 1.
 (with minor adjustments to the proposed patch)


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 pkgsrc/ham/rtl-sdr/Makefile
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/ham/rtl-sdr/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 13 Jul 2021 18:51:02 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search