NetBSD Problem Report #55401

From www@netbsd.org  Fri Jun 19 15:50:18 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B905E1A9217
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 19 Jun 2020 15:50:18 +0000 (UTC)
Message-Id: <20200619155017.CC4E21A921F@mollari.NetBSD.org>
Date: Fri, 19 Jun 2020 15:50:17 +0000 (UTC)
From: venture37@geeklan.co.uk
Reply-To: venture37@geeklan.co.uk
To: gnats-bugs@NetBSD.org
Subject: pktools/pkg_install 'IS_URL' macro redefined during bootstrap
X-Send-Pr-Version: www-1.0

>Number:         55401
>Category:       pkg
>Synopsis:       pktools/pkg_install 'IS_URL' macro redefined during bootstrap
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    agc
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 19 15:55:00 +0000 2020
>Closed-Date:    Wed Nov 08 01:25:43 +0000 2023
>Last-Modified:  Wed Nov 08 01:35:01 +0000 2023
>Originator:     Sevan Janiyan
>Release:        pkgrsc-current
>Organization:
>Environment:
FreeBSD 12.1-RELEASE amd64
>Description:
cc -DHAVE_CONFIG_H -DDEF_LOG_DIR=\"/tmp/pkg3/pkgdb\" -I/usr/pkgsrc/bootstrap/work/libnbcompat -I/usr/pkgsrc/bootstrap/work/libarchive/libarchive -I. -I. -DSYSCONFDIR=\"/tmp/pkg3/etc\" -DBOOTSTRAP -g -O2 -c pkg_io.c
In file included from pkg_io.c:58:
./lib.h:243:9: warning: 'IS_URL' macro redefined [-Wmacro-redefined]
#define IS_URL(str)     (URLlength(str) > 0)
        ^
pkg_io.c:53:9: note: previous definition is here
#define IS_URL(x) 0
        ^
1 warning generated.
>How-To-Repeat:

>Fix:
Index: pkgtools/pkg_install/files/lib/pkg_io.c
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/lib/pkg_io.c,v
retrieving revision 1.13
diff -u -p -r1.13 pkg_io.c
--- pkgtools/pkg_install/files/lib/pkg_io.c     16 Jul 2017 16:51:48 -0000      1.13
+++ pkgtools/pkg_install/files/lib/pkg_io.c     19 Jun 2020 15:48:11 -0000
@@ -48,14 +48,14 @@ __RCSID("$NetBSD: pkg_io.c,v 1.13 2017/0
 #endif
 #include <stdlib.h>

+#include "lib.h"
+
 #ifdef BOOTSTRAP
 #undef IS_URL
 #define IS_URL(x) 0
 #else
 #include <fetch.h>
 #endif
-
-#include "lib.h"

 struct pkg_path {
        TAILQ_ENTRY(pkg_path) pl_link;

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->freebsd-pkg-people
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Wed, 24 Jun 2020 11:46:55 +0000
Responsible-Changed-Why:
FreeBSD problem


Responsible-Changed-From-To: freebsd-pkg-people->pkg-manager
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Wed, 24 Jun 2020 12:22:28 +0000
Responsible-Changed-Why:
Manifests on FreeBSD but probably not strictly FreeBSD related
(via private email from <sevan)


Responsible-Changed-From-To: pkg-manager->agc
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Sun, 23 Aug 2020 09:01:33 +0000
Responsible-Changed-Why:
to pkg_install MAINTAINER
(if you think the patch is ok, send it back to me and I'll go commit it
)


From: Alex Crooks <alexcrooks2@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/55401
Date: Tue, 7 Nov 2023 15:47:03 -0800

 --0000000000000e69c106099897d0
 Content-Type: text/plain; charset="UTF-8"

 Looks good to me!

 -- 
 *Alexander Crooks*
 *alexcrooks2@gmail.com <alexcrooks2@gmail.com>*
 *(408) 499-9072*

 --0000000000000e69c106099897d0
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr">Looks good to me!<br clear=3D"all"><div><br></div><span cl=
 ass=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmai=
 l_signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div><div =
 dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div style=3D"font-size:small=
 "><div dir=3D"ltr"><div dir=3D"ltr"><font fac=
 e=3D"garamond, serif">Alexander Crooks</font><div style=3D"font-size:12=
 .8px"><font face=3D"garamond, serif"><a href=3D"mailto:alexcrooks2@gmail=
 .com" style=3D"color:rgb(17,85,204)" target=3D"_blank">alexcrooks2@gmail.co=
 m</a></font></div><div style=3D"font-size:12.8px"><span style=3D"font-s=
 ize:12.8px"><font face=3D"garamond, serif">(408) 499-9072</font></sp=
 an></div></div></div></div></div></div></div></div></div></div></div>

 --0000000000000e69c106099897d0--

From: Alex Crooks <alexcrooks2@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/55401
Date: Tue, 7 Nov 2023 17:13:11 -0800

 --0000000000001e15a4060999cbd4
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 Any reason why it's not up yet?

 On Tue, Nov 7, 2023 at 3:47=E2=80=AFPM Alex Crooks <alexcrooks2@gmail.com> =
 wrote:

 > Looks good to me!
 >
 > --
 > *Alexander Crooks*
 > *alexcrooks2@gmail.com <alexcrooks2@gmail.com>*
 > *(408) 499-9072*
 >


 --=20
 *Alexander Crooks*
 *alexcrooks2@gmail.com <alexcrooks2@gmail.com>*
 *(408) 499-9072*

 --0000000000001e15a4060999cbd4
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr">Any reason why it&#39;s not up yet?</div><br><div class=3D=
 "gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Nov 7, 2023 at =
 3:47=E2=80=AFPM Alex Crooks &lt;<a href=3D"mailto:alexcrooks2@gmail.com">al=
 excrooks2@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quot=
 e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
 ;padding-left:1ex"><div dir=3D"ltr">Looks good to me!<br clear=3D"all"><div=
 ><br></div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D=
 "ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div=
  dir=3D"ltr"><div dir=3D"ltr"><div style=3D"font-size:small"><div dir=3D"lt=
 r"><div dir=3D"ltr"><font face=3D"garamond, s=
 erif">Alexander Crooks</font><div style=3D"font-size:12.8px"><font face=
 =3D"garamond, serif"><a href=3D"mailto:alexcrooks2@gmail.com" style=3D"c=
 olor:rgb(17,85,204)" target=3D"_blank">alexcrooks2@gmail.com</a></font>=
 </div><div style=3D"font-size:12.8px"><span style=3D"font-size:12.8px"><=
 font face=3D"garamond, serif">(408) 499-9072</font></span></div></div><=
 /div></div></div></div></div></div></div></div></div>
 </blockquote></div><br clear=3D"all"><div><br></div><span class=3D"gmail_si=
 gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d=
 iv dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div=
  style=3D"font-size:small"><div dir=3D"ltr"><div dir=3D"ltr"><b style=3D"fo=
 nt-size:12.8px"><font face=3D"garamond, serif">Alexander Crooks</font><=
 div style=3D"font-size:12.8px"><font face=3D"garamond, serif"><a href=3D=
 "mailto:alexcrooks2@gmail.com" style=3D"color:rgb(17,85,204)" target=3D"_bl=
 ank">alexcrooks2@gmail.com</a></font></div><div style=3D"font-size:12.8=
 px"><span style=3D"font-size:12.8px"><font face=3D"garamond, serif">(408=
 ) 499-9072</font></span></div></div></div></div></div></div></div></div=
 ></div></div>

 --0000000000001e15a4060999cbd4--

State-Changed-From-To: open->closed
State-Changed-By: agc@NetBSD.org
State-Changed-When: Wed, 08 Nov 2023 01:25:43 +0000
State-Changed-Why:
Applied the fix in the PR, after lots of encouragement. Thanks, and sorry for the delay

Closing PR now


From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55401 CVS commit: pkgsrc/pkgtools/pkg_install/files/lib
Date: Wed, 8 Nov 2023 01:24:30 +0000

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Wed Nov  8 01:24:29 UTC 2023

 Modified Files:
 	pkgsrc/pkgtools/pkg_install/files/lib: pkg_io.c

 Log Message:
 Fix PR pkg/55401 from Sevan Janiyan, and after some testing and
 encouragement from David Holland, and also the younger generation -
 apply the fix from the PR.

 Thanks for the PR, the fix, and the nudges, folks, and sorry it took so long!


 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/pkgtools/pkg_install/files/lib/pkg_io.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.47 2022/09/11 19:34:41 kim Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2023 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.