NetBSD Problem Report #55422

From tsutsui@ceres.dti.ne.jp  Fri Jun 26 12:31:26 2020
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 15A061A9217
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 26 Jun 2020 12:31:26 +0000 (UTC)
Message-Id: <202006261231.05QCVGQ8000299@ceres.dti.ne.jp>
Date: Fri, 26 Jun 2020 21:31:16 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: xorg.conf(5) man page missed substitution
X-Send-Pr-Version: 3.95

>Number:         55422
>Notify-List:    kim
>Category:       xsrc
>Synopsis:       xorg.conf(5) man page missed substitution
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    xsrc-manager
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 26 12:35:00 +0000 2020
>Closed-Date:    Tue Oct 27 16:55:54 +0000 2020
>Last-Modified:  Tue Oct 27 16:55:54 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0
>Organization:
>Environment:
System: NetBSD mirage 9.0 NetBSD 9.0 (GENERIC) #23: Wed May 13 04:08:16 JST 2020 tsutsui@mirage:/s/netbsd-9/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386, maybe all
>Description:
xorg.conf(5) man page in NetBSD 9.0 has various @foo@ strings:

---
xorg.conf(@filemansuffix@) 

NAME
       xorg.conf, @xconfigdir@ - configuration files for Xorg X server

 :

DESCRIPTION
       Xorg uses a configuration file called xorg.conf and files ending in the
       suffix .conf from the directory @xconfigdir@ for its initial setup.

 :

           /etc/X11/<cmdline>
           @projectroot@/etc/X11/<cmdline>
           /etc/X11/$XORGCONFIG
           @projectroot@/etc/X11/$XORGCONFIG
           /etc/X11/xorg.conf
           /etc/xorg.conf
           @projectroot@/etc/X11/xorg.conf.<hostname>
           @projectroot@/etc/X11/xorg.conf
           @projectroot@/lib/X11/xorg.conf.<hostname>
           @projectroot@/lib/X11/xorg.conf

 :

>How-To-Repeat:
man xorg.conf

Xorg(1) etc. has the similar problem.

>Fix:
Invoke proper pre-process programs during build?

---
Izumi Tsutsui

>Release-Note:

>Audit-Trail:
From: matthew green <mrg@eterna.com.au>
To: gnats-bugs@netbsd.org
Cc: xsrc-manager@netbsd.org, gnats-admin@netbsd.org,
    netbsd-bugs@netbsd.org
Subject: re: xsrc/55422: xorg.conf(5) man page missed substitution
Date: Sat, 27 Jun 2020 19:18:03 +1000

 probably good to add something like i added for .pc files where
 the build fails if these missing substs are found, once we fix
 all these issues.

 thanks.


 .mrg.

From: "David H. Gutteridge" <david@gutteridge.ca>
To: gnats-bugs@netbsd.org
Cc: mrg@netbsd.org
Subject: Re: xsrc/55422: xorg.conf(5) man page missed substitution
Date: Sat, 27 Jun 2020 15:01:08 -0400

 From what I see, there's already handling for this in bsd.x11.mk, it's
 just that xorg-server changed the section 1 and 5 man page substitution
 strings from __foo__ to @foo@ some time between 1.18.4 and 1.20.3.
 (While the section 4 man pages in our tree still use __foo__.) So it
 looks like a mechanical process of finding all the @foo@ values, and
 adding them to the _X11MANTRANSFORM definition in bsd.x11.mk. In which
 case, I can handle this, if no one else is already working on it, or
 prefers to work on it themselves. (I'd already been looking at it, as
 co-incidentally I noticed the same issue in xorg.conf[5] a few days ago
 while I was testing SNA vs. UXA.)

 Dave


From: "matthew green" <mrg@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55422 CVS commit: src
Date: Mon, 10 Aug 2020 09:23:38 +0000

 Module Name:	src
 Committed By:	mrg
 Date:		Mon Aug 10 09:23:37 UTC 2020

 Modified Files:
 	src/external/mit/xorg/server/xorg-server/doc: Makefile
 	src/external/mit/xorg/server/xorg-server/hw/xfree86/doc: Makefile
 	src/share/mk: bsd.x11.mk

 Log Message:
 fix various missing transforms for man page, ala PR#55422.

 add method to transform both the "__foo__" and "@foo@"
 version of various transforms, while upstream are converting
 from the former to the latter it seems.  convert all the
 common transforms to this method.

 expand the grep for .pc files to look for missing @foo@
 fixes to the man page genration, and ignore a few things
 (thanks uwe@ - .IN lines, and stuff between tab(@) and .TE.)

 xorg-server __default_font_path__ -> @default_font_path@,
 and xfree86 transform xconfigdir, xkbdir, and modulepath
 using new both method.


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6 \
     src/external/mit/xorg/server/xorg-server/doc/Makefile
 cvs rdiff -u -r1.7 -r1.8 \
     src/external/mit/xorg/server/xorg-server/hw/xfree86/doc/Makefile
 cvs rdiff -u -r1.135 -r1.136 src/share/mk/bsd.x11.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55422 CVS commit: [netbsd-9] src
Date: Thu, 20 Aug 2020 16:15:44 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Thu Aug 20 16:15:44 UTC 2020

 Modified Files:
 	src/external/mit/xorg/server/xorg-server/doc [netbsd-9]: Makefile
 	src/external/mit/xorg/server/xorg-server/hw/xfree86/doc [netbsd-9]:
 	    Makefile
 	src/share/mk [netbsd-9]: bsd.x11.mk

 Log Message:
 Pull up following revision(s) (requested by kim in ticket #1059):

 	share/mk/bsd.x11.mk: revision 1.133
 	share/mk/bsd.x11.mk: revision 1.136
 	external/mit/xorg/server/xorg-server/hw/xfree86/doc/Makefile: revision 1.8
 	external/mit/xorg/server/xorg-server/doc/Makefile: revision 1.6

 Allow overriding the default man substitutions with X11EXTRAMANTRANSFORMS
 fix various missing transforms for man page, ala PR#55422.
 add method to transform both the "__foo__" and "@foo@"
 version of various transforms, while upstream are converting
 from the former to the latter it seems.  convert all the
 common transforms to this method.

 expand the grep for .pc files to look for missing @foo@

 fixes to the man page genration, and ignore a few things
 (thanks uwe@ - .IN lines, and stuff between tab(@) and .TE.)

 xorg-server __default_font_path__ -> @default_font_path@,
 and xfree86 transform xconfigdir, xkbdir, and modulepath
 using new both method.


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.5.16.1 \
     src/external/mit/xorg/server/xorg-server/doc/Makefile
 cvs rdiff -u -r1.7 -r1.7.16.1 \
     src/external/mit/xorg/server/xorg-server/hw/xfree86/doc/Makefile
 cvs rdiff -u -r1.132.2.1 -r1.132.2.2 src/share/mk/bsd.x11.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Tue, 27 Oct 2020 16:55:54 +0000
State-Changed-Why:
Confirmed fixed even on NetBSD 9.1.


>Unformatted:

Home	PR Database Search